Re: [PATCH RFC 1/2] dt-bindings: leds-group-multicolor: Introduce default-intensity

[Jonas Rebmann <jre@pengutronix.de>]

Hi Stefan,

Thanks, for CCing me here.

On 2026-07-13 10:23, Stefan Wahren wrote:
> sorry, I missed this. Thanks for pointing to this patch. In general i'm
> fine with this approach, but there is something which confuses me.
> Looking at the description, there is the statement: [default-intensity]
> "Defaults to 0".
> This seems to be correct for the Linux implementation of
> leds-pwm-multicolor, but is this really an expectation along all (multi
> color) LEDs (at least for Linux)?

You are right, sadly the initialization default of some
multicolor-LED drivers differs.

> E.g. leds-group-multicolor init the intensity with the maximum. So all
> users of leds-group-multicolor should specify default-intensity for each
> sub LED to achieve a defined behavior without breaking existing behavior.

I agree, once support is added to one of the drivers that doesn't
zero-initialize, the documentation needs updating (because as you say,
backwards-compatibilty probably beats consistency here).

I'm also just noticing that my v3 for only the dt-bindings never arrived
on the list (I think I was on a buggy b4 master), I'll re-send now.

Regards,
Jonas

-- 
Pengutronix e.K.                           | Jonas Rebmann               |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |