From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Steve Glendinning <steve.glendinning@smsc.com>,
Guenter Roeck <linux@roeck-us.net>,
Jeremy Linton <jeremy.linton@arm.com>,
Kamlakant Patel <kamlakant.patel@broadcom.com>,
Pavel Fedin <p.fedin@samsung.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] net: smsc911x: augment device tree bindings
Date: Wed, 24 Aug 2016 17:55:41 +0200 [thread overview]
Message-ID: <11789209.AN7vYDaEbx@wuerfel> (raw)
In-Reply-To: <1472043582-7653-1-git-send-email-linus.walleij@linaro.org>
On Wednesday, August 24, 2016 2:59:40 PM CEST Linus Walleij wrote:
> +- interrupts : Should contain the SMSC LAN
> + interrupt line as cell 0, cell 1 is an OPTIONAL PME (power
> + management event) interrupt that is able to wake up the host
> + system with a 50ms pulse on network activity
> + For generic bindings for interrupt controller parents, refer to
> + interrupt-controller/interrupts.txt
I think you should (slightly) reword this to avoid using the
term "cell", which refers to a 32-bit word in the property,
not the interrupt specifier that is often made up of two or
three cells.
Maybe something like
- interrupts: one or two interrupt specifiers:
- The first interrupt is the SMSC LAN interrupt line.
- The second interrupt (if present) is the power management
event ...
Arnd
prev parent reply other threads:[~2016-08-24 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 12:59 [PATCH 1/3 v2] net: smsc911x: augment device tree bindings Linus Walleij
2016-08-24 15:55 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11789209.AN7vYDaEbx@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jeremy.linton@arm.com \
--cc=kamlakant.patel@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=p.fedin@samsung.com \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox