[PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: correct the board ID

[PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: correct the board ID

[Dawid Wróbel via B4 Relay]

From: Dawid Wróbel <me@dawidwrobel.com>

elish declares the same qcom,msm-id and qcom,board-id pair as
sm8250-sony-xperia-edo.dtsi, so a bootloader choosing between appended
device trees cannot tell the two boards apart.

0x10008 is Sony's value. The downstream device tree for this board,
elish-sm8250-overlay.dts, uses qcom,board-id = <47 0>, i.e. platform
type 0x2f.

Fixes: a41b617530bf ("arm64: dts: qcom: sm8250: Add device tree for Xiaomi Mi Pad 5 Pro")
Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
Not tested on elish hardware: the corrected value comes from the
downstream device tree:
https://github.com/LineageOS/android_kernel_xiaomi_sm8250/blob/a04dba03999b36cc8f472c014063395b41fb1022/arch/arm64/boot/dts/vendor/qcom/elish-sm8250-overlay.dts#L14

That import commit (bf5acbcaca99) credits Xiaomi's munch-s-oss and
dagu-s-oss releases; Xiaomi's published kernel repo doesn't contain
the device trees, so LineageOS seems to be the only public source.

No user-visible impact: nothing in the kernel reads qcom,board-id, and it
is only consulted when a bootloader selects between several appended
device trees. Not needed for stable.
---
 arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
index 19aff83ecf7b..945127dacc82 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
@@ -29,7 +29,7 @@ / {
 
 	/* required for bootloader to select correct board */
 	qcom,msm-id = <QCOM_ID_SM8250 0x20001>; /* SM8250 v2.1 */
-	qcom,board-id = <0x10008 0>;
+	qcom,board-id = <0x2f 0>;
 
 	aliases {
 		serial0 = &uart6;

---
base-commit: 7f102800164990609e2b272396d45b197a55bd04
change-id: 20260730-elish-board-id-8ccd9a857382

Best regards,
-- 
Dawid Wróbel <me@dawidwrobel.com>

Re: [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: correct the board ID

[Dmitry Baryshkov]

On Thu, Jul 30, 2026 at 03:44:07PM +0200, Dawid Wróbel via B4 Relay wrote:
> From: Dawid Wróbel <me@dawidwrobel.com>
> 
> elish declares the same qcom,msm-id and qcom,board-id pair as
> sm8250-sony-xperia-edo.dtsi, so a bootloader choosing between appended
> device trees cannot tell the two boards apart.
> 
> 0x10008 is Sony's value. The downstream device tree for this board,
> elish-sm8250-overlay.dts, uses qcom,board-id = <47 0>, i.e. platform
> type 0x2f.
> 
> Fixes: a41b617530bf ("arm64: dts: qcom: sm8250: Add device tree for Xiaomi Mi Pad 5 Pro")
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---
> Not tested on elish hardware: the corrected value comes from the
> downstream device tree:
> https://github.com/LineageOS/android_kernel_xiaomi_sm8250/blob/a04dba03999b36cc8f472c014063395b41fb1022/arch/arm64/boot/dts/vendor/qcom/elish-sm8250-overlay.dts#L14
> 
> That import commit (bf5acbcaca99) credits Xiaomi's munch-s-oss and
> dagu-s-oss releases; Xiaomi's published kernel repo doesn't contain
> the device trees, so LineageOS seems to be the only public source.

DTs are in a separate repo, I believe.

> 
> No user-visible impact: nothing in the kernel reads qcom,board-id, and it
> is only consulted when a bootloader selects between several appended
> device trees. Not needed for stable.
> ---
>  arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>



-- 
With best wishes
Dmitry

Re: [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: correct the board ID

[Dawid Wrobel]

On 30.07.2026 15:57, Dmitry Baryshkov wrote:

> DTs are in a separate repo, I believe.

Indeed, thank you:
https://github.com/MiCode/kernel_devicetree/blob/elish-r-oss/qcom/elish-sm8250-overlay.dts#L14

I'll leave the original cover note as-is, don't think it's v2-worthy.

-- 
With Kind Regards,
Dawid Wrobel

Re: [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: correct the board ID

[Konrad Dybcio]

On 7/30/26 3:44 PM, Dawid Wróbel via B4 Relay wrote:
> From: Dawid Wróbel <me@dawidwrobel.com>
> 
> elish declares the same qcom,msm-id and qcom,board-id pair as
> sm8250-sony-xperia-edo.dtsi, so a bootloader choosing between appended
> device trees cannot tell the two boards apart.
> 
> 0x10008 is Sony's value. The downstream device tree for this board,
> elish-sm8250-overlay.dts, uses qcom,board-id = <47 0>, i.e. platform
> type 0x2f.
> 
> Fixes: a41b617530bf ("arm64: dts: qcom: sm8250: Add device tree for Xiaomi Mi Pad 5 Pro")
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad