From: Jon Loeliger <jdl-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss
<devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
Subject: Re: [2/5] dtc: Use flex's YY_USER_ACTION feature to avoid code duplication
Date: Thu, 02 Oct 2008 11:25:27 -0500 [thread overview]
Message-ID: <1222964727.9242.10.camel@ld0161-tx32> (raw)
In-Reply-To: <20081002140556.GF11662-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
On Fri, 2008-10-03 at 00:05 +1000, David Gibson wrote:
> Current, every lexer rule starts with some boiler plate to update the
> yylloc value for use by the parser. One of the rules, even mistakenly
> has a redundant allocation to one of the members.
>
> This patch uses the flex YY_USER_ACTION macro hook, which is executed
> before every rule to avoid this duplication.
>
> Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
>
> ---
This, and the xstrdup() change are both excellent suggestions.
jdl
next prev parent reply other threads:[~2008-10-02 16:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 14:04 [0/5] dtc: srcpos, input handling cleanups David Gibson
[not found] ` <20081002140427.GD11662-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-02 14:05 ` [1/5] dtc: Implement and use an xstrdup() function David Gibson
[not found] ` <20081002140512.GE11662-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-02 14:05 ` [2/5] dtc: Use flex's YY_USER_ACTION feature to avoid code duplication David Gibson
[not found] ` <20081002140556.GF11662-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-02 14:06 ` [3/5] dtc: Cleanup yyerrorf() function David Gibson
[not found] ` <20081002140652.GG11662-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-02 14:07 ` [4/5] dtc: Cleanup yylloc type and handling David Gibson
[not found] ` <20081002140753.GH11662-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-02 14:09 ` [5/5] dtc: Clean up source file management David Gibson
2008-10-03 19:24 ` [4/5] dtc: Cleanup yylloc type and handling Jon Loeliger
[not found] ` <E1KlqGI-0006JF-6p-CYoMK+44s/E@public.gmane.org>
2008-10-04 2:25 ` David Gibson
2008-10-03 19:22 ` [3/5] dtc: Cleanup yyerrorf() function Jon Loeliger
[not found] ` <E1KlqEb-0006Io-Sc-CYoMK+44s/E@public.gmane.org>
2008-10-04 2:56 ` David Gibson
2008-10-02 16:25 ` Jon Loeliger [this message]
2008-10-03 1:05 ` [2/5] dtc: Use flex's YY_USER_ACTION feature to avoid code duplication David Gibson
[not found] ` <20081003010531.GE3002-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2008-10-03 14:17 ` Jon Loeliger
[not found] ` <48E62991.6010102-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2008-10-04 4:13 ` David Gibson
2008-10-03 17:16 ` Jon Loeliger
2008-10-03 17:17 ` [1/5] dtc: Implement and use an xstrdup() function Jon Loeliger
[not found] ` <E1KloHP-0005pb-R8-CYoMK+44s/E@public.gmane.org>
2008-10-04 2:49 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222964727.9242.10.camel@ld0161-tx32 \
--to=jdl-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox