From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org,
microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH 6/6] of/device: populate platform_device (of_device) resource table on allocation
Date: Thu, 10 Jun 2010 16:17:43 +1000 [thread overview]
Message-ID: <1276150663.1962.43.camel@pasglop> (raw)
In-Reply-To: <20100608194809.GA32732-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
> You just introduced an unnamed structure of device + resources,
> it isn't declared anywhere but in the code itself (either via
> &foo[1] or buf + sizeof(*foo)).
>
> You're not the only one who hacks (or at least have to
> understand) the OF stuff, so let's try keep this stuff
> readable?
>
> I told you several ways of how to improve the code (based on
> the ideas from drivers/base/, so the ideas aren't even mine,
> fwiw).
I tend to agree with Anton here.
BTW. Why not make of_device a wrapper (or even alias of)
platform_device ? :-) That way you get the resource array etc.. for free
and it will make the whole of_device vs. platform_device issue moot.
Cheers,
Ben.
next prev parent reply other threads:[~2010-06-10 6:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 14:26 [PATCH 0/6] OF device code merges and improvements Grant Likely
2010-06-08 14:26 ` [PATCH 1/6] of: Use full node name in resource structures Grant Likely
2010-06-08 14:26 ` [PATCH 2/6] of/device: merge of_device_uevent Grant Likely
2010-06-08 14:26 ` [PATCH 3/6] of: Modify of_device_get_modalias to be passed struct device Grant Likely
2010-06-08 14:26 ` [PATCH 4/6] of/device: Merge of_platform_bus_probe() Grant Likely
2010-06-08 14:26 ` [PATCH 5/6] of: Merge of_device_alloc Grant Likely
2010-06-08 14:26 ` [PATCH 6/6] of/device: populate platform_device (of_device) resource table on allocation Grant Likely
2010-06-08 15:57 ` Anton Vorontsov
[not found] ` <20100608155702.GA5419-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2010-06-08 16:02 ` Grant Likely
[not found] ` <AANLkTinZT4z93SWxjce5oRZzmaQHtVnO96zsXO9OX2UZ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-08 16:46 ` Anton Vorontsov
2010-06-08 18:41 ` Grant Likely
2010-06-08 19:48 ` Anton Vorontsov
[not found] ` <20100608194809.GA32732-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2010-06-10 6:17 ` Benjamin Herrenschmidt [this message]
2010-06-10 14:18 ` Grant Likely
[not found] ` <AANLkTilpUi1cazljWSFbzliY78RKyHUlvBshUD3NPHPv-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-10 15:13 ` M. Warner Losh
[not found] ` <20100610.091357.513168276793712624.imp-uzTCJ5RojNnQT0dZR+AlfA@public.gmane.org>
2010-06-10 15:47 ` Anton Vorontsov
2010-06-10 15:47 ` Anton Vorontsov
2010-06-10 15:47 ` Anton Vorontsov
[not found] ` <20100610154741.GA7484@oksana.dev.rtsoft.ru>
[not found] ` <20100610154741.GA7484-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2010-06-10 16:01 ` M. Warner Losh
2010-06-10 16:52 ` Anton Vorontsov
[not found] ` <20100610165243.GA18043-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2010-06-10 17:09 ` Mitch Bradley
[not found] ` <4C111C34.1010708-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2010-06-10 17:20 ` Grant Likely
2010-06-10 17:09 ` M. Warner Losh
2010-06-11 1:14 ` Benjamin Herrenschmidt
2010-06-10 16:30 ` Grant Likely
[not found] ` <AANLkTimjIyclTWZZW1A26zOcWroK-bwOkmEqsLm4DINk-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-10 17:10 ` Anton Vorontsov
2010-06-10 17:21 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276150663.1962.43.camel@pasglop \
--to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
--cc=cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox