[PATCH] of: Add missing of_address.h to xilinx ehci driver

[PATCH] of: Add missing of_address.h to xilinx ehci driver

[Michal Simek]

Build log:
In file included from drivers/usb/host/ehci-hcd.c:1208:
drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource'

Signed-off-by: John Williams <john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
---
 drivers/usb/host/ehci-xilinx-of.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
index e8f4f36..a6f21b8 100644
--- a/drivers/usb/host/ehci-xilinx-of.c
+++ b/drivers/usb/host/ehci-xilinx-of.c
@@ -29,6 +29,7 @@
 
 #include <linux/of.h>
 #include <linux/of_platform.h>
+#include <linux/of_address.h>
 
 /**
  * ehci_xilinx_of_setup - Initialize the device for ehci_reset()
-- 
1.5.5.6

Re: Fwd: [PATCH] of: Add missing of_address.h to xilinx ehci driver

[Harry Wei]

On Mon, Feb 14, 2011 at 11:53:13PM +0800, harryxiyou wrote:
> ---------- Forwarded message ----------
> From: Michal Simek <monstr@monstr.eu>
> Date: 2011/2/14
> Subject: [PATCH] of: Add missing of_address.h to xilinx ehci driver
> To: glikely@secretlab.ca
> Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org,
> Michal Simek <monstr@monstr.eu>, John Williams <john.williams@petalogix.com>
> 
> 
> Build log:
> In file included from drivers/usb/host/ehci-hcd.c:1208:
> drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
> drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of
> function 'of_address_to_resource'
> 
> Signed-off-by: John Williams <john.williams@petalogix.com>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: Harry Wei <harryxiyou@gmail.com> 
> ---
>  drivers/usb/host/ehci-xilinx-of.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-xilinx-of.c
> b/drivers/usb/host/ehci-xilinx-of.c
> index e8f4f36..a6f21b8 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -29,6 +29,7 @@
> 
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
> +#include <linux/of_address.h>
> 
>  /**
>  * ehci_xilinx_of_setup - Initialize the device for ehci_reset()
> --
> 1.5.5.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> 
> -- 
> Best Regards.
> Harry Wei.
> Do what u like!

Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver

[Grant Likely]

On Mon, Feb 14, 2011 at 3:40 AM, Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org> wrote:
> Build log:
> In file included from drivers/usb/host/ehci-hcd.c:1208:
> drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
> drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource'
>
> Signed-off-by: John Williams <john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
> Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>

Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

Greg, let me know if you want me to pick this one up for my next pull req.

g.

> ---
>  drivers/usb/host/ehci-xilinx-of.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> index e8f4f36..a6f21b8 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -29,6 +29,7 @@
>
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
> +#include <linux/of_address.h>
>
>  /**
>  * ehci_xilinx_of_setup - Initialize the device for ehci_reset()
> --
> 1.5.5.6
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver

[Greg KH]

On Mon, Feb 14, 2011 at 06:54:08AM -0700, Grant Likely wrote:
> On Mon, Feb 14, 2011 at 3:40 AM, Michal Simek <monstr@monstr.eu> wrote:
> > Build log:
> > In file included from drivers/usb/host/ehci-hcd.c:1208:
> > drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
> > drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource'
> >
> > Signed-off-by: John Williams <john.williams@petalogix.com>
> > Signed-off-by: Michal Simek <monstr@monstr.eu>
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> 
> Greg, let me know if you want me to pick this one up for my next pull req.

Sure, please do that, it makes a bit more sense for you to take it if
you need to.

  Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

thanks,

greg k-h

Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver

[Grant Likely]

On Mon, Feb 14, 2011 at 11:40:09AM +0100, Michal Simek wrote:
> Build log:
> In file included from drivers/usb/host/ehci-hcd.c:1208:
> drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':
> drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of function 'of_address_to_resource'
> 
> Signed-off-by: John Williams <john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
> Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>

Applied, thanks.

g.

> ---
>  drivers/usb/host/ehci-xilinx-of.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> index e8f4f36..a6f21b8 100644
> --- a/drivers/usb/host/ehci-xilinx-of.c
> +++ b/drivers/usb/host/ehci-xilinx-of.c
> @@ -29,6 +29,7 @@
>  
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
> +#include <linux/of_address.h>
>  
>  /**
>   * ehci_xilinx_of_setup - Initialize the device for ehci_reset()
> -- 
> 1.5.5.6
> 

Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver

[John Williams]

[-- Attachment #1.1: Type: text/plain, Size: 734 bytes --]

On Wed, Feb 16, 2011 at 6:40 AM, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>wrote:

> On Mon, Feb 14, 2011 at 11:40:09AM +0100, Michal Simek wrote:
> > Build log:
> > In file included from drivers/usb/host/ehci-hcd.c:1208:
> > drivers/usb/host/ehci-xilinx-of.c: In function
> 'ehci_hcd_xilinx_of_probe':
> > drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of
> function 'of_address_to_resource'
> >
> > Signed-off-by: John Williams <john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
> > Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
>
> Applied, thanks.
>

FYI I haven't tried building it, but I believe that ehci-ppc-of.c will need
the same patch.

John

[-- Attachment #1.2: Type: text/html, Size: 1279 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver

[Grant Likely]

On Wed, Feb 16, 2011 at 06:58:26AM +1000, John Williams wrote:
> On Wed, Feb 16, 2011 at 6:40 AM, Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>wrote:
> 
> > On Mon, Feb 14, 2011 at 11:40:09AM +0100, Michal Simek wrote:
> > > Build log:
> > > In file included from drivers/usb/host/ehci-hcd.c:1208:
> > > drivers/usb/host/ehci-xilinx-of.c: In function
> > 'ehci_hcd_xilinx_of_probe':
> > > drivers/usb/host/ehci-xilinx-of.c:168: error: implicit declaration of
> > function 'of_address_to_resource'
> > >
> > > Signed-off-by: John Williams <john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
> > > Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
> >
> > Applied, thanks.
> >
> 
> FYI I haven't tried building it, but I believe that ehci-ppc-of.c will need
> the same patch.

I'll wait for someone to post a patch.

g.