[PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings

[PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings

[Neil Armstrong]

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 .../devicetree/bindings/phy/qcom,usb-hsic-phy.txt  | 95 ++++++++++++++++++++++
 1 file changed, 95 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt

diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
new file mode 100644
index 0000000..79259a4
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
@@ -0,0 +1,95 @@
+Qualcomm's MDM9615 USB HISC transceiver controller
+
+- compatible:
+    Usage: required
+    Value type: <string>
+    Definition: Should contain "qcom,usb-hsic-phy".
+
+- reg:
+    Usage: required
+    Value type: <prop-encoded-array>
+    Definition: USB PHY base address and length of the register map
+
+- clocks:
+    Usage: required
+    Value type: <prop-encoded-array>
+    Definition: See clock-bindings.txt section "consumers". List of
+                5 clock specifiers for interface and core controller
+                clocks.
+
+- clock-names:
+    Usage: required
+    Value type: <string>
+    Definition: Must contain "core", "alt-core", "phy", "cal" and "iface" strings.
+
+- vddcx-supply:
+    Usage: required
+    Value type: <phandle>
+    Definition: phandle to the regulator VDCCX supply node.
+
+- resets:
+    Usage: required
+    Value type: <prop-encoded-array>
+    Definition: See reset.txt section "consumers". PHY reset specifier.
+
+- reset-names:
+    Usage: required
+    Value type: <string>
+    Definition: Must contain "link" string.
+
+- interrupts:
+    Usage: required
+    Value type: <prop-encoded-array>
+    Definition: Interrupt line definition for the PHY
+
+- dr_mode:
+    Usage: required
+    Value type: <prop-encoded-array>
+    Definition: Setup the PHY mode, either "host", "gadget" or "dual"
+
+- qcom,vdd-levels:
+    Usage: required for MDM9615
+    Value type: <prop-encoded-array>
+    Definition: Setup the valid vdd levers for the vddx-supply
+
+- phy_type:
+    Usage: required
+    Value type: <prop-encoded-array>
+    Definition: Shall be "hisc"
+
+- qcom,tlmm:
+    Usage: required for MDM961
+    Value type: <prop-encoded-array>
+    Definition: TLMM syscon phandle to setup the HSIC lines
+
+- qcom,tlmm-cfg:
+    Usage: required for MDM961
+    Value type: <prop-encoded-array>
+    Definition: Shall be two entries of offset, data of the HSIC lines setup
+
+Example:
+	usb_phy: phy@12540000 {
+		compatible = "qcom,usb-hsic-phy";
+		reg = <0x78d9000 0x400>;
+		interrupts      = <GIC_SPI 232 IRQ_TYPE_NONE>;
+		dr_mode         = "host";
+
+		vddcx-supply = <&pm8018_vdd_dig_corner>;
+
+		clocks = <&gcc USB_HSIC_SYSTEM_CLK>,
+		         <&gcc USB_HSIC_XCVR_FS_CLK>,
+			 <&gcc USB_HSIC_HSIC_CLK>,
+			 <&gcc USB_HSIC_HSIO_CAL_CLK>,
+			 <&gcc USB_HSIC_H_CLK>;
+		clock-names = "core", "alt-core", "phy", "cal", "iface";
+
+		resets = <&gcc USB_HSIC_RESET>;
+		reset-names = "link";
+		qcom,vdd-levels = <1 2 4>;
+		phy_type        = "hsic";
+
+		qcom,tlmm       = <&msmgpio>;
+		qcom,tlmm-cfg   = <0x20CC 0x034A4E10
+				   0x20C8 0x034A4E10>;
+	};
+
-- 
1.9.1

Re: [PATCH 2/2] dt-bindings: phy: Add qcom,usb-hsic-phy bindings

[Rob Herring]

On Fri, Jun 17, 2016 at 12:25:19PM +0200, Neil Armstrong wrote:
> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
>  .../devicetree/bindings/phy/qcom,usb-hsic-phy.txt  | 95 ++++++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
> new file mode 100644
> index 0000000..79259a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt
> @@ -0,0 +1,95 @@
> +Qualcomm's MDM9615 USB HISC transceiver controller
> +
> +- compatible:
> +    Usage: required
> +    Value type: <string>
> +    Definition: Should contain "qcom,usb-hsic-phy".

SoC specific compatible string please.

> +
> +- reg:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: USB PHY base address and length of the register map
> +
> +- clocks:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: See clock-bindings.txt section "consumers". List of
> +                5 clock specifiers for interface and core controller
> +                clocks.
> +
> +- clock-names:
> +    Usage: required
> +    Value type: <string>
> +    Definition: Must contain "core", "alt-core", "phy", "cal" and "iface" strings.
> +
> +- vddcx-supply:
> +    Usage: required
> +    Value type: <phandle>
> +    Definition: phandle to the regulator VDCCX supply node.
> +
> +- resets:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: See reset.txt section "consumers". PHY reset specifier.
> +
> +- reset-names:
> +    Usage: required
> +    Value type: <string>
> +    Definition: Must contain "link" string.
> +
> +- interrupts:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: Interrupt line definition for the PHY
> +
> +- dr_mode:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: Setup the PHY mode, either "host", "gadget" or "dual"
> +
> +- qcom,vdd-levels:
> +    Usage: required for MDM9615
> +    Value type: <prop-encoded-array>
> +    Definition: Setup the valid vdd levers for the vddx-supply

s/levers/levels/

There's not a common regulator property for this?

> +
> +- phy_type:
> +    Usage: required
> +    Value type: <prop-encoded-array>
> +    Definition: Shall be "hisc"

typo

> +
> +- qcom,tlmm:
> +    Usage: required for MDM961

s/MDM961/MDM9615/

or drop because this binding is only for MDM9615.

> +    Value type: <prop-encoded-array>
> +    Definition: TLMM syscon phandle to setup the HSIC lines
> +
> +- qcom,tlmm-cfg:
> +    Usage: required for MDM961

s/MDM961/MDM9615/

> +    Value type: <prop-encoded-array>
> +    Definition: Shall be two entries of offset, data of the HSIC lines setup

This property is somewhat questionable with just magic register address 
and value to write...
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html