From: Arnd Bergmann <arnd@arndb.de>
To: Ding Tianhong <dingtianhong@huawei.com>
Cc: Alexander Graf <agraf@suse.de>,
robh+dt@kernel.org, davem@davemloft.net, grant.likely@linaro.org,
sergei.shtylyov@cogentembedded.com,
linux-arm-kernel@lists.infradead.org, eric.dumazet@gmail.com,
xuwei5@hisilicon.com, zhangfei.gao@linaro.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux@arm.linux.org.uk
Subject: Re: [PATCH net-next v13 0/3] add hisilicon hip04 ethernet driver
Date: Thu, 15 Jan 2015 10:42:17 +0100 [thread overview]
Message-ID: <14674609.dERhba4yMV@wuerfel> (raw)
In-Reply-To: <54B77C43.6010200@huawei.com>
On Thursday 15 January 2015 16:37:23 Ding Tianhong wrote:
> On 2015/1/14 18:19, Alexander Graf wrote:
> >
> >>From a 10000 feet perspective it looks like two problems to me
> >
> > 1) Allocation failure doesn't get handled properly somewhere
This is the bug that Eric pointed out as well.
> > 2) We fail to allocate with order=0 - I don't see why
GFP_ATOMIC. When allocating from a the napi poll function in softirq
context, you have to use nonblocking allocations, which occasionally
fail. This should not cause any harm other than dropped packets.
> is it easy to repetition this bug? how big is your memory on your board,
> is it happened in your previous hip04 driver?
It should be independent of memory size, but may be more likely if you
don't have swap space configured.
Arnd
next prev parent reply other threads:[~2015-01-15 9:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 6:34 [PATCH net-next v13 0/3] add hisilicon hip04 ethernet driver Ding Tianhong
2015-01-14 6:34 ` [PATCH net-next v13 1/3] Documentation: add Device tree bindings for Hisilicon hip04 ethernet Ding Tianhong
2015-01-14 6:34 ` [PATCH net-next v13 2/3] net: hisilicon: new hip04 MDIO driver Ding Tianhong
2015-01-14 6:34 ` [PATCH net-next v13 3/3] net: hisilicon: new hip04 ethernet driver Ding Tianhong
2015-01-14 8:06 ` Joe Perches
2015-01-15 2:56 ` Ding Tianhong
2015-01-14 8:53 ` Arnd Bergmann
2015-01-15 2:54 ` Ding Tianhong
2015-01-15 9:05 ` Arnd Bergmann
2015-01-14 16:34 ` Eric Dumazet
[not found] ` <1421253246.11734.17.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-01-15 10:29 ` Ding Tianhong
2015-01-15 12:30 ` Arnd Bergmann
2015-01-15 4:39 ` Joe Perches
[not found] ` <1421296742.25598.3.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2015-01-15 10:28 ` Ding Tianhong
2015-01-15 9:53 ` Arnd Bergmann
2015-01-19 18:11 ` Alexander Graf
[not found] ` <54BD48BF.3050707-l3A5Bk7waGM@public.gmane.org>
2015-01-19 20:34 ` Arnd Bergmann
2015-01-20 2:15 ` Ding Tianhong
[not found] ` <54BDBA29.10703-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-01-20 12:01 ` Arnd Bergmann
2015-01-20 18:12 ` Joe Perches
2015-01-14 10:19 ` [PATCH net-next v13 0/3] add hisilicon " Alexander Graf
2015-01-15 8:37 ` Ding Tianhong
2015-01-15 9:42 ` Arnd Bergmann [this message]
2015-01-15 12:39 ` Alexander Graf
[not found] ` <54B7B4E7.8030108-l3A5Bk7waGM@public.gmane.org>
2015-01-15 12:56 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14674609.dERhba4yMV@wuerfel \
--to=arnd@arndb.de \
--cc=agraf@suse.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dingtianhong@huawei.com \
--cc=eric.dumazet@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox