[PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

[PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

[Li Jun]

Adding 'usb3-resume-missing-cas' property to enable XHCI_MISSING_CAS
quirk flag in case there is CAS missing if device plugged in S3.

Signed-off-by: Li Jun <jun.li-3arQi8VN3Tc@public.gmane.org>
---
 Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
index e2ea59b..c413e188 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
@@ -32,6 +32,8 @@ Optional properties:
   - usb3-lpm-capable: determines if platform is USB3 LPM capable
   - quirk-broken-port-ped: set if the controller has broken port disable mechanism
   - imod-interval-ns: default interrupt moderation interval is 5000ns
+  - usb3-resume-missing-cas: set if the CAS(Cold Attach Status) may lose in case
+    usb3 device plugged in while system sleep.
 
 Example:
 	usb@f0931000 {
-- 
2.6.6

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] usb: host: xhci-plat: enable XHCI_MISSING_CAS if platform requested

[Li Jun]

In case there is CAS missing if device plugged in S3, we can use
'usb3-resume-missing-cas' device property to enable quirk flag
XHCI_MISSING_CAS.

Signed-off-by: Li Jun <jun.li-3arQi8VN3Tc@public.gmane.org>
---
 drivers/usb/host/xhci-plat.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 6f03830..4ec711c 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -269,6 +269,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
 	if (device_property_read_bool(&pdev->dev, "quirk-broken-port-ped"))
 		xhci->quirks |= XHCI_BROKEN_PORT_PED;
 
+	if (device_property_read_bool(sysdev, "usb3-resume-missing-cas"))
+		xhci->quirks |= XHCI_MISSING_CAS;
+
 	/* imod_interval is the interrupt moderation value in nanoseconds. */
 	xhci->imod_interval = 40000;
 	device_property_read_u32(sysdev, "imod-interval-ns",
-- 
2.6.6

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

[Rob Herring]

On Tue, Dec 12, 2017 at 11:57:17AM +0800, Li Jun wrote:
> Adding 'usb3-resume-missing-cas' property to enable XHCI_MISSING_CAS
> quirk flag in case there is CAS missing if device plugged in S3.
> 
> Signed-off-by: Li Jun <jun.li-3arQi8VN3Tc@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index e2ea59b..c413e188 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -32,6 +32,8 @@ Optional properties:
>    - usb3-lpm-capable: determines if platform is USB3 LPM capable
>    - quirk-broken-port-ped: set if the controller has broken port disable mechanism
>    - imod-interval-ns: default interrupt moderation interval is 5000ns
> +  - usb3-resume-missing-cas: set if the CAS(Cold Attach Status) may lose in case
> +    usb3 device plugged in while system sleep.

This should be implied by an SoC specific compatible string for the XHCI 
block.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

[Jun Li]

> -----Original Message-----
> From: Rob Herring [mailto:robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org]
> Sent: Saturday, December 16, 2017 6:26 AM
> To: Jun Li <jun.li-3arQi8VN3Tc@public.gmane.org>
> Cc: mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org;
> mark.rutland-5wv7dgnIgG8@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: Re: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas
> property
> 
> On Tue, Dec 12, 2017 at 11:57:17AM +0800, Li Jun wrote:
> > Adding 'usb3-resume-missing-cas' property to enable XHCI_MISSING_CAS
> > quirk flag in case there is CAS missing if device plugged in S3.
> >
> > Signed-off-by: Li Jun <jun.li-3arQi8VN3Tc@public.gmane.org>
> > ---
> >  Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > index e2ea59b..c413e188 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > @@ -32,6 +32,8 @@ Optional properties:
> >    - usb3-lpm-capable: determines if platform is USB3 LPM capable
> >    - quirk-broken-port-ped: set if the controller has broken port disable
> mechanism
> >    - imod-interval-ns: default interrupt moderation interval is 5000ns
> > +  - usb3-resume-missing-cas: set if the CAS(Cold Attach Status) may lose in
> case
> > +    usb3 device plugged in while system sleep.
> 
> This should be implied by an SoC specific compatible string for the XHCI block.

The quirk is already using on some PCI platforms(xhci-pci.c), so I think it will
be possible used for other SoCs as well in future.

thanks
Jun Li

> 
> Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas property

[Jun Li]

Hi Rob

> -----Original Message-----
> From: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-usb-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Jun Li
> Sent: Monday, December 18, 2017 4:36 PM
> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org;
> mark.rutland-5wv7dgnIgG8@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: RE: [PATCH 1/2] dt-bindings: usb-xhci: add usb3-resume-missing-cas
> property
> 
> > -----Original Message-----
> > From: Rob Herring [mailto:robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org]
> > Sent: Saturday, December 16, 2017 6:26 AM
> > To: Jun Li <jun.li-3arQi8VN3Tc@public.gmane.org>
> > Cc: mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org;
> > mark.rutland-5wv7dgnIgG8@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: Re: [PATCH 1/2] dt-bindings: usb-xhci: add
> > usb3-resume-missing-cas property
> >
> > On Tue, Dec 12, 2017 at 11:57:17AM +0800, Li Jun wrote:
> > > Adding 'usb3-resume-missing-cas' property to enable XHCI_MISSING_CAS
> > > quirk flag in case there is CAS missing if device plugged in S3.
> > >
> > > Signed-off-by: Li Jun <jun.li-3arQi8VN3Tc@public.gmane.org>
> > > ---
> > >  Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > index e2ea59b..c413e188 100644
> > > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > > @@ -32,6 +32,8 @@ Optional properties:
> > >    - usb3-lpm-capable: determines if platform is USB3 LPM capable
> > >    - quirk-broken-port-ped: set if the controller has broken port
> > > disable
> > mechanism
> > >    - imod-interval-ns: default interrupt moderation interval is
> > > 5000ns
> > > +  - usb3-resume-missing-cas: set if the CAS(Cold Attach Status) may
> > > + lose in
> > case
> > > +    usb3 device plugged in while system sleep.
> >
> > This should be implied by an SoC specific compatible string for the XHCI block.
> 
> The quirk is already using on some PCI platforms(xhci-pci.c), so I think it will be
> possible used for other SoCs as well in future.

Do you still think I should add SoC specific compatible string for this?

Jun Li
> 
> thanks
> Jun Li
> 
> >
> > Rob
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of
> a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.ke
> rnel.org%2Fmajordomo-
> info.html&data=02%7C01%7Cjun.li%40nxp.com%7C4ab4c3f3e85e475b06f808d
> 545f2615a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636491829
> 682216310&sdata=8YEh55OxgmvsQAi5mtZS%2B5wdcWTRiXuKsfyoxmCjILQ%3D
> &reserved=0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html