* [PATCH v2 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device
[not found] <1518459117-16733-1-git-send-email-kbingham@kernel.org>
@ 2018-02-12 18:11 ` Kieran Bingham
2018-02-12 18:11 ` [PATCH v2 2/5] dt-bindings: adv7511: " Kieran Bingham
2018-02-12 18:11 ` [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage Kieran Bingham
2 siblings, 0 replies; 6+ messages in thread
From: Kieran Bingham @ 2018-02-12 18:11 UTC (permalink / raw)
To: linux-media, dri-devel, linux-kernel, linux-renesas-soc
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sergei Shtylyov, Kieran Bingham, Kieran Bingham, Rob Herring,
Jean-Michel Hautbois, Mauro Carvalho Chehab
From: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
The ADV7604 has thirteen 256-byte maps that can be accessed via the main
I²C ports. Each map has it own I²C address and acts as a standard slave
device on the I²C bus.
Extend the device tree node bindings to be able to override the default
addresses so that address conflicts with other devices on the same bus
may be resolved at the board description level.
Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
[Kieran: Re-adapted for mainline]
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Based upon the original posting :
https://lkml.org/lkml/2014/10/22/469
v2:
- DT Binding update separated from code change
- Minor reword to commit message to account for DT only change.
- Collected Rob's RB tag.
.../devicetree/bindings/media/i2c/adv7604.txt | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
index 9cbd92eb5d05..b64e313dcc66 100644
--- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
+++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
@@ -13,7 +13,11 @@ Required Properties:
- "adi,adv7611" for the ADV7611
- "adi,adv7612" for the ADV7612
- - reg: I2C slave address
+ - reg: I2C slave addresses
+ The ADV76xx has up to thirteen 256-byte maps that can be accessed via the
+ main I²C ports. Each map has it own I²C address and acts as a standard
+ slave device on the I²C bus. The main address is mandatory, others are
+ optional and revert to defaults if not specified.
- hpd-gpios: References to the GPIOs that control the HDMI hot-plug
detection pins, one per HDMI input. The active flag indicates the GPIO
@@ -35,6 +39,11 @@ Optional Properties:
- reset-gpios: Reference to the GPIO connected to the device's reset pin.
- default-input: Select which input is selected after reset.
+ - reg-names : Names of maps with programmable addresses.
+ It can contain any map needing a non-default address.
+ Possible maps names are :
+ "main", "avlink", "cec", "infoframe", "esdp", "dpp", "afe",
+ "rep", "edid", "hdmi", "test", "cp", "vdp"
Optional Endpoint Properties:
@@ -52,7 +61,12 @@ Example:
hdmi_receiver@4c {
compatible = "adi,adv7611";
- reg = <0x4c>;
+ /*
+ * The edid page will be accessible @ 0x66 on the i2c bus. All
+ * other maps will retain their default addresses.
+ */
+ reg = <0x4c 0x66>;
+ reg-names "main", "edid";
reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>;
hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/5] dt-bindings: adv7511: Add support for i2c_new_secondary_device
[not found] <1518459117-16733-1-git-send-email-kbingham@kernel.org>
2018-02-12 18:11 ` [PATCH v2 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device Kieran Bingham
@ 2018-02-12 18:11 ` Kieran Bingham
2018-02-12 18:11 ` [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage Kieran Bingham
2 siblings, 0 replies; 6+ messages in thread
From: Kieran Bingham @ 2018-02-12 18:11 UTC (permalink / raw)
To: linux-media, dri-devel, linux-kernel, linux-renesas-soc
Cc: Kieran Bingham, Jean-Michel Hautbois, Sergei Shtylyov,
Kieran Bingham, David Airlie, Rob Herring, Mark Rutland,
Hans Verkuil, John Stultz, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
The ADV7511 has four 256-byte maps that can be accessed via the main I²C
ports. Each map has it own I²C address and acts as a standard slave
device on the I²C bus.
Extend the device tree node bindings to be able to override the default
addresses so that address conflicts with other devices on the same bus
may be resolved at the board description level.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
v2:
- Fixed up reg: property description to account for multiple optional
addresses.
- Minor reword to commit message to account for DT only change
- Collected Robs RB tag
.../devicetree/bindings/display/bridge/adi,adv7511.txt | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt
index 0047b1394c70..f1b5466b1ca7 100644
--- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt
+++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt
@@ -14,7 +14,13 @@ Required properties:
"adi,adv7513"
"adi,adv7533"
-- reg: I2C slave address
+- reg: I2C slave addresses
+ The ADV7511 internal registers are split into four pages exposed through
+ different I2C addresses, creating four register maps. Each map has it own
+ I2C address and acts as a standard slave device on the I²C bus. The main
+ address is mandatory, others are optional and revert to defaults if not
+ specified.
+
The ADV7511 supports a large number of input data formats that differ by their
color depth, color format, clock mode, bit justification and random
@@ -70,6 +76,9 @@ Optional properties:
rather than generate its own timings for HDMI output.
- clocks: from common clock binding: reference to the CEC clock.
- clock-names: from common clock binding: must be "cec".
+- reg-names : Names of maps with programmable addresses.
+ It can contain any map needing a non-default address.
+ Possible maps names are : "main", "edid", "cec", "packet"
Required nodes:
@@ -88,7 +97,12 @@ Example
adv7511w: hdmi@39 {
compatible = "adi,adv7511w";
- reg = <39>;
+ /*
+ * The EDID page will be accessible on address 0x66 on the i2c
+ * bus. All other maps continue to use their default addresses.
+ */
+ reg = <0x39 0x66>;
+ reg-names = "main", "edid";
interrupt-parent = <&gpio3>;
interrupts = <29 IRQ_TYPE_EDGE_FALLING>;
clocks = <&cec_clock>;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage
[not found] <1518459117-16733-1-git-send-email-kbingham@kernel.org>
2018-02-12 18:11 ` [PATCH v2 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device Kieran Bingham
2018-02-12 18:11 ` [PATCH v2 2/5] dt-bindings: adv7511: " Kieran Bingham
@ 2018-02-12 18:11 ` Kieran Bingham
[not found] ` <1518459117-16733-4-git-send-email-kbingham-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-14 1:04 ` kbuild test robot
2 siblings, 2 replies; 6+ messages in thread
From: Kieran Bingham @ 2018-02-12 18:11 UTC (permalink / raw)
To: linux-media, dri-devel, linux-kernel, linux-renesas-soc
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sergei Shtylyov, Kieran Bingham, Magnus Damm, Kieran Bingham,
Rob Herring, Russell King, Simon Horman, Jean-Michel Hautbois,
moderated list:ARM PORT
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
The r8a7792 Wheat board has two ADV7513 devices sharing a single i2c
bus, however in low power mode the ADV7513 will reset it's slave maps to
use the hardware defined default addresses.
The ADV7511 driver was adapted to allow the two devices to be registered
correctly - but it did not take into account the fault whereby the
devices reset the addresses.
This results in an address conflict between the device using the default
addresses, and the other device if it is in low-power-mode.
Repair this issue by moving both devices away from the default address
definitions.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm/boot/dts/r8a7792-wheat.dts | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7792-wheat.dts b/arch/arm/boot/dts/r8a7792-wheat.dts
index b9471b67b728..c94f330392ee 100644
--- a/arch/arm/boot/dts/r8a7792-wheat.dts
+++ b/arch/arm/boot/dts/r8a7792-wheat.dts
@@ -240,9 +240,16 @@
status = "okay";
clock-frequency = <400000>;
+ /*
+ * The adv75xx resets its addresses to defaults during low power power
+ * mode. Because we have two ADV7513 devices on the same bus, we must
+ * change both of them away from the defaults so that they do not
+ * conflict.
+ */
hdmi@3d {
compatible = "adi,adv7513";
- reg = <0x3d>;
+ reg = <0x3d 0x2d 0x4d, 0x5d>;
+ reg-names = "main", "cec", "edid", "packet";
adi,input-depth = <8>;
adi,input-colorspace = "rgb";
@@ -272,7 +279,8 @@
hdmi@39 {
compatible = "adi,adv7513";
- reg = <0x39>;
+ reg = <0x39 0x29 0x49, 0x59>;
+ reg-names = "main", "cec", "edid", "packet";
adi,input-depth = <8>;
adi,input-colorspace = "rgb";
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread[parent not found: <1518459117-16733-4-git-send-email-kbingham-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage
[not found] ` <1518459117-16733-4-git-send-email-kbingham-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2018-02-12 18:24 ` Lars-Peter Clausen
2018-02-12 18:30 ` Kieran Bingham
0 siblings, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2018-02-12 18:24 UTC (permalink / raw)
To: Kieran Bingham, linux-media-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sergei Shtylyov, Kieran Bingham, Magnus Damm, Kieran Bingham,
Rob Herring, Russell King, Simon Horman, Jean-Michel Hautbois,
moderated list:ARM PORT
On 02/12/2018 07:11 PM, Kieran Bingham wrote:
[...]
> + /*
> + * The adv75xx resets its addresses to defaults during low power power
> + * mode. Because we have two ADV7513 devices on the same bus, we must
> + * change both of them away from the defaults so that they do not
> + * conflict.
> + */
> hdmi@3d {
> compatible = "adi,adv7513";
> - reg = <0x3d>;
> + reg = <0x3d 0x2d 0x4d, 0x5d>;
To have the correct semantics this should be:
reg = <0x3d>, <0x2d>, <0x4d>, <0x5d>;
It is a set of 4 single cell addresses. The other thing is a single 4 cell
address. It will get compiled to the same bytes, but the DT tools should
complain about it, because it doesn't match #address-cells.
> + reg-names = "main", "cec", "edid", "packet";
>
> adi,input-depth = <8>;
> adi,input-colorspace = "rgb";
> @@ -272,7 +279,8 @@
>
> hdmi@39 {
> compatible = "adi,adv7513";
> - reg = <0x39>;
> + reg = <0x39 0x29 0x49, 0x59>;
Same here.
> + reg-names = "main", "cec", "edid", "packet";
>
> adi,input-depth = <8>;
> adi,input-colorspace = "rgb";
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage
2018-02-12 18:24 ` Lars-Peter Clausen
@ 2018-02-12 18:30 ` Kieran Bingham
0 siblings, 0 replies; 6+ messages in thread
From: Kieran Bingham @ 2018-02-12 18:30 UTC (permalink / raw)
To: Lars-Peter Clausen, linux-media, dri-devel, linux-kernel,
linux-renesas-soc
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sergei Shtylyov, Kieran Bingham, Magnus Damm, Kieran Bingham,
Rob Herring, Russell King, Simon Horman, Jean-Michel Hautbois,
moderated list:ARM PORT
Hi Lars,
Thanks for your review!
On 12/02/18 18:24, Lars-Peter Clausen wrote:
> On 02/12/2018 07:11 PM, Kieran Bingham wrote:
> [...]
>> + /*
>> + * The adv75xx resets its addresses to defaults during low power power
>> + * mode. Because we have two ADV7513 devices on the same bus, we must
>> + * change both of them away from the defaults so that they do not
>> + * conflict.
>> + */
>> hdmi@3d {
>> compatible = "adi,adv7513";
>> - reg = <0x3d>;
>> + reg = <0x3d 0x2d 0x4d, 0x5d>;
>
> To have the correct semantics this should be:
> reg = <0x3d>, <0x2d>, <0x4d>, <0x5d>;>
> It is a set of 4 single cell addresses. The other thing is a single 4 cell
> address. It will get compiled to the same bytes, but the DT tools should
> complain about it, because it doesn't match #address-cells.
Not to mention the spurious comma's!!! (at least I marked the patch RFT :D)
I'll resend a v2.1 RFT here, and update my local changes (with the same fault,
sans comma) to my other DT files!
Thanks for the fast review.
--
Kieran
>
>> + reg-names = "main", "cec", "edid", "packet";
>>
>> adi,input-depth = <8>;
>> adi,input-colorspace = "rgb";
>> @@ -272,7 +279,8 @@
>>
>> hdmi@39 {
>> compatible = "adi,adv7513";
>> - reg = <0x39>;
>> + reg = <0x39 0x29 0x49, 0x59>;
>
> Same here.
>
>> + reg-names = "main", "cec", "edid", "packet";
>>
>> adi,input-depth = <8>;
>> adi,input-colorspace = "rgb";
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage
2018-02-12 18:11 ` [PATCH v2 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage Kieran Bingham
[not found] ` <1518459117-16733-4-git-send-email-kbingham-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2018-02-14 1:04 ` kbuild test robot
1 sibling, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2018-02-14 1:04 UTC (permalink / raw)
To: Kieran Bingham
Cc: kbuild-all, linux-media, dri-devel, linux-kernel,
linux-renesas-soc, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sergei Shtylyov, Kieran Bingham, Magnus Damm, Kieran Bingham,
Rob Herring, Russell King, Simon Horman, Jean-Michel Hautbois,
moderated list:ARM PORT
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
Hi Kieran,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16-rc1 next-20180213]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Kieran-Bingham/dt-bindings-media-adv7604-Add-support-for-i2c_new_secondary_device/20180214-032943
base: git://linuxtv.org/media_tree.git master
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/r8a7792-wheat.dts:251.24-25 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63980 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread