From: Lucas Stach <l.stach@pengutronix.de>
To: Anson Huang <Anson.Huang@nxp.com>,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, fabio.estevam@nxp.com, robh+dt@kernel.org,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Linux-imx@nxp.com
Subject: Re: [PATCH] ARM: dts: imx6: correct anatop regulators range
Date: Fri, 29 Jun 2018 10:15:09 +0200 [thread overview]
Message-ID: <1530260109.22468.60.camel@pengutronix.de> (raw)
In-Reply-To: <1530258861-11666-1-git-send-email-Anson.Huang@nxp.com>
Am Freitag, den 29.06.2018, 15:54 +0800 schrieb Anson Huang:
> Correct some i.MX6 SoCs anatop regulators range
> according to reference manual.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
NACK.
This is wrong. While the regulator supports this range, the SoC
doesn't. The current settings are derived from the allowed operating
ranges of the SoC (at least for the MX6QDL), which is in accordance
with how regulator constraints in DT are meant to be used.
Regards,
Lucas
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 12 ++++++------
> arch/arm/boot/dts/imx6sl.dtsi | 4 ++--
> arch/arm/boot/dts/imx6sx.dtsi | 4 ++--
> 3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 911141e..d9f98dd 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -689,8 +689,8 @@
> > regulator-1p1 {
> > compatible = "fsl,anatop-regulator";
> > regulator-name = "vdd1p1";
> > - regulator-min-microvolt = <1000000>;
> > - regulator-max-microvolt = <1200000>;
> > + regulator-min-microvolt = <800000>;
> > + regulator-max-microvolt = <1375000>;
> > regulator-always-on;
> > anatop-reg-offset = <0x110>;
> > anatop-vol-bit-shift = <8>;
> @@ -704,8 +704,8 @@
> > regulator-3p0 {
> > compatible = "fsl,anatop-regulator";
> > regulator-name = "vdd3p0";
> > - regulator-min-microvolt = <2800000>;
> > - regulator-max-microvolt = <3150000>;
> > + regulator-min-microvolt = <2625000>;
> > + regulator-max-microvolt = <3400000>;
> > regulator-always-on;
> > anatop-reg-offset = <0x120>;
> > anatop-vol-bit-shift = <8>;
> @@ -719,8 +719,8 @@
> > regulator-2p5 {
> > compatible = "fsl,anatop-regulator";
> > regulator-name = "vdd2p5";
> > - regulator-min-microvolt = <2250000>;
> > - regulator-max-microvolt = <2750000>;
> > + regulator-min-microvolt = <2100000>;
> > + regulator-max-microvolt = <2875000>;
> > regulator-always-on;
> > anatop-reg-offset = <0x130>;
> > anatop-vol-bit-shift = <8>;
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 81f48116..3d7931b 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -539,8 +539,8 @@
> > regulator-3p0 {
> > compatible = "fsl,anatop-regulator";
> > regulator-name = "vdd3p0";
> > - regulator-min-microvolt = <2800000>;
> > - regulator-max-microvolt = <3150000>;
> > + regulator-min-microvolt = <2625000>;
> > + regulator-max-microvolt = <3400000>;
> > regulator-always-on;
> > anatop-reg-offset = <0x120>;
> > anatop-vol-bit-shift = <8>;
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 7130ab8..f26f611 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -607,8 +607,8 @@
> > regulator-3p0 {
> > compatible = "fsl,anatop-regulator";
> > regulator-name = "vdd3p0";
> > - regulator-min-microvolt = <2800000>;
> > - regulator-max-microvolt = <3150000>;
> > + regulator-min-microvolt = <2625000>;
> > + regulator-max-microvolt = <3400000>;
> > regulator-always-on;
> > anatop-reg-offset = <0x120>;
> > anatop-vol-bit-shift = <8>;
next prev parent reply other threads:[~2018-06-29 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 7:54 [PATCH] ARM: dts: imx6: correct anatop regulators range Anson Huang
2018-06-29 8:15 ` Lucas Stach [this message]
2018-06-29 8:27 ` Anson Huang
2018-06-29 8:38 ` Lucas Stach
2018-06-29 8:41 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530260109.22468.60.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox