* [PATCH] ARM: dts: imx6: correct anatop regulators range @ 2018-06-29 7:54 Anson Huang 2018-06-29 8:15 ` Lucas Stach 0 siblings, 1 reply; 5+ messages in thread From: Anson Huang @ 2018-06-29 7:54 UTC (permalink / raw) To: shawnguo, s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel Cc: Linux-imx Correct some i.MX6 SoCs anatop regulators range according to reference manual. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++++++------ arch/arm/boot/dts/imx6sl.dtsi | 4 ++-- arch/arm/boot/dts/imx6sx.dtsi | 4 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 911141e..d9f98dd 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -689,8 +689,8 @@ regulator-1p1 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd1p1"; - regulator-min-microvolt = <1000000>; - regulator-max-microvolt = <1200000>; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1375000>; regulator-always-on; anatop-reg-offset = <0x110>; anatop-vol-bit-shift = <8>; @@ -704,8 +704,8 @@ regulator-3p0 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd3p0"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3150000>; + regulator-min-microvolt = <2625000>; + regulator-max-microvolt = <3400000>; regulator-always-on; anatop-reg-offset = <0x120>; anatop-vol-bit-shift = <8>; @@ -719,8 +719,8 @@ regulator-2p5 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd2p5"; - regulator-min-microvolt = <2250000>; - regulator-max-microvolt = <2750000>; + regulator-min-microvolt = <2100000>; + regulator-max-microvolt = <2875000>; regulator-always-on; anatop-reg-offset = <0x130>; anatop-vol-bit-shift = <8>; diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 81f48116..3d7931b 100644 --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -539,8 +539,8 @@ regulator-3p0 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd3p0"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3150000>; + regulator-min-microvolt = <2625000>; + regulator-max-microvolt = <3400000>; regulator-always-on; anatop-reg-offset = <0x120>; anatop-vol-bit-shift = <8>; diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index 7130ab8..f26f611 100644 --- a/arch/arm/boot/dts/imx6sx.dtsi +++ b/arch/arm/boot/dts/imx6sx.dtsi @@ -607,8 +607,8 @@ regulator-3p0 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd3p0"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3150000>; + regulator-min-microvolt = <2625000>; + regulator-max-microvolt = <3400000>; regulator-always-on; anatop-reg-offset = <0x120>; anatop-vol-bit-shift = <8>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6: correct anatop regulators range 2018-06-29 7:54 [PATCH] ARM: dts: imx6: correct anatop regulators range Anson Huang @ 2018-06-29 8:15 ` Lucas Stach 2018-06-29 8:27 ` Anson Huang 0 siblings, 1 reply; 5+ messages in thread From: Lucas Stach @ 2018-06-29 8:15 UTC (permalink / raw) To: Anson Huang, shawnguo, s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel Cc: Linux-imx Am Freitag, den 29.06.2018, 15:54 +0800 schrieb Anson Huang: > Correct some i.MX6 SoCs anatop regulators range > according to reference manual. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> NACK. This is wrong. While the regulator supports this range, the SoC doesn't. The current settings are derived from the allowed operating ranges of the SoC (at least for the MX6QDL), which is in accordance with how regulator constraints in DT are meant to be used. Regards, Lucas > --- > arch/arm/boot/dts/imx6qdl.dtsi | 12 ++++++------ > arch/arm/boot/dts/imx6sl.dtsi | 4 ++-- > arch/arm/boot/dts/imx6sx.dtsi | 4 ++-- > 3 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 911141e..d9f98dd 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -689,8 +689,8 @@ > > regulator-1p1 { > > compatible = "fsl,anatop-regulator"; > > regulator-name = "vdd1p1"; > > - regulator-min-microvolt = <1000000>; > > - regulator-max-microvolt = <1200000>; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <1375000>; > > regulator-always-on; > > anatop-reg-offset = <0x110>; > > anatop-vol-bit-shift = <8>; > @@ -704,8 +704,8 @@ > > regulator-3p0 { > > compatible = "fsl,anatop-regulator"; > > regulator-name = "vdd3p0"; > > - regulator-min-microvolt = <2800000>; > > - regulator-max-microvolt = <3150000>; > > + regulator-min-microvolt = <2625000>; > > + regulator-max-microvolt = <3400000>; > > regulator-always-on; > > anatop-reg-offset = <0x120>; > > anatop-vol-bit-shift = <8>; > @@ -719,8 +719,8 @@ > > regulator-2p5 { > > compatible = "fsl,anatop-regulator"; > > regulator-name = "vdd2p5"; > > - regulator-min-microvolt = <2250000>; > > - regulator-max-microvolt = <2750000>; > > + regulator-min-microvolt = <2100000>; > > + regulator-max-microvolt = <2875000>; > > regulator-always-on; > > anatop-reg-offset = <0x130>; > > anatop-vol-bit-shift = <8>; > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi > index 81f48116..3d7931b 100644 > --- a/arch/arm/boot/dts/imx6sl.dtsi > +++ b/arch/arm/boot/dts/imx6sl.dtsi > @@ -539,8 +539,8 @@ > > regulator-3p0 { > > compatible = "fsl,anatop-regulator"; > > regulator-name = "vdd3p0"; > > - regulator-min-microvolt = <2800000>; > > - regulator-max-microvolt = <3150000>; > > + regulator-min-microvolt = <2625000>; > > + regulator-max-microvolt = <3400000>; > > regulator-always-on; > > anatop-reg-offset = <0x120>; > > anatop-vol-bit-shift = <8>; > diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi > index 7130ab8..f26f611 100644 > --- a/arch/arm/boot/dts/imx6sx.dtsi > +++ b/arch/arm/boot/dts/imx6sx.dtsi > @@ -607,8 +607,8 @@ > > regulator-3p0 { > > compatible = "fsl,anatop-regulator"; > > regulator-name = "vdd3p0"; > > - regulator-min-microvolt = <2800000>; > > - regulator-max-microvolt = <3150000>; > > + regulator-min-microvolt = <2625000>; > > + regulator-max-microvolt = <3400000>; > > regulator-always-on; > > anatop-reg-offset = <0x120>; > > anatop-vol-bit-shift = <8>; ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] ARM: dts: imx6: correct anatop regulators range 2018-06-29 8:15 ` Lucas Stach @ 2018-06-29 8:27 ` Anson Huang 2018-06-29 8:38 ` Lucas Stach 0 siblings, 1 reply; 5+ messages in thread From: Anson Huang @ 2018-06-29 8:27 UTC (permalink / raw) To: Lucas Stach, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, Fabio Estevam, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dl-linux-imx Hi, Lucas Anson Huang Best Regards! > -----Original Message----- > From: Lucas Stach [mailto:l.stach@pengutronix.de] > Sent: Friday, June 29, 2018 4:15 PM > To: Anson Huang <anson.huang@nxp.com>; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; Fabio Estevam > <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com; > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH] ARM: dts: imx6: correct anatop regulators range > > Am Freitag, den 29.06.2018, 15:54 +0800 schrieb Anson Huang: > > Correct some i.MX6 SoCs anatop regulators range according to reference > > manual. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > NACK. > > This is wrong. While the regulator supports this range, the SoC doesn't. The > current settings are derived from the allowed operating ranges of the SoC (at > least for the MX6QDL), which is in accordance with how regulator constraints > in DT are meant to be used. Understand that normally these regulators' voltage are NOT adjusted, we just use the default value, let's just call the operating range of the SoC "SoC range", my intention is to make all i.MX6's anatop regulator settings aligned since they are in same series, I saw some i.MX6 SoCs use same SoC range as anatop ldo range, but some are NOT, like imx6qdl/imx6sx/imx6sl use different SoC range than anatop ldo range, but imx6ul/ull/sll use same regulator range as anatop ldo, and regulator 1p1/2p5/3p0 also have different settings, some are use SoC range and some are just same as anatop ldo range....this looks really confused. So, do you think we can adjust the imx6ul/ull/sll's regulator range to be SoC range rather than anatop ldo range? And how to define the SoC range? Like the 1p1 ldo range, how do we know which range is fine? As I saw it is 1v ~ 1.2v on imx6qdl, but 0.8v ~ 1.375v on imx6sl? Thanks. Anson. > > Regards, > Lucas > > > --- > > arch/arm/boot/dts/imx6qdl.dtsi | 12 ++++++------ > > arch/arm/boot/dts/imx6sl.dtsi | 4 ++-- > > arch/arm/boot/dts/imx6sx.dtsi | 4 ++-- > > 3 files changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi > > b/arch/arm/boot/dts/imx6qdl.dtsi index 911141e..d9f98dd 100644 > > --- a/arch/arm/boot/dts/imx6qdl.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > > @@ -689,8 +689,8 @@ > > > regulator-1p1 { > > > compatible = "fsl,anatop-regulator"; > > > regulator-name = "vdd1p1"; > > > - regulator-min-microvolt = <1000000>; > > > - regulator-max-microvolt = <1200000>; > > > + regulator-min-microvolt = <800000>; > > > + regulator-max-microvolt = <1375000>; > > > regulator-always-on; > > > anatop-reg-offset = <0x110>; > > > anatop-vol-bit-shift = <8>; > > @@ -704,8 +704,8 @@ > > > regulator-3p0 { > > > compatible = "fsl,anatop-regulator"; > > > regulator-name = "vdd3p0"; > > > - regulator-min-microvolt = <2800000>; > > > - regulator-max-microvolt = <3150000>; > > > + regulator-min-microvolt = <2625000>; > > > + regulator-max-microvolt = <3400000>; > > > regulator-always-on; > > > anatop-reg-offset = <0x120>; > > > anatop-vol-bit-shift = <8>; > > @@ -719,8 +719,8 @@ > > > regulator-2p5 { > > > compatible = "fsl,anatop-regulator"; > > > regulator-name = "vdd2p5"; > > > - regulator-min-microvolt = <2250000>; > > > - regulator-max-microvolt = <2750000>; > > > + regulator-min-microvolt = <2100000>; > > > + regulator-max-microvolt = <2875000>; > > > regulator-always-on; > > > anatop-reg-offset = <0x130>; > > > anatop-vol-bit-shift = <8>; > > diff --git a/arch/arm/boot/dts/imx6sl.dtsi > > b/arch/arm/boot/dts/imx6sl.dtsi index 81f48116..3d7931b 100644 > > --- a/arch/arm/boot/dts/imx6sl.dtsi > > +++ b/arch/arm/boot/dts/imx6sl.dtsi > > @@ -539,8 +539,8 @@ > > > regulator-3p0 { > > > compatible = "fsl,anatop-regulator"; > > > regulator-name = "vdd3p0"; > > > - regulator-min-microvolt = <2800000>; > > > - regulator-max-microvolt = <3150000>; > > > + regulator-min-microvolt = <2625000>; > > > + regulator-max-microvolt = <3400000>; > > > regulator-always-on; > > > anatop-reg-offset = <0x120>; > > > anatop-vol-bit-shift = <8>; > > diff --git a/arch/arm/boot/dts/imx6sx.dtsi > > b/arch/arm/boot/dts/imx6sx.dtsi index 7130ab8..f26f611 100644 > > --- a/arch/arm/boot/dts/imx6sx.dtsi > > +++ b/arch/arm/boot/dts/imx6sx.dtsi > > @@ -607,8 +607,8 @@ > > > regulator-3p0 { > > > compatible = "fsl,anatop-regulator"; > > > regulator-name = "vdd3p0"; > > > - regulator-min-microvolt = <2800000>; > > > - regulator-max-microvolt = <3150000>; > > > + regulator-min-microvolt = <2625000>; > > > + regulator-max-microvolt = <3400000>; > > > regulator-always-on; > > > anatop-reg-offset = <0x120>; > > > anatop-vol-bit-shift = <8>; ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: imx6: correct anatop regulators range 2018-06-29 8:27 ` Anson Huang @ 2018-06-29 8:38 ` Lucas Stach 2018-06-29 8:41 ` Anson Huang 0 siblings, 1 reply; 5+ messages in thread From: Lucas Stach @ 2018-06-29 8:38 UTC (permalink / raw) To: Anson Huang, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, Fabio Estevam, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dl-linux-imx Am Freitag, den 29.06.2018, 08:27 +0000 schrieb Anson Huang: > Hi, Lucas > > Anson Huang > Best Regards! > > > > -----Original Message----- > > > > From: Lucas Stach [mailto:l.stach@pengutronix.de] > > Sent: Friday, June 29, 2018 4:15 PM > > > > > > To: Anson Huang <anson.huang@nxp.com>; shawnguo@kernel.org; > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; Fabio Estevam > > > > > > > > <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com; > > > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org > > > > Cc: dl-linux-imx <linux-imx@nxp.com> > > Subject: Re: [PATCH] ARM: dts: imx6: correct anatop regulators range > > > > Am Freitag, den 29.06.2018, 15:54 +0800 schrieb Anson Huang: > > > Correct some i.MX6 SoCs anatop regulators range according to reference > > > manual. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > NACK. > > > > This is wrong. While the regulator supports this range, the SoC doesn't. The > > current settings are derived from the allowed operating ranges of the SoC (at > > least for the MX6QDL), which is in accordance with how regulator constraints > > in DT are meant to be used. > > > Understand that normally these regulators' voltage are NOT adjusted, we just use > the default value, let's just call the operating range of the SoC "SoC range", > my intention is to make all i.MX6's anatop regulator settings aligned since they are in same series, > I saw some i.MX6 SoCs use same SoC range as anatop ldo range, but some are > NOT, like imx6qdl/imx6sx/imx6sl use different SoC range than anatop ldo range, > but imx6ul/ull/sll use same regulator range as anatop ldo, and regulator 1p1/2p5/3p0 > also have different settings, some are use SoC range and some are just same as anatop > ldo range....this looks really confused. > > So, do you think we can adjust the imx6ul/ull/sll's regulator range to be SoC range rather than > anatop ldo range? And how to define the SoC range? Like the 1p1 ldo range, how do > we know which range is fine? As I saw it is 1v ~ 1.2v on imx6qdl, but 0.8v ~ 1.375v on imx6sl? If you want to align those voltages to something then it's definitely the SoC range you want to use. This is how the constraints are specified in the DT binding, as being the allowed voltage range that won't damage any of the attached consumers. Please align the constraints to the operating ranges, as specified in the datasheet. For example an excerpt from the i.MX6SL datasheet: "4.3.2.1 Regulators for Analog Modules LDO_1P1 [...] Typical Programming Operating Range is 1.0 V to 1.2 V with the nominal default setting as 1.1 V" So the range for 1p1 LDO on i.MX6SL should be 1.0V to 1.2V, which is the same as i.MX6QDL. Regards, Lucas ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] ARM: dts: imx6: correct anatop regulators range 2018-06-29 8:38 ` Lucas Stach @ 2018-06-29 8:41 ` Anson Huang 0 siblings, 0 replies; 5+ messages in thread From: Anson Huang @ 2018-06-29 8:41 UTC (permalink / raw) To: Lucas Stach, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, Fabio Estevam, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dl-linux-imx Hi, Lucas Anson Huang Best Regards! > -----Original Message----- > From: Lucas Stach [mailto:l.stach@pengutronix.de] > Sent: Friday, June 29, 2018 4:39 PM > To: Anson Huang <anson.huang@nxp.com>; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; Fabio Estevam > <fabio.estevam@nxp.com>; robh+dt@kernel.org; mark.rutland@arm.com; > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH] ARM: dts: imx6: correct anatop regulators range > > Am Freitag, den 29.06.2018, 08:27 +0000 schrieb Anson Huang: > > Hi, Lucas > > > > Anson Huang > > Best Regards! > > > > > > > -----Original Message----- > > > > > From: Lucas Stach [mailto:l.stach@pengutronix.de] > > > Sent: Friday, June 29, 2018 4:15 PM > > > > > > > To: Anson Huang <anson.huang@nxp.com>; shawnguo@kernel.org; > > > > > s.hauer@pengutronix.de; kernel@pengutronix.de; Fabio Estevam > > > > > > > > > <fabio.estevam@nxp.com>; robh+dt@kernel.org; > > > > > > > > > mark.rutland@arm.com; > > > > > linux-arm-kernel@lists.infradead.org; > > > > > devicetree@vger.kernel.org; > > > linux-kernel@vger.kernel.org > > > > > Cc: dl-linux-imx <linux-imx@nxp.com> > > > Subject: Re: [PATCH] ARM: dts: imx6: correct anatop regulators range > > > > > > Am Freitag, den 29.06.2018, 15:54 +0800 schrieb Anson Huang: > > > > Correct some i.MX6 SoCs anatop regulators range according to > > > > reference manual. > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > > > NACK. > > > > > > This is wrong. While the regulator supports this range, the SoC > > > doesn't. The current settings are derived from the allowed operating > > > ranges of the SoC (at least for the MX6QDL), which is in accordance > > > with how regulator constraints in DT are meant to be used. > > > > > > Understand that normally these regulators' voltage are NOT adjusted, > > we just use the default value, let's just call the operating range of > > the SoC "SoC range", my intention is to make all i.MX6's anatop > > regulator settings aligned since they are in same series, I saw some > > i.MX6 SoCs use same SoC range as anatop ldo range, but some are NOT, > > like imx6qdl/imx6sx/imx6sl use different SoC range than anatop ldo > > range, but imx6ul/ull/sll use same regulator range as anatop ldo, and > > regulator 1p1/2p5/3p0 also have different settings, some are use SoC range > and some are just same as anatop ldo range....this looks really confused. > > > > So, do you think we can adjust the imx6ul/ull/sll's regulator range to > > be SoC range rather than anatop ldo range? And how to define the SoC > > range? Like the 1p1 ldo range, how do we know which range is fine? As I saw > it is 1v ~ 1.2v on imx6qdl, but 0.8v ~ 1.375v on imx6sl? > > If you want to align those voltages to something then it's definitely the SoC > range you want to use. This is how the constraints are specified in the DT > binding, as being the allowed voltage range that won't damage any of the > attached consumers. > > Please align the constraints to the operating ranges, as specified in the > datasheet. For example an excerpt from the i.MX6SL datasheet: > > "4.3.2.1 Regulators for Analog Modules > LDO_1P1 > [...] Typical Programming Operating Range is 1.0 V to 1.2 V with the > nominal default setting as 1.1 V" > > So the range for 1p1 LDO on i.MX6SL should be 1.0V to 1.2V, which is the same > as i.MX6QDL. OK, thanks, I will check all the datasheet and rework a patch. Anson. > > Regards, > Lucas ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-29 8:41 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-06-29 7:54 [PATCH] ARM: dts: imx6: correct anatop regulators range Anson Huang 2018-06-29 8:15 ` Lucas Stach 2018-06-29 8:27 ` Anson Huang 2018-06-29 8:38 ` Lucas Stach 2018-06-29 8:41 ` Anson Huang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox