[PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up

[PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up

[Geert Uytterhoeven]

	Hi Simon, Magnus,

This patch series adds the missing pull-up bias configuration for the
switches on the r8a73a4/ape6evm development board, and configures the
custom switch as a wake-up source.

After this, the keys actually work, and the system can be resumed from
s2ram by pressing the custom switch.

This depends functionally on "[PATCH 1/4] pinctrl: sh-pfc: Do not
overwrite bias configuration" in the series "[PATCH 0/4] pinctrl:
sh-pfc: Fix pin bias and cleanups" which I've just sent. But as this is
DTS, it can be applied independently.

Thanks for your comments!

Geert Uytterhoeven (2):
  ARM: shmobile: ape6evm dts: Enable pull-up for GPIO switches
  ARM: shmobile: ape6evm dts: Configure the custom switch as wake-up
    source

 arch/arm/boot/dts/r8a73a4-ape6evm.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] ARM: shmobile: ape6evm dts: Enable pull-up for GPIO switches

[Geert Uytterhoeven]

The switches on r8a73a4/ape6evm do not have pull-up registers.  The
schematics say: "Need to use APE6 internal PullUp", hence enable pull-up
using pinctrl.

Without this, the switches don't really work, as the GPIO inputs are
more likely to pick up ghost signals through capacitive coupling than
actual keypresses.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a73a4-ape6evm.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
index b355fafc32f188dc..5baada97bc715838 100644
--- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
+++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
@@ -103,6 +103,9 @@
 	keyboard {
 		compatible = "gpio-keys";
 
+		pinctrl-names = "default";
+		pinctrl-0 = <&keyboard_pins>;
+
 		zero-key {
 			gpios = <&pfc 324 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_0>;
@@ -203,6 +206,12 @@
 		renesas,groups = "sdhi1_data4", "sdhi1_ctrl";
 		renesas,function = "sdhi1";
 	};
+
+	keyboard_pins: keyboard {
+		renesas,pins = "PORT324", "PORT325", "PORT326", "PORT327",
+			       "PORT328", "PORT329";
+		bias-pull-up;
+	};
 };
 
 &mmcif0 {
-- 
1.9.1

[PATCH 2/2] ARM: shmobile: ape6evm dts: Configure the custom switch as wake-up source

[Geert Uytterhoeven]

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a73a4-ape6evm.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
index 5baada97bc715838..81a38ceee098087e 100644
--- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
+++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
@@ -110,6 +110,7 @@
 			gpios = <&pfc 324 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_0>;
 			label = "S16";
+			gpio-key,wakeup;
 		};
 
 		menu-key {
-- 
1.9.1

Re: [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up

[Simon Horman]

On Fri, Feb 27, 2015 at 06:48:37PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> This patch series adds the missing pull-up bias configuration for the
> switches on the r8a73a4/ape6evm development board, and configures the
> custom switch as a wake-up source.
> 
> After this, the keys actually work, and the system can be resumed from
> s2ram by pressing the custom switch.
> 
> This depends functionally on "[PATCH 1/4] pinctrl: sh-pfc: Do not
> overwrite bias configuration" in the series "[PATCH 0/4] pinctrl:
> sh-pfc: Fix pin bias and cleanups" which I've just sent. But as this is
> DTS, it can be applied independently.
> 
> Thanks for your comments!

Hi Geert,

this seems fine to me. But I am reluctant to queue it up before the PFC
changes are accepted, lest there be some change in direction.

Please repost once the PFC changes have been accepted.

Re: [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up

[Laurent Pinchart]

Hi Simon,

On Thursday 05 March 2015 09:34:33 Simon Horman wrote:
> On Fri, Feb 27, 2015 at 06:48:37PM +0100, Geert Uytterhoeven wrote:
> > 	Hi Simon, Magnus,
> > 
> > This patch series adds the missing pull-up bias configuration for the
> > switches on the r8a73a4/ape6evm development board, and configures the
> > custom switch as a wake-up source.
> > 
> > After this, the keys actually work, and the system can be resumed from
> > s2ram by pressing the custom switch.
> > 
> > This depends functionally on "[PATCH 1/4] pinctrl: sh-pfc: Do not
> > overwrite bias configuration" in the series "[PATCH 0/4] pinctrl:
> > sh-pfc: Fix pin bias and cleanups" which I've just sent. But as this is
> > DTS, it can be applied independently.
> > 
> > Thanks for your comments!
> 
> Hi Geert,
> 
> this seems fine to me. But I am reluctant to queue it up before the PFC
> changes are accepted, lest there be some change in direction.
> 
> Please repost once the PFC changes have been accepted.

I've acked the dependency, but we should probably wait for Linus to apply it.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up

[Simon Horman]

On Thu, Mar 05, 2015 at 12:42:07PM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Thursday 05 March 2015 09:34:33 Simon Horman wrote:
> > On Fri, Feb 27, 2015 at 06:48:37PM +0100, Geert Uytterhoeven wrote:
> > > 	Hi Simon, Magnus,
> > > 
> > > This patch series adds the missing pull-up bias configuration for the
> > > switches on the r8a73a4/ape6evm development board, and configures the
> > > custom switch as a wake-up source.
> > > 
> > > After this, the keys actually work, and the system can be resumed from
> > > s2ram by pressing the custom switch.
> > > 
> > > This depends functionally on "[PATCH 1/4] pinctrl: sh-pfc: Do not
> > > overwrite bias configuration" in the series "[PATCH 0/4] pinctrl:
> > > sh-pfc: Fix pin bias and cleanups" which I've just sent. But as this is
> > > DTS, it can be applied independently.
> > > 
> > > Thanks for your comments!
> > 
> > Hi Geert,
> > 
> > this seems fine to me. But I am reluctant to queue it up before the PFC
> > changes are accepted, lest there be some change in direction.
> > 
> > Please repost once the PFC changes have been accepted.
> 
> I've acked the dependency, but we should probably wait for Linus to apply it.

Thanks Laurent, of course that plan is fine by me.

Re: [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up

[Laurent Pinchart]

Hi Simon,

On Friday 06 March 2015 20:30:29 Simon Horman wrote:
> On Thu, Mar 05, 2015 at 12:42:07PM +0200, Laurent Pinchart wrote:
> > On Thursday 05 March 2015 09:34:33 Simon Horman wrote:
> >> On Fri, Feb 27, 2015 at 06:48:37PM +0100, Geert Uytterhoeven wrote:
> >>> 	Hi Simon, Magnus,
> >>> 
> >>> This patch series adds the missing pull-up bias configuration for the
> >>> switches on the r8a73a4/ape6evm development board, and configures the
> >>> custom switch as a wake-up source.
> >>> 
> >>> After this, the keys actually work, and the system can be resumed from
> >>> s2ram by pressing the custom switch.
> >>> 
> >>> This depends functionally on "[PATCH 1/4] pinctrl: sh-pfc: Do not
> >>> overwrite bias configuration" in the series "[PATCH 0/4] pinctrl:
> >>> sh-pfc: Fix pin bias and cleanups" which I've just sent. But as this
> >>> is DTS, it can be applied independently.
> >>> 
> >>> Thanks for your comments!
> >> 
> >> Hi Geert,
> >> 
> >> this seems fine to me. But I am reluctant to queue it up before the PFC
> >> changes are accepted, lest there be some change in direction.
> >> 
> >> Please repost once the PFC changes have been accepted.
> > 
> > I've acked the dependency, but we should probably wait for Linus to apply
> > it.
>
> Thanks Laurent, of course that plan is fine by me.

Linus has just applied it, so I think you can go forward with this series.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up

[Simon Horman]

On Fri, Mar 06, 2015 at 01:33:05PM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Friday 06 March 2015 20:30:29 Simon Horman wrote:
> > On Thu, Mar 05, 2015 at 12:42:07PM +0200, Laurent Pinchart wrote:
> > > On Thursday 05 March 2015 09:34:33 Simon Horman wrote:
> > >> On Fri, Feb 27, 2015 at 06:48:37PM +0100, Geert Uytterhoeven wrote:
> > >>> 	Hi Simon, Magnus,
> > >>> 
> > >>> This patch series adds the missing pull-up bias configuration for the
> > >>> switches on the r8a73a4/ape6evm development board, and configures the
> > >>> custom switch as a wake-up source.
> > >>> 
> > >>> After this, the keys actually work, and the system can be resumed from
> > >>> s2ram by pressing the custom switch.
> > >>> 
> > >>> This depends functionally on "[PATCH 1/4] pinctrl: sh-pfc: Do not
> > >>> overwrite bias configuration" in the series "[PATCH 0/4] pinctrl:
> > >>> sh-pfc: Fix pin bias and cleanups" which I've just sent. But as this
> > >>> is DTS, it can be applied independently.
> > >>> 
> > >>> Thanks for your comments!
> > >> 
> > >> Hi Geert,
> > >> 
> > >> this seems fine to me. But I am reluctant to queue it up before the PFC
> > >> changes are accepted, lest there be some change in direction.
> > >> 
> > >> Please repost once the PFC changes have been accepted.
> > > 
> > > I've acked the dependency, but we should probably wait for Linus to apply
> > > it.
> >
> > Thanks Laurent, of course that plan is fine by me.
> 
> Linus has just applied it, so I think you can go forward with this series.

Thanks, done.