[PATCH] ignore disabled memory-region nodes

[PATCH] ignore disabled memory-region nodes

[Puneet Saxena]

While parsing "memory-region" node lists if a node
is "disabled", parsing halts. Therefore the nodes whoes
"status" is "okay" or "ok" are not parsed.

The change ignore disabled nodes in the memory-region
nodes list and continues to initialize the rest of
enabled nodes.

Krishna Reddy (1):
  of: resered-memory: ignore disabled memory-region nodes

 drivers/of/of_reserved_mem.c | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.7.4

[PATCH] of: resered-memory: ignore disabled memory-region nodes

[Puneet Saxena]

From: Krishna Reddy <vdumpa@nvidia.com>

Ignore disabled nodes in the memory-region nodes list and continue
to initialize the rest of enabled nodes.

Signed-off-by: Krishna Reddy <vdumpa@nvidia.com>
---
 drivers/of/of_reserved_mem.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
index 1977ee0adcb1..58d95d774e3b 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -314,6 +314,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
 	struct device_node *target;
 	struct reserved_mem *rmem;
 	int ret;
+	const char *status;
 
 	if (!np || !dev)
 		return -EINVAL;
@@ -322,6 +323,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
 	if (!target)
 		return -ENODEV;
 
+	status = of_get_property(target, "status", NULL);
+	if (status && strcmp(status, "okay") != 0 && strcmp(status, "ok") != 0)
+		return 0;
+
 	rmem = __find_rmem(target);
 	of_node_put(target);
 
-- 
2.7.4

Re: [PATCH] of: resered-memory: ignore disabled memory-region nodes

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

On Wed, May 22, 2019 at 11:05:53AM +0530, Puneet Saxena wrote:
> From: Krishna Reddy <vdumpa@nvidia.com>
> 
> Ignore disabled nodes in the memory-region nodes list and continue
> to initialize the rest of enabled nodes.
> 
> Signed-off-by: Krishna Reddy <vdumpa@nvidia.com>
> ---
>  drivers/of/of_reserved_mem.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 1977ee0adcb1..58d95d774e3b 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -314,6 +314,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>  	struct device_node *target;
>  	struct reserved_mem *rmem;
>  	int ret;
> +	const char *status;
>  
>  	if (!np || !dev)
>  		return -EINVAL;
> @@ -322,6 +323,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>  	if (!target)
>  		return -ENODEV;
>  
> +	status = of_get_property(target, "status", NULL);
> +	if (status && strcmp(status, "okay") != 0 && strcmp(status, "ok") != 0)
> +		return 0;
> +

Does of_device_is_available() not work? Other than that, looks fine to
me.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] of: resered-memory: ignore disabled memory-region nodes

[puneet saxena]

Yes, of_device_is_available() will work here. Will incorporate in next PS.

Thanks.

On 22/05/19 12:08 PM, Thierry Reding wrote:
> On Wed, May 22, 2019 at 11:05:53AM +0530, Puneet Saxena wrote:
>> From: Krishna Reddy <vdumpa@nvidia.com>
>>
>> Ignore disabled nodes in the memory-region nodes list and continue
>> to initialize the rest of enabled nodes.
>>
>> Signed-off-by: Krishna Reddy <vdumpa@nvidia.com>
>> ---
>>   drivers/of/of_reserved_mem.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
>> index 1977ee0adcb1..58d95d774e3b 100644
>> --- a/drivers/of/of_reserved_mem.c
>> +++ b/drivers/of/of_reserved_mem.c
>> @@ -314,6 +314,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>>   	struct device_node *target;
>>   	struct reserved_mem *rmem;
>>   	int ret;
>> +	const char *status;
>>   
>>   	if (!np || !dev)
>>   		return -EINVAL;
>> @@ -322,6 +323,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>>   	if (!target)
>>   		return -ENODEV;
>>   
>> +	status = of_get_property(target, "status", NULL);
>> +	if (status && strcmp(status, "okay") != 0 && strcmp(status, "ok") != 0)
>> +		return 0;
>> +
> Does of_device_is_available() not work? Other than that, looks fine to
> me.
>
> Thierry

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

[PATCH] ignore disabled memory-region nodes

[Puneet Saxena]

While parsing "memory-region" node lists if a node is
"disabled", parsing halts. Therefore the nodes whose
"status" is "okay" or "ok" are not parsed.

The change ignores disabled nodes in the memory-region
nodes list and returns 0 to continue parsing next nodes.

---
v2:
* Fixed typo in commit message.
* Used of_device_is_available to check device is disabled/enabled.

Krishna Reddy (1):
  of: reserved-memory: ignore disabled memory-region nodes

 drivers/of/of_reserved_mem.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.7.4