Re: [PATCH 4/5] arm64: dts: altera: move Agilex72 DT and use altr prefix

["Chiam, Evon" <evon.chiam@altera.com>]

Hi Krzysztof,

Please find my replies inline below.

On 18/8/2026 4:27 pm, Krzysztof Kozlowski wrote:
> On 06/08/2026 11:25, evon.chiam@altera.com wrote:
>> From: "Chiam, Evon" <evon.chiam@altera.com>
>>
>> Move the Agilex72 SoC and SoCDK device trees from dts/intel to
>> dts/altera. Update the board and SoC compatible strings to use
>> the "altr" vendor.
>>
>> Signed-off-by: Chiam, Evon <evon.chiam@altera.com>
>> ---
>>   arch/arm64/boot/dts/altera/Makefile                            | 3 ++-
>>   arch/arm64/boot/dts/{intel => altera}/socfpga_agilex72.dtsi    | 2 +-
>>   .../boot/dts/{intel => altera}/socfpga_agilex72_socdk.dts      | 2 +-
>>   arch/arm64/boot/dts/intel/Makefile                             | 1 -
>>   4 files changed, 4 insertions(+), 4 deletions(-)
>>   rename arch/arm64/boot/dts/{intel => altera}/socfpga_agilex72.dtsi (98%)
>>   rename arch/arm64/boot/dts/{intel => altera}/socfpga_agilex72_socdk.dts (84%)
> 
> Everything there is altera, except Keembay, so moving only one file is
> quite a confusion.
> 
> Feel free to move ALL altera files (or none as this is just a churn),
> but you should keep dtbs_install unaffected (as not broken).
> 
> 
Will drop the Agilex72-only DTS move from this series in v2. Moving only 
one file is confusing, as you noted. I will send a separate series to 
move all SoCFPGA DTS files from dts/intel to dts/altera, while keeping 
dtbs_install unaffected.

>>
>> diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
>> index 540bb5ae746b..a1a9ccba5334 100644
>> --- a/arch/arm64/boot/dts/altera/Makefile
>> +++ b/arch/arm64/boot/dts/altera/Makefile
>> @@ -1,5 +1,6 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>> -dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
>> +dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex72_socdk.dtb \
>> +				socfpga_stratix10_socdk.dtb \
>>   				socfpga_stratix10_socdk_emmc.dtb \
>>   				socfpga_stratix10_socdk_nand.dtb \
>>   				socfpga_stratix10_swvp.dtb
>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex72.dtsi b/arch/arm64/boot/dts/altera/socfpga_agilex72.dtsi
>> similarity index 98%
>> rename from arch/arm64/boot/dts/intel/socfpga_agilex72.dtsi
>> rename to arch/arm64/boot/dts/altera/socfpga_agilex72.dtsi
>> index c29c2afcaab7..354c775f577b 100644
>> --- a/arch/arm64/boot/dts/intel/socfpga_agilex72.dtsi
>> +++ b/arch/arm64/boot/dts/altera/socfpga_agilex72.dtsi
>> @@ -7,7 +7,7 @@
>>   #include <dt-bindings/interrupt-controller/irq.h>
>>   
>>   / {
>> -	compatible = "intel,socfpga-agilex72";
>> +	compatible = "altr,socfpga-agilex72";
> 
> And this is not fine. You are stuck with what you added, especially that
> you added it recently and this was conscious choice of using "intel"
> instead of "altr".
> 
Agreed — I'll keep the existing compatible strings and drop the change 
in v2.

> Best regards,
> Krzysztof


Thanks and best regards,
Evon