* [PATCH] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board
@ 2019-11-15 18:08 Matwey V. Kornilov
2019-11-15 18:14 ` Heiko Stübner
0 siblings, 1 reply; 3+ messages in thread
From: Matwey V. Kornilov @ 2019-11-15 18:08 UTC (permalink / raw)
Cc: matwey.kornilov, Matwey V. Kornilov, Rob Herring, Mark Rutland,
Heiko Stuebner, Ezequiel Garcia, Akash Gajjar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
Radxa Rock Pi 4 is equipped with M.2 PCIe slot,
so enable PCIe for the board.
The changes has been tested with Intel SSD 660p series device.
01:00.0 Class 0108: Device 8086:f1a8 (rev 03)
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
index 1ae1ebd4efdd..9c2927faba41 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
@@ -463,6 +463,20 @@
pmu1830-supply = <&vcc_3v0>;
};
+&pcie_phy {
+ status = "okay";
+};
+
+&pcie0 {
+ status = "okay";
+
+ ep-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_HIGH>;
+ num-lanes = <4>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pcie_clkreqnb_cpm>;
+ max-link-speed = <2>;
+};
+
&pinctrl {
bt {
bt_enable_h: bt-enable-h {
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board
2019-11-15 18:08 [PATCH] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board Matwey V. Kornilov
@ 2019-11-15 18:14 ` Heiko Stübner
2019-11-15 18:16 ` Matwey V. Kornilov
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stübner @ 2019-11-15 18:14 UTC (permalink / raw)
To: Matwey V. Kornilov
Cc: matwey.kornilov, Rob Herring, Mark Rutland, Ezequiel Garcia,
Akash Gajjar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
Hi Matwey,
Am Freitag, 15. November 2019, 19:08:21 CET schrieb Matwey V. Kornilov:
> Radxa Rock Pi 4 is equipped with M.2 PCIe slot,
> so enable PCIe for the board.
>
> The changes has been tested with Intel SSD 660p series device.
>
> 01:00.0 Class 0108: Device 8086:f1a8 (rev 03)
>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> index 1ae1ebd4efdd..9c2927faba41 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> @@ -463,6 +463,20 @@
> pmu1830-supply = <&vcc_3v0>;
> };
>
> +&pcie_phy {
> + status = "okay";
> +};
> +
> +&pcie0 {
> + status = "okay";
> +
> + ep-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_HIGH>;
> + num-lanes = <4>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie_clkreqnb_cpm>;
> + max-link-speed = <2>;
the RockPi schematics should be available, so could you also check
the supply regulators and add them please?
Thanks
Heiko
> +};
> +
> &pinctrl {
> bt {
> bt_enable_h: bt-enable-h {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board
2019-11-15 18:14 ` Heiko Stübner
@ 2019-11-15 18:16 ` Matwey V. Kornilov
0 siblings, 0 replies; 3+ messages in thread
From: Matwey V. Kornilov @ 2019-11-15 18:16 UTC (permalink / raw)
To: Heiko Stübner
Cc: Rob Herring, Mark Rutland, Ezequiel Garcia, Akash Gajjar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
пт, 15 нояб. 2019 г. в 21:14, Heiko Stübner <heiko@sntech.de>:
>
> Hi Matwey,
>
> Am Freitag, 15. November 2019, 19:08:21 CET schrieb Matwey V. Kornilov:
> > Radxa Rock Pi 4 is equipped with M.2 PCIe slot,
> > so enable PCIe for the board.
> >
> > The changes has been tested with Intel SSD 660p series device.
> >
> > 01:00.0 Class 0108: Device 8086:f1a8 (rev 03)
> >
> > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> > index 1ae1ebd4efdd..9c2927faba41 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
> > @@ -463,6 +463,20 @@
> > pmu1830-supply = <&vcc_3v0>;
> > };
> >
> > +&pcie_phy {
> > + status = "okay";
> > +};
> > +
> > +&pcie0 {
> > + status = "okay";
> > +
> > + ep-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_HIGH>;
> > + num-lanes = <4>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pcie_clkreqnb_cpm>;
> > + max-link-speed = <2>;
>
> the RockPi schematics should be available, so could you also check
> the supply regulators and add them please?
>
> Thanks
> Heiko
Hi,
What do you mean? pcie 3.3v regulator is already in dts. I've checked
that its gpio is correctly configured.
>
>
> > +};
> > +
> > &pinctrl {
> > bt {
> > bt_enable_h: bt-enable-h {
> >
>
>
>
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119234, Moscow, Universitetsky pr-k 13, +7 (495) 9392382
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-15 18:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-15 18:08 [PATCH] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board Matwey V. Kornilov
2019-11-15 18:14 ` Heiko Stübner
2019-11-15 18:16 ` Matwey V. Kornilov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox