* [PATCH] docs: dt-bindings: add missing address/size-cells to example
@ 2024-03-25 9:11 Krzysztof Kozlowski
2024-03-25 9:50 ` Tudor Ambarus
2024-03-25 16:07 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-25 9:11 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski, Tudor Ambarus
Complete the example of recommended order of properties by adding
missing address/size-cells. They are not necessary to illustrate the
style, but lack of them us bit really correct DTS code which might
confuse readers.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
---
Documentation/devicetree/bindings/dts-coding-style.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
index a9bdd2b59dca..8a68331075a0 100644
--- a/Documentation/devicetree/bindings/dts-coding-style.rst
+++ b/Documentation/devicetree/bindings/dts-coding-style.rst
@@ -144,6 +144,8 @@ Example::
#dma-cells = <1>;
clocks = <&clock_controller 0>, <&clock_controller 1>;
clock-names = "bus", "host";
+ #address-cells = <1>;
+ #size-cells = <1>;
vendor,custom-property = <2>;
status = "disabled";
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: dt-bindings: add missing address/size-cells to example
2024-03-25 9:11 [PATCH] docs: dt-bindings: add missing address/size-cells to example Krzysztof Kozlowski
@ 2024-03-25 9:50 ` Tudor Ambarus
2024-03-25 16:07 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Tudor Ambarus @ 2024-03-25 9:50 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, devicetree, linux-kernel
Hi, Krzysztof,
On 3/25/24 09:11, Krzysztof Kozlowski wrote:
> Complete the example of recommended order of properties by adding
> missing address/size-cells. They are not necessary to illustrate the
> style, but lack of them us bit really correct DTS code which might
some typo here
> confuse readers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> Documentation/devicetree/bindings/dts-coding-style.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
> index a9bdd2b59dca..8a68331075a0 100644
> --- a/Documentation/devicetree/bindings/dts-coding-style.rst
> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
> @@ -144,6 +144,8 @@ Example::
> #dma-cells = <1>;
> clocks = <&clock_controller 0>, <&clock_controller 1>;
> clock-names = "bus", "host";
> + #address-cells = <1>;
> + #size-cells = <1>;
I propose having #address-cells and #size-cells after ranges, because
they are related:
https://devicetree-specification.readthedocs.io/en/stable/devicetree-basics.html#ranges
Looking good:
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> vendor,custom-property = <2>;
> status = "disabled";
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: dt-bindings: add missing address/size-cells to example
2024-03-25 9:11 [PATCH] docs: dt-bindings: add missing address/size-cells to example Krzysztof Kozlowski
2024-03-25 9:50 ` Tudor Ambarus
@ 2024-03-25 16:07 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-03-25 16:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, Krzysztof Kozlowski, Tudor Ambarus, Conor Dooley,
devicetree
On Mon, 25 Mar 2024 10:11:39 +0100, Krzysztof Kozlowski wrote:
> Complete the example of recommended order of properties by adding
> missing address/size-cells. They are not necessary to illustrate the
> style, but lack of them us bit really correct DTS code which might
> confuse readers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> Documentation/devicetree/bindings/dts-coding-style.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-25 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-25 9:11 [PATCH] docs: dt-bindings: add missing address/size-cells to example Krzysztof Kozlowski
2024-03-25 9:50 ` Tudor Ambarus
2024-03-25 16:07 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox