* [PATCH net-next v6 01/10] dt-bindings: net: Add support for AM65x SR1.0 in ICSSG
2024-04-03 10:48 [PATCH net-next v6 00/10] Support ICSSG-based Ethernet on AM65x SR1.0 devices Diogo Ivo
@ 2024-04-03 10:48 ` Diogo Ivo
2024-04-09 8:50 ` [PATCH net-next v6 00/10] Support ICSSG-based Ethernet on AM65x SR1.0 devices patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Diogo Ivo @ 2024-04-03 10:48 UTC (permalink / raw)
To: danishanwar, rogerq, davem, edumazet, kuba, pabeni, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-arm-kernel, netdev,
devicetree
Cc: Diogo Ivo, jan.kiszka, Conor Dooley
Silicon Revision 1.0 of the AM65x came with a slightly different ICSSG
support: Only 2 PRUs per slice are available and instead 2 additional
DMA channels are used for management purposes. We have no restrictions
on specified PRUs, but the DMA channels need to be adjusted.
Co-developed-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
---
Changes in v5:
- Added Reviewed-by tag from Danish
Changes in v4:
- Added Reviewed-by tags from Roger and Conor
Changes in v3:
- Fixed dt_binding_check error by moving allOf
Changes in v2:
- Removed explicit reference to SR2.0
- Moved sr1 to the SoC name
- Expand dma-names list and adjust min/maxItems depending on SR1.0/2.0
.../bindings/net/ti,icssg-prueth.yaml | 35 +++++++++++++++----
1 file changed, 29 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
index 229c8f32019f..e253fa786092 100644
--- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
+++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
@@ -13,14 +13,12 @@ description:
Ethernet based on the Programmable Real-Time Unit and Industrial
Communication Subsystem.
-allOf:
- - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
-
properties:
compatible:
enum:
- - ti,am642-icssg-prueth # for AM64x SoC family
- - ti,am654-icssg-prueth # for AM65x SoC family
+ - ti,am642-icssg-prueth # for AM64x SoC family
+ - ti,am654-icssg-prueth # for AM65x SoC family
+ - ti,am654-sr1-icssg-prueth # for AM65x SoC family, SR1.0
sram:
$ref: /schemas/types.yaml#/definitions/phandle
@@ -28,9 +26,11 @@ properties:
phandle to MSMC SRAM node
dmas:
- maxItems: 10
+ minItems: 10
+ maxItems: 12
dma-names:
+ minItems: 10
items:
- const: tx0-0
- const: tx0-1
@@ -42,6 +42,8 @@ properties:
- const: tx1-3
- const: rx0
- const: rx1
+ - const: rxmgm0
+ - const: rxmgm1
ti,mii-g-rt:
$ref: /schemas/types.yaml#/definitions/phandle
@@ -132,6 +134,27 @@ required:
- interrupts
- interrupt-names
+allOf:
+ - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ti,am654-sr1-icssg-prueth
+ then:
+ properties:
+ dmas:
+ minItems: 12
+ dma-names:
+ minItems: 12
+ else:
+ properties:
+ dmas:
+ maxItems: 10
+ dma-names:
+ maxItems: 10
+
unevaluatedProperties: false
examples:
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next v6 00/10] Support ICSSG-based Ethernet on AM65x SR1.0 devices
2024-04-03 10:48 [PATCH net-next v6 00/10] Support ICSSG-based Ethernet on AM65x SR1.0 devices Diogo Ivo
2024-04-03 10:48 ` [PATCH net-next v6 01/10] dt-bindings: net: Add support for AM65x SR1.0 in ICSSG Diogo Ivo
@ 2024-04-09 8:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-09 8:50 UTC (permalink / raw)
To: Diogo Ivo
Cc: danishanwar, rogerq, davem, edumazet, kuba, pabeni, andrew,
dan.carpenter, jacob.e.keller, robh, robh+dt,
krzysztof.kozlowski+dt, conor+dt, vigneshr, wsa+renesas,
hkallweit1, arnd, vladimir.oltean, linux-arm-kernel, netdev,
devicetree, jan.kiszka
Hello:
This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 3 Apr 2024 11:48:10 +0100 you wrote:
> Hello,
>
> This series extends the current ICSSG-based Ethernet driver to support
> AM65x Silicon Revision 1.0 devices.
>
> Notable differences between the Silicon Revisions are that there is
> no TX core in SR1.0 with this being handled by the firmware, requiring
> extra DMA channels to manage communication with the firmware (with the
> firmware being different as well) and in the packet classifier.
>
> [...]
Here is the summary with links:
- [net-next,v6,01/10] dt-bindings: net: Add support for AM65x SR1.0 in ICSSG
https://git.kernel.org/netdev/net-next/c/dc073430db8d
- [net-next,v6,02/10] eth: Move IPv4/IPv6 multicast address bases to their own symbols
https://git.kernel.org/netdev/net-next/c/e1900d7ba9c9
- [net-next,v6,03/10] net: ti: icssg-prueth: Move common functions into a separate file
https://git.kernel.org/netdev/net-next/c/e2dc7bfd677f
- [net-next,v6,04/10] net: ti: icssg-prueth: Add SR1.0-specific configuration bits
https://git.kernel.org/netdev/net-next/c/6d6a5751cd8e
- [net-next,v6,05/10] net: ti: icssg-prueth: Add SR1.0-specific description bits
https://git.kernel.org/netdev/net-next/c/8623dea207a7
- [net-next,v6,06/10] net: ti: icssg-prueth: Adjust IPG configuration for SR1.0
https://git.kernel.org/netdev/net-next/c/95c2e689331e
- [net-next,v6,07/10] net: ti: icssg-prueth: Adjust the number of TX channels for SR1.0
https://git.kernel.org/netdev/net-next/c/604e603d73ec
- [net-next,v6,08/10] net: ti: icssg-prueth: Add functions to configure SR1.0 packet classifier
https://git.kernel.org/netdev/net-next/c/0a74a9de79c1
- [net-next,v6,09/10] net: ti: icssg-prueth: Modify common functions for SR1.0
https://git.kernel.org/netdev/net-next/c/ce95cb4c8d26
- [net-next,v6,10/10] net: ti: icssg-prueth: Add ICSSG Ethernet driver for AM65x SR1.0 platforms
https://git.kernel.org/netdev/net-next/c/e654b85a693e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread