From: "Rob Herring (Arm)" <robh@kernel.org>
To: Xukai Wang <kingxukai@zohomail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Troy Mitchell <TroyMitchell988@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH 1/3] dt-bindings: clock: Add bindings for Canaan K230 clock controller
Date: Sun, 29 Dec 2024 08:30:34 -0600 [thread overview]
Message-ID: <173548263487.3742243.93806553348966195.robh@kernel.org> (raw)
In-Reply-To: <20241229-b4-k230-clk-v1-1-221a917e80ed@zohomail.com>
On Sun, 29 Dec 2024 21:21:08 +0800, Xukai Wang wrote:
> This patch adds the Device Tree binding for the clock controller
> on Canaan k230. The binding defines the new clocks available and
> the required properties to configure them correctly.
>
> Signed-off-by: Xukai Wang <kingxukai@zohomail.com>
> ---
> .../devicetree/bindings/clock/canaan,k230-clk.yaml | 41 ++++++++++++++++++
> include/dt-bindings/clock/k230-clk.h | 49 ++++++++++++++++++++++
> 2 files changed, 90 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/canaan,k230-clk.example.dtb: clock-controller@91102000: clocks: 1 was expected
from schema $id: http://devicetree.org/schemas/clock/canaan,k230-clk.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241229-b4-k230-clk-v1-1-221a917e80ed@zohomail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-12-29 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 13:21 [PATCH 0/3] riscv: canaan: Add support for K230-Canmv clock Xukai Wang
2024-12-29 13:21 ` [PATCH 1/3] dt-bindings: clock: Add bindings for Canaan K230 clock controller Xukai Wang
2024-12-29 14:30 ` Rob Herring (Arm) [this message]
2024-12-29 15:16 ` Troy Mitchell
2024-12-30 7:54 ` Krzysztof Kozlowski
2025-01-04 9:23 ` Xukai Wang
2025-01-04 10:40 ` Krzysztof Kozlowski
2025-01-04 12:09 ` Xukai Wang
2025-01-04 12:33 ` Krzysztof Kozlowski
2024-12-29 13:21 ` [PATCH 2/3] clk: canaan: Add clock driver for Canaan K230 Xukai Wang
2024-12-29 13:21 ` [PATCH 3/3] riscv: dts: canaan: Add clock initial support for K230 Xukai Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173548263487.3742243.93806553348966195.robh@kernel.org \
--to=robh@kernel.org \
--cc=TroyMitchell988@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kingxukai@zohomail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox