From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xukai Wang <kingxukai@zohomail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Troy Mitchell <TroyMitchell988@gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: clock: Add bindings for Canaan K230 clock controller
Date: Sat, 4 Jan 2025 13:33:54 +0100 [thread overview]
Message-ID: <5f112a20-f1ce-45d1-a554-5f86846bcc25@kernel.org> (raw)
In-Reply-To: <68de77d0-b289-4137-85f3-050a1a10eb63@zohomail.com>
On 04/01/2025 13:09, Xukai Wang wrote:
>> Why?
>>
>>> items:
>>> - description: Base address and size of the PLL control registers.
>>> - description: Base address and size of the sysclk control registers.
>> Drop redundant "Base address and size of the". This cannot be anything
>> else in this context.
>
> Thank you for point these out, I’ve removed the redundant descriptions,
> and here's the updated version:
>
> reg:
> items:
> - description: PLL control registers.
> - description: Sysclk control registers.
>
> Does this content look appropriate?
Yes, thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-04 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 13:21 [PATCH 0/3] riscv: canaan: Add support for K230-Canmv clock Xukai Wang
2024-12-29 13:21 ` [PATCH 1/3] dt-bindings: clock: Add bindings for Canaan K230 clock controller Xukai Wang
2024-12-29 14:30 ` Rob Herring (Arm)
2024-12-29 15:16 ` Troy Mitchell
2024-12-30 7:54 ` Krzysztof Kozlowski
2025-01-04 9:23 ` Xukai Wang
2025-01-04 10:40 ` Krzysztof Kozlowski
2025-01-04 12:09 ` Xukai Wang
2025-01-04 12:33 ` Krzysztof Kozlowski [this message]
2024-12-29 13:21 ` [PATCH 2/3] clk: canaan: Add clock driver for Canaan K230 Xukai Wang
2024-12-29 13:21 ` [PATCH 3/3] riscv: dts: canaan: Add clock initial support for K230 Xukai Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f112a20-f1ce-45d1-a554-5f86846bcc25@kernel.org \
--to=krzk@kernel.org \
--cc=TroyMitchell988@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kingxukai@zohomail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox