From: "Rob Herring (Arm)" <robh@kernel.org>
To: Florian Eckert <fe@dev.tdt.de>
Cc: "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Eckert.Florian@googlemail.com, ms@dev.tdt.de,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Johan Hovold" <johan+linaro@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Ajay Agarwal" <ajayagarwal@google.com>,
"Sajid Dalvi" <sdalvi@google.com>,
linux-pci@vger.kernel.org,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>
Subject: Re: [PATCH v4 7/7] dt-bindings: PCI: intel,lgm-pcie: Add atu resource
Date: Wed, 15 Apr 2026 04:24:08 -0500 [thread overview]
Message-ID: <177624504894.3320247.14684447771089927124.robh@kernel.org> (raw)
In-Reply-To: <20260415-pcie-intel-gw-v4-7-ad45d2418c8e@dev.tdt.de>
On Wed, 15 Apr 2026 10:01:53 +0200, Florian Eckert wrote:
> The 'atu' information is already set in the dwc core, if it is specified
> in the devicetree. The driver uses its own default, if not set in the
> devicetree. This information is hardware specific and should therefore be
> maintained in the devicetree rather than in the source.
>
> To be backward compatible, this field is not mandatory. If 'atu'
> resource is not specified in the devicetree, the driver’s default value
> is used.
>
> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
> ---
> Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Lexical error: Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dts:28.30-36 Unexpected 'config'
Error: Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dts:28.30-36 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:140: Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1601: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260415-pcie-intel-gw-v4-7-ad45d2418c8e@dev.tdt.de
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-04-15 9:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 8:01 [PATCH v4 0/7] PCI: intel-gw: Fixes to make the driver working again Florian Eckert
2026-04-15 8:01 ` [PATCH v4 1/7] MAINTAINERS: Remove bouncing intel-gw maintainer Florian Eckert
2026-04-15 8:01 ` [PATCH v4 2/7] PCI: intel-gw: Remove unused define Florian Eckert
2026-04-15 8:01 ` [PATCH v4 3/7] PCI: intel-gw: Move interrupt enable to own function Florian Eckert
2026-04-15 8:01 ` [PATCH v4 4/7] PCI: intel-gw: Enable clock before phy init Florian Eckert
2026-04-15 8:01 ` [PATCH v4 5/7] PCI: intel-gw: Add start_link callback function Florian Eckert
2026-04-15 8:01 ` [PATCH v4 6/7] PCI: intel-gw: Move driver atu base assignment to probe function Florian Eckert
2026-04-15 8:01 ` [PATCH v4 7/7] dt-bindings: PCI: intel,lgm-pcie: Add atu resource Florian Eckert
2026-04-15 9:24 ` Rob Herring (Arm) [this message]
2026-04-15 12:09 ` Rob Herring
2026-04-15 12:26 ` Florian Eckert
2026-04-15 12:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177624504894.3320247.14684447771089927124.robh@kernel.org \
--to=robh@kernel.org \
--cc=Eckert.Florian@googlemail.com \
--cc=ajayagarwal@google.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fe@dev.tdt.de \
--cc=johan+linaro@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=ms@dev.tdt.de \
--cc=sdalvi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox