Re: [PATCH v3 1/2] dt-bindings: clock: ast2600: Add reset definition for video

Re: [PATCH v3 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[Andrew Jeffery]

Hi Michael, Stephen,

On Mon, 2026-03-02 at 09:15 +0800, Haiyue Wang wrote:
> Add ASPEED_RESET_VIDEO reset definition to the ast2600-clock binding
> header. It is required for proper reset control of the video on the
> AST2600 SoC for aspeed-video driver.
> 
> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
> ---
> v3:
>   - Drop 'Fixes:' tag in header file patch.
> v2: https://lore.kernel.org/all/20260227151602.829-1-haiyuewa@163.com/
>   - Fix checkpatch.pl warning, and send dt-bindings as single patch as
>     the submitting-patches guide.
> v1: https://lore.kernel.org/all/20260227123837.70079-1-haiyuewa@163.com/
> ---
>  include/dt-bindings/clock/ast2600-clock.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> index f60fff261130..7b9b80c38a8b 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -124,6 +124,7 @@
>  #define ASPEED_RESET_PCIE_RC_OEN	18
>  #define ASPEED_RESET_MAC2		12
>  #define ASPEED_RESET_MAC1		11
> +#define ASPEED_RESET_VIDEO		6
>  #define ASPEED_RESET_PCI_DP		5
>  #define ASPEED_RESET_HACE		4
>  #define ASPEED_RESET_AHB		1


If you would like to take this change I can apply 2/2 later when it
makes sense to do so:

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>

Otherwise, I'm happy to take both through the aspeed/arm/dt branch in
the bmc tree with your ack on this one.

Andrew

Re: [PATCH v3 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[Stephen Boyd]

Quoting Haiyue Wang (2026-03-01 17:15:00)
> Add ASPEED_RESET_VIDEO reset definition to the ast2600-clock binding
> header. It is required for proper reset control of the video on the
> AST2600 SoC for aspeed-video driver.
> 
> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>