From: Stephen Boyd <sboyd@kernel.org>
To: Brian Masney <bmasney@redhat.com>,
Xuyang Dong <dongxuyang@eswincomputing.com>
Cc: mturquette@baylibre.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
p.zabel@pengutronix.de, huangyifeng@eswincomputing.com,
benoit.monin@bootlin.com, ningyu@eswincomputing.com,
linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com
Subject: Re: Re: Re: [PATCH v3 2/3] clk: eswin: Add eic7700 HSP clock driver
Date: Tue, 28 Apr 2026 18:51:22 -0700 [thread overview]
Message-ID: <177742748214.5403.15526965667317467444@localhost.localdomain> (raw)
In-Reply-To: <7a76d8cb.5bab.19dd3645d4e.Coremail.dongxuyang@eswincomputing.com>
Quoting Xuyang Dong (2026-04-28 02:21:03)
>
> The common gate API, the HSP private API, and the reset driver all access
> the same register space.
> Therefore, they need to be protected by the same data->lock.
>
If everything is accessing registers through regmap why aren't we using
the builtin lock with struct regmap_config::use_raw_spinlock? I don't
understand why we're rolling our own here.
next prev parent reply other threads:[~2026-04-29 3:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 9:09 [PATCH v3 0/3] Add driver support for ESWIN EIC7700 HSP clock and reset generator Xuyang Dong
2026-04-23 9:10 ` [PATCH v3 1/3] dt-bindings: clock: Add ESWIN eic7700 " dongxuyang
2026-04-23 9:11 ` [PATCH v3 2/3] clk: eswin: Add eic7700 HSP clock driver dongxuyang
2026-04-23 15:37 ` Brian Masney
2026-04-24 10:44 ` Xuyang Dong
2026-04-24 11:15 ` Brian Masney
2026-04-28 0:21 ` Stephen Boyd
2026-04-28 9:21 ` Xuyang Dong
2026-04-28 13:39 ` Brian Masney
2026-04-29 1:51 ` Stephen Boyd [this message]
2026-04-29 9:38 ` Xuyang Dong
2026-04-29 13:54 ` Brian Masney
2026-04-30 5:58 ` Xuyang Dong
2026-04-30 22:51 ` Brian Masney
2026-04-23 15:51 ` Benoît Monin
2026-04-23 9:12 ` [PATCH v3 3/3] reset: eswin: Add eic7700 HSP reset driver dongxuyang
2026-04-23 16:09 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177742748214.5403.15526965667317467444@localhost.localdomain \
--to=sboyd@kernel.org \
--cc=benoit.monin@bootlin.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox