* [PATCH] arm64: dts: qcom: fix temp-alarm probe failure for PMH0104 on Glymur
@ 2026-04-06 13:35 Kamal Wadhwa
2026-04-06 19:31 ` Dmitry Baryshkov
2026-05-07 20:34 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Kamal Wadhwa @ 2026-04-06 13:35 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jishnu Prakash, Jyothi Kumar Seerapu, Maulik Shah,
Pankaj Patil, Raviteja Laggyshetty
Cc: Sibi Sankar, Dmitry Baryshkov, linux-arm-msm, devicetree,
linux-kernel, Manaf Meethalavalappu Pallikunhi, Kamal Wadhwa
The temp-alarm driver probe is failing for the pmh0104 PMICs on glymur.
[ 3.999713] spmi-temp-alarm c426000.spmi:pmic@8:temp-alarm@a00: error -ENODEV: failed to register sensor
[ 4.015066] spmi-temp-alarm c426000.spmi:pmic@9:temp-alarm@a00: error -ENODEV: failed to register sensor
[ 4.033908] spmi-temp-alarm c437000.spmi:pmic@b:temp-alarm@a00: error -ENODEV: failed to register sensor
This happens because thermal zone associated with the temp alarm was
defined under the thermal zones parent node which had a typo (used `_` in
place of `-`). Correct the typo to fix probe failure.
Fixes: 41b6e8db400c ("arm64: dts: qcom: Introduce Glymur base dtsi")
Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi b/arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi
index 7a1e5f355c175913a38d536a1ca13d870049b741..6b4747025b9f85d5fe58ee6ecfbe8d07b38d29fd 100644
--- a/arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi
@@ -7,7 +7,7 @@
#include <dt-bindings/spmi/spmi.h>
/{
- thermal_zones {
+ thermal-zones {
pmh0104_i0_thermal: pmh0104-i0-thermal {
polling-delay-passive = <100>;
thermal-sensors = <&pmh0104_i_e0_temp_alarm>;
---
base-commit: bd0f139e5fc11182777b81cefc3893ea508544ec
change-id: 20260401-glymur-pmh0104-temp-alarm-fix-72e6c1080d6e
Best regards,
--
Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: fix temp-alarm probe failure for PMH0104 on Glymur
2026-04-06 13:35 [PATCH] arm64: dts: qcom: fix temp-alarm probe failure for PMH0104 on Glymur Kamal Wadhwa
@ 2026-04-06 19:31 ` Dmitry Baryshkov
2026-05-07 20:34 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-04-06 19:31 UTC (permalink / raw)
To: Kamal Wadhwa
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jishnu Prakash, Jyothi Kumar Seerapu, Maulik Shah,
Pankaj Patil, Raviteja Laggyshetty, Sibi Sankar, linux-arm-msm,
devicetree, linux-kernel, Manaf Meethalavalappu Pallikunhi
On Mon, Apr 06, 2026 at 07:05:55PM +0530, Kamal Wadhwa wrote:
> The temp-alarm driver probe is failing for the pmh0104 PMICs on glymur.
>
> [ 3.999713] spmi-temp-alarm c426000.spmi:pmic@8:temp-alarm@a00: error -ENODEV: failed to register sensor
> [ 4.015066] spmi-temp-alarm c426000.spmi:pmic@9:temp-alarm@a00: error -ENODEV: failed to register sensor
> [ 4.033908] spmi-temp-alarm c437000.spmi:pmic@b:temp-alarm@a00: error -ENODEV: failed to register sensor
>
> This happens because thermal zone associated with the temp alarm was
> defined under the thermal zones parent node which had a typo (used `_` in
> place of `-`). Correct the typo to fix probe failure.
>
> Fixes: 41b6e8db400c ("arm64: dts: qcom: Introduce Glymur base dtsi")
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: fix temp-alarm probe failure for PMH0104 on Glymur
2026-04-06 13:35 [PATCH] arm64: dts: qcom: fix temp-alarm probe failure for PMH0104 on Glymur Kamal Wadhwa
2026-04-06 19:31 ` Dmitry Baryshkov
@ 2026-05-07 20:34 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-05-07 20:34 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jishnu Prakash, Jyothi Kumar Seerapu, Maulik Shah, Pankaj Patil,
Raviteja Laggyshetty, Kamal Wadhwa
Cc: Sibi Sankar, Dmitry Baryshkov, linux-arm-msm, devicetree,
linux-kernel, Manaf Meethalavalappu Pallikunhi
On Mon, 06 Apr 2026 19:05:55 +0530, Kamal Wadhwa wrote:
> The temp-alarm driver probe is failing for the pmh0104 PMICs on glymur.
>
> [ 3.999713] spmi-temp-alarm c426000.spmi:pmic@8:temp-alarm@a00: error -ENODEV: failed to register sensor
> [ 4.015066] spmi-temp-alarm c426000.spmi:pmic@9:temp-alarm@a00: error -ENODEV: failed to register sensor
> [ 4.033908] spmi-temp-alarm c437000.spmi:pmic@b:temp-alarm@a00: error -ENODEV: failed to register sensor
>
> This happens because thermal zone associated with the temp alarm was
> defined under the thermal zones parent node which had a typo (used `_` in
> place of `-`). Correct the typo to fix probe failure.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: fix temp-alarm probe failure for PMH0104 on Glymur
commit: e8fae9152e100b4bb30d38b25bc9c81623e8e91e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-07 20:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-06 13:35 [PATCH] arm64: dts: qcom: fix temp-alarm probe failure for PMH0104 on Glymur Kamal Wadhwa
2026-04-06 19:31 ` Dmitry Baryshkov
2026-05-07 20:34 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox