From: "Rob Herring (Arm)" <robh@kernel.org>
To: Alexandre Hamamdjian <azkali.limited@gmail.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
Philippe Simons <simons.philippe@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: add SGMicro SGM3804
Date: Sun, 10 May 2026 12:45:27 -0500 [thread overview]
Message-ID: <177843512496.3129220.15229933494716911310.robh@kernel.org> (raw)
In-Reply-To: <20260510-sgm3804-v1-1-e5e8799e0aa0@gmail.com>
On Sun, 10 May 2026 23:45:26 +0700, Alexandre Hamamdjian wrote:
> The SGMicro SGM3804 is an I2C-controlled positive and negative output
> charge-pump regulator. It is commonly used to provide the AVDD and AVEE
> supplies for display panels, and exposes two reset GPIOs to sequence the
> positive and negative output rails independently.
>
> Document the binding for the new compatible "sgmicro,sgm3804" so it can
> be referenced by board device trees and the matching driver, and add a
> MAINTAINERS entry covering both the binding and the upcoming driver.
>
> Co-developed-by: Philippe Simons <simons.philippe@gmail.com>
> Signed-off-by: Philippe Simons <simons.philippe@gmail.com>
> Signed-off-by: Alexandre Hamamdjian <azkali.limited@gmail.com>
> ---
> .../bindings/regulator/sgmicro,sgm3804.yaml | 60 ++++++++++++++++++++++
> MAINTAINERS | 7 +++
> 2 files changed, 67 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/sgmicro,sgm3804.example.dtb: regulator@3e (sgmicro,sgm3804): reset-gpios: [[4294967295, 10, 0], [4294967295, 11, 0]] is too long
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer-common.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260510-sgm3804-v1-1-e5e8799e0aa0@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-05-10 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 16:45 [PATCH 0/2] regulator: add support for SGMicro SGM3804 Alexandre Hamamdjian via B4 Relay
2026-05-10 16:45 ` [PATCH 1/2] dt-bindings: regulator: add " Alexandre Hamamdjian via B4 Relay
2026-05-10 17:45 ` Rob Herring (Arm) [this message]
2026-05-11 1:22 ` Mark Brown
2026-05-10 16:45 ` [PATCH 2/2] regulator: sgm3804: add SGMicro SGM3804 charge-pump regulator driver Alexandre Hamamdjian via B4 Relay
2026-05-11 0:51 ` [PATCH 0/2] regulator: add support for SGMicro SGM3804 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177843512496.3129220.15229933494716911310.robh@kernel.org \
--to=robh@kernel.org \
--cc=azkali.limited@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simons.philippe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox