Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Mikhail Lukianchikov <avermoal@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, kuba@kernel.org,
	 Rengarajan.S@microchip.com, edumazet@google.com,
	andrew+netdev@lunn.ch,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,  netdev@vger.kernel.org,
	conor+dt@kernel.org, krzk+dt@kernel.org
Subject: Re: [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema
Date: Thu, 09 Jul 2026 14:31:01 -0500	[thread overview]
Message-ID: <178362546037.1021520.7768707354122248220.robh@kernel.org> (raw)
In-Reply-To: <20260709181724.24682-2-avermoal@gmail.com>


On Fri, 10 Jul 2026 00:17:25 +0600, Mikhail Lukianchikov wrote:
> Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
> documentation from plain text to DT schema.
> 
> The conversion adds proper validation for the 'microchip,led-modes'
> property inside the MDIO node and updates the MAINTAINERS entry.
> 
> Signed-off-by: Mikhail Lukianchikov <avermoal@gmail.com>
> ---
> Changes in v2:
>  - Rename file to microchip,lan7800.yaml.
>  - Keeps only one maintainer.
>  - Code style fixed.
>  - Example fixed, remove usb-port@1 node.
>  - Move patternProperties for PHY inside mdio node to fix validation. (suggested by sashiko-bot)
> 
> Link to v1: https://lore.kernel.org/netdev/20260707165840.107409-1-avermoal@gmail.com
> 
>  .../bindings/net/microchip,lan7800.yaml       | 105 ++++++++++++++++++
>  .../bindings/net/microchip,lan78xx.txt        |  53 ---------
>  MAINTAINERS                                   |   3 +-
>  3 files changed, 106 insertions(+), 55 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /: 'compatible' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /: 'model' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /: '#address-cells' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /: '#size-cells' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /usb: failed to match any schema with compatible: ['usb-host']

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260709181724.24682-2-avermoal@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2026-07-09 19:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 18:17 [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema Mikhail Lukianchikov
2026-07-09 19:31 ` Rob Herring (Arm) [this message]
2026-07-10 18:20 ` sashiko-bot
2026-07-10 21:23 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178362546037.1021520.7768707354122248220.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Rengarajan.S@microchip.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=avermoal@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox