Re: [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The ethernet-phy node schema incorrectly rejects standard Ethernet PHY properties by using `additionalProperties: false` without referencing `ethernet-phy.yaml`.
--

--- Patch [1]: [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema ---
commit 484d7e78e4b223fac4e7382aab39e598f0a7d9b3
Author: Mikhail Lukianchikov <avermoal@gmail.com>

dt-bindings: net: microchip,lan78xx: convert to DT schema
    
Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
documentation from plain text to DT schema. The conversion adds proper
validation for the 'microchip,led-modes' property inside the MDIO node.

Link: https://lore.kernel.org/netdev/20260707165840.107409-1-avermoal@gmail.com

> diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> new file mode 100644
> index 0000000000000..289980c231810
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
[ ... ]
> +    patternProperties:
> +      "^ethernet-phy(@[0-9a-f]+)?$":
> +        type: object
> +        description: |
> +          PHY node for the embedded or external PHY. The PHY address is
> +          given by the 'reg' property.
> +
> +        properties:
> +          reg:
> +            maxItems: 1
> +            description: PHY address.
> +
> +          microchip,led-modes:
> +            $ref: /schemas/types.yaml#/definitions/uint32-array
> +            minItems: 1
> +            maxItems: 4
> +            description:
> +              Array of LED mode values for each of up to 4 LEDs.
> +              Omitted LEDs are turned off. Allowed values are defined
> +              in include/dt-bindings/net/microchip-lan78xx.h.
> +
> +        required:
> +          - reg
> +
> +        additionalProperties: false

[Severity: Medium]
Will this schema definition incorrectly reject standard Ethernet PHY properties?

Using additionalProperties: false here without an explicit 
$ref: /schemas/net/ethernet-phy.yaml# strictly forbids all standard
Ethernet PHY properties (like max-speed, interrupts, or reset-gpios) 
on the child ethernet-phy node. 

This causes the dt-schema validation to fail for boards that legitimately 
describe their hardware PHY connections, which forces users to omit valid 
device descriptions to pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709181724.24682-2-avermoal@gmail.com?part=1