Devicetree
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: i2c: renesas,riic: Drop clock-frequency from required
@ 2026-08-06 11:10 Tommaso Merciai
  2026-08-06 12:16 ` Geert Uytterhoeven
  2026-08-12  2:56 ` Rob Herring (Arm)
  0 siblings, 2 replies; 3+ messages in thread
From: Tommaso Merciai @ 2026-08-06 11:10 UTC (permalink / raw)
  To: tomm.merciai
  Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Chris Brandt,
	Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Wolfram Sang, linux-i2c,
	devicetree, linux-kernel

clock-frequency is described as optional, with 100 kHz assumed when
absent, yet it is also listed as required.

The description is correct: i2c-riic calls i2c_parse_fw_timings() with
use_defaults set, so the core falls back to I2C_MAX_STANDARD_MODE_FREQ
when the property is absent.

The stale requirement only produces dtbs_check noise on boards relying
on the default:

  i2c@14400800 (renesas,riic-r9a09g047): 'clock-frequency' is a
  required property

Drop it.

Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
v1->v2:
 - Dropped all v1 series, need a rework.
 - Fixed dtbs_check failure by dropping clock-frequency from the required list,
   instead of adding it to the dts, as the absence of this property
   indicates the default frequency 100 kHz.
   v1: https://lore.kernel.org/all/20260803132828.3249424-3-tommaso.merciai.xr@bp.renesas.com/

 Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index ae1f71eadc66..c5d07b722c43 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -95,7 +95,6 @@ required:
   - interrupts
   - interrupt-names
   - clocks
-  - clock-frequency
   - power-domains
   - '#address-cells'
   - '#size-cells'
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: i2c: renesas,riic: Drop clock-frequency from required
  2026-08-06 11:10 [PATCH v2] dt-bindings: i2c: renesas,riic: Drop clock-frequency from required Tommaso Merciai
@ 2026-08-06 12:16 ` Geert Uytterhoeven
  2026-08-12  2:56 ` Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2026-08-06 12:16 UTC (permalink / raw)
  To: Tommaso Merciai
  Cc: tomm.merciai, linux-renesas-soc, biju.das.jz, Chris Brandt,
	Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Magnus Damm, Wolfram Sang, linux-i2c, devicetree, linux-kernel

On Thu, 6 Aug 2026 at 13:10, Tommaso Merciai
<tommaso.merciai.xr@bp.renesas.com> wrote:
> clock-frequency is described as optional, with 100 kHz assumed when
> absent, yet it is also listed as required.
>
> The description is correct: i2c-riic calls i2c_parse_fw_timings() with
> use_defaults set, so the core falls back to I2C_MAX_STANDARD_MODE_FREQ
> when the property is absent.
>
> The stale requirement only produces dtbs_check noise on boards relying
> on the default:
>
>   i2c@14400800 (renesas,riic-r9a09g047): 'clock-frequency' is a
>   required property
>
> Drop it.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: i2c: renesas,riic: Drop clock-frequency from required
  2026-08-06 11:10 [PATCH v2] dt-bindings: i2c: renesas,riic: Drop clock-frequency from required Tommaso Merciai
  2026-08-06 12:16 ` Geert Uytterhoeven
@ 2026-08-12  2:56 ` Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-08-12  2:56 UTC (permalink / raw)
  To: Tommaso Merciai
  Cc: tomm.merciai, Andi Shyti, Wolfram Sang, Magnus Damm, Chris Brandt,
	devicetree, Krzysztof Kozlowski, Geert Uytterhoeven, linux-i2c,
	linux-renesas-soc, linux-kernel, Conor Dooley, biju.das.jz


On Thu, 06 Aug 2026 13:10:13 +0200, Tommaso Merciai wrote:
> clock-frequency is described as optional, with 100 kHz assumed when
> absent, yet it is also listed as required.
> 
> The description is correct: i2c-riic calls i2c_parse_fw_timings() with
> use_defaults set, so the core falls back to I2C_MAX_STANDARD_MODE_FREQ
> when the property is absent.
> 
> The stale requirement only produces dtbs_check noise on boards relying
> on the default:
> 
>   i2c@14400800 (renesas,riic-r9a09g047): 'clock-frequency' is a
>   required property
> 
> Drop it.
> 
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
> v1->v2:
>  - Dropped all v1 series, need a rework.
>  - Fixed dtbs_check failure by dropping clock-frequency from the required list,
>    instead of adding it to the dts, as the absence of this property
>    indicates the default frequency 100 kHz.
>    v1: https://lore.kernel.org/all/20260803132828.3249424-3-tommaso.merciai.xr@bp.renesas.com/
> 
>  Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-12  2:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 11:10 [PATCH v2] dt-bindings: i2c: renesas,riic: Drop clock-frequency from required Tommaso Merciai
2026-08-06 12:16 ` Geert Uytterhoeven
2026-08-12  2:56 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox