Re: [PATCH 08/12] dt-bindings: net: snps,dwmac: Add compatible for UltraRISC DP1000 SoC

From: Jia Wang <wangjia@ultrarisc.com>
To: Jia Wang <wangjia@ultrarisc.com>
Cc: Conor Dooley <conor@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Alexandre Ghiti <alex@ghiti.fr>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	 Thomas Gleixner <tglx@kernel.org>,
	 Samuel Holland <samuel.holland@sifive.com>,
	 Anup Patel <anup@brainfault.org>,
	Mark Brown <broonie@kernel.org>,
	 Andi Shyti <andi.shyti@kernel.org>,
	 Mika Westerberg <mika.westerberg@linux.intel.com>,
	 Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	 Alexandre Torgue <alexandre.torgue@foss.st.com>,
	 Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	 Jose Abreu <joabreu@synopsys.com>,
	 Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	 Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@sifive.com>,
	devicetree@vger.kernel.org,  linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org,  linux-spi@vger.kernel.org,
	linux-i2c@vger.kernel.org,  netdev@vger.kernel.org,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH 08/12] dt-bindings: net: snps,dwmac: Add compatible for UltraRISC DP1000 SoC
Date: Thu, 27 Aug 2026 16:17:16 +0800	[thread overview]
Message-ID: <178781863615.2006105.6267469136684218126.b4-reply@b4> (raw)
In-Reply-To: <178765275795.744215.4911904858473260204.b4-reply@b4>

On 2026-08-25 18:12 +0800, Jia Wang wrote:
> On 2026-08-24 18:13 +0100, Conor Dooley wrote:
> > On Mon, Aug 24, 2026 at 06:09:48PM +0100, Conor Dooley wrote:
> > > On Mon, Aug 24, 2026 at 01:54:21PM +0800, Jia Wang via B4 Relay wrote:
> > > > From: Jia Wang <wangjia@ultrarisc.com>
> > > > 
> > > > Add the SoC-specific compatible string for the UltraRISC DP1000 GMAC
> > > > controller to the DesignWare MAC binding.
> > > > 
> > > > Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
> > > 
> > > The dts may not be right, but I am also a bit concerned here.
> > > 
> > > This binding permits 100s of combinations of properties, of which only
> > > a very limited set can be correct for your device. Just adding the
> > > compatible permits all of this variation.
> > > 
> > > Please add some restrictions.
> > 
> > In fact, it's particularly bad here because you don't even restrict
> > which fallback compatibles are used, so there's no guidance on what
> > version of the IP is even in use!
> > 
> 
> I have rechecked the DTS against the hardware. The controller uses a
> DesignWare GMAC IP from the 5.20 series, with "snps,dwmac-5.20" as its
> version-specific fallback.
> 
> In the next version, I will restrict the fallback compatibles and add
> DP1000-specific constraints for its hardware resources.
> 

Following the discussion in patch 11, I will drop this patch from v2. I
will first submit the dedicated DP1000 GMAC binding and DWMAC glue driver
as a separate series, and then send v2 of this DTS series with that
dependency recorded.

> > > 
> > > pw-bot: changes-requested
> > > 
> > > Thanks,
> > > Conor.
> > >
> 
> Best regards,
> Jia Wang
>  

Best regards,
Jia Wang

> > > > ---
> > > >  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > > index 2449311c6d28..2ed4564ae99d 100644
> > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > > @@ -119,6 +119,7 @@ properties:
> > > >          - starfive,jh7110-dwmac
> > > >          - tesla,fsd-ethqos
> > > >          - thead,th1520-gmac
> > > > +        - ultrarisc,dp1000-gmac
> > > >  
> > > >    reg:
> > > >      minItems: 1
> > > > 
> > > > -- 
> > > > 2.34.1
> > > > 
> > > > 
> > > > 
> > > > _______________________________________________
> > > > linux-riscv mailing list
> > > > linux-riscv@lists.infradead.org
> > > > http://lists.infradead.org/mailman/listinfo/linux-riscv
> > 
> > 
> 
> 
> 