* [PATCH] arm64: dts: qcom: x1-denali: Fix microphone distortion
@ 2026-08-30 17:40 Dale Whinham
2026-08-31 8:32 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dale Whinham @ 2026-08-30 17:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Dale Whinham
The microphones (2x) on Surface Pro 11 are currently ususable due to a
misconfigured sample rate, which results in a very distorted recording
with the voice barely audible.
Under Windows, the DMIC0_CTL register is set to 0x00000005 while
recording:
bit 0 = 1 --> DMIC0 enabled
bits 3:1 = 2 --> DMIC clock divider = /4
The current dmic-sample-rate of 4800000 corresponds to the default DMIC
clock divider of /2.
Dropping dmic-sample-rate to 2400000 sets the divider to /4, matching
the working Windows configuration and resulting in perfect audio.
While we're at it, remove the reference to dmic23_default, as we only
have two microphones and don't need to configure the pins for a 3rd/4th
microphone.
Signed-off-by: Dale Whinham <daleyo@gmail.com>
---
arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi b/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
index 7559557610ed..28ca2fe678ef 100644
--- a/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
@@ -863,11 +863,11 @@ spkr_01_sd_n_active: spkr-01-sd-n-active-state {
};
&lpass_vamacro {
- pinctrl-0 = <&dmic01_default>, <&dmic23_default>;
+ pinctrl-0 = <&dmic01_default>;
pinctrl-names = "default";
vdd-micb-supply = <&vreg_l1b_1p8>;
- qcom,dmic-sample-rate = <4800000>;
+ qcom,dmic-sample-rate = <2400000>;
};
&mdss {
---
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
change-id: 20260830-surface-pro-11-mic-fix-4b5878500266
Best regards,
--
Dale Whinham <daleyo@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: x1-denali: Fix microphone distortion
2026-08-30 17:40 [PATCH] arm64: dts: qcom: x1-denali: Fix microphone distortion Dale Whinham
@ 2026-08-31 8:32 ` Konrad Dybcio
2026-08-31 8:35 ` Abel Vesa
2026-08-31 17:53 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-08-31 8:32 UTC (permalink / raw)
To: Dale Whinham, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 8/30/26 7:40 PM, Dale Whinham wrote:
> The microphones (2x) on Surface Pro 11 are currently ususable due to a
> misconfigured sample rate, which results in a very distorted recording
> with the voice barely audible.
>
> Under Windows, the DMIC0_CTL register is set to 0x00000005 while
> recording:
>
> bit 0 = 1 --> DMIC0 enabled
> bits 3:1 = 2 --> DMIC clock divider = /4
>
> The current dmic-sample-rate of 4800000 corresponds to the default DMIC
> clock divider of /2.
>
> Dropping dmic-sample-rate to 2400000 sets the divider to /4, matching
> the working Windows configuration and resulting in perfect audio.
>
> While we're at it, remove the reference to dmic23_default, as we only
> have two microphones and don't need to configure the pins for a 3rd/4th
> microphone.
>
> Signed-off-by: Dale Whinham <daleyo@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: x1-denali: Fix microphone distortion
2026-08-30 17:40 [PATCH] arm64: dts: qcom: x1-denali: Fix microphone distortion Dale Whinham
2026-08-31 8:32 ` Konrad Dybcio
@ 2026-08-31 8:35 ` Abel Vesa
2026-08-31 17:53 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2026-08-31 8:35 UTC (permalink / raw)
To: Dale Whinham
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On 26-08-30 18:40:07, Dale Whinham wrote:
> The microphones (2x) on Surface Pro 11 are currently ususable due to a
> misconfigured sample rate, which results in a very distorted recording
> with the voice barely audible.
>
> Under Windows, the DMIC0_CTL register is set to 0x00000005 while
> recording:
>
> bit 0 = 1 --> DMIC0 enabled
> bits 3:1 = 2 --> DMIC clock divider = /4
>
> The current dmic-sample-rate of 4800000 corresponds to the default DMIC
> clock divider of /2.
>
> Dropping dmic-sample-rate to 2400000 sets the divider to /4, matching
> the working Windows configuration and resulting in perfect audio.
>
> While we're at it, remove the reference to dmic23_default, as we only
> have two microphones and don't need to configure the pins for a 3rd/4th
> microphone.
>
> Signed-off-by: Dale Whinham <daleyo@gmail.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: x1-denali: Fix microphone distortion
2026-08-30 17:40 [PATCH] arm64: dts: qcom: x1-denali: Fix microphone distortion Dale Whinham
2026-08-31 8:32 ` Konrad Dybcio
2026-08-31 8:35 ` Abel Vesa
@ 2026-08-31 17:53 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-08-31 17:53 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dale Whinham
Cc: linux-arm-msm, devicetree, linux-kernel
On Sun, 30 Aug 2026 18:40:07 +0100, Dale Whinham wrote:
> The microphones (2x) on Surface Pro 11 are currently ususable due to a
> misconfigured sample rate, which results in a very distorted recording
> with the voice barely audible.
>
> Under Windows, the DMIC0_CTL register is set to 0x00000005 while
> recording:
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: x1-denali: Fix microphone distortion
commit: 35ce3c571297aee13c6da604d022929fd1aa9efb
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-31 17:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-30 17:40 [PATCH] arm64: dts: qcom: x1-denali: Fix microphone distortion Dale Whinham
2026-08-31 8:32 ` Konrad Dybcio
2026-08-31 8:35 ` Abel Vesa
2026-08-31 17:53 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox