Re: [PATCH net-next v14 4/4] net: dsa: ks8995: Delete surplus driver

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Documentation/devicetree/bindings/net/dsa/micrel,ks8995.yaml
  survives the deletion of drivers/net/dsa/ks8995.c and remains the ONLY…

--

net: dsa: ks8995: Delete surplus driver

This removes drivers/net/dsa/ks8995.c, drops the Makefile entry, and turns
NET_DSA_KS8995 into a transitional Kconfig stub that selects the Microchip
KSZ SPI driver instead.

> diff --git a/drivers/net/dsa/Makefile b/drivers/net/dsa/Makefile
> index df849cd0e640e..7e637d56b35c8 100644
> --- a/drivers/net/dsa/Makefile
> +++ b/drivers/net/dsa/Makefile
> @@ -2,7 +2,6 @@
>  obj-$(CONFIG_NET_DSA_BCM_SF2)	+= bcm-sf2.o
>  bcm-sf2-objs			:= bcm_sf2.o bcm_sf2_cfp.o
>  obj-$(CONFIG_NET_DSA_LOOP)	+= dsa_loop.o
> -obj-$(CONFIG_NET_DSA_KS8995) 	+= ks8995.o
>  obj-$(CONFIG_NET_DSA_MT7530)	+= mt7530.o
>  obj-$(CONFIG_NET_DSA_MT7530_MDIO) += mt7530-mdio.o
>  obj-$(CONFIG_NET_DSA_MT7530_MMIO) += mt7530-mmio.o

> diff --git a/drivers/net/dsa/ks8995.c b/drivers/net/dsa/ks8995.c
> deleted file mode 100644
> index 77d8b842693c1..0000000000000
> --- a/drivers/net/dsa/ks8995.c
> +++ /dev/null
> @@ -1,857 +0,0 @@

[Severity: Low]
Should Documentation/devicetree/bindings/net/dsa/micrel,ks8995.yaml go away
with the driver, or be folded into microchip,ksz.yaml?

After this patch that schema is the only binding documenting
"micrel,ks8995", "micrel,ksz8795" and "micrel,ksz8864", while the only
remaining implementation of those strings is ksz_dt_ids[] in
drivers/net/dsa/microchip/ksz_spi.c:

	{ .compatible = "micrel,ksz8864", .data = &ksz_switch_chips[KSZ8864] },
	{ .compatible = "micrel,ksz8795", .data = &ksz_switch_chips[KSZ8795] },
	{ .compatible = "micrel,ks8995",  .data = &ksz_switch_chips[KSZ8995XA] },

The two schemas then disagree on the legal property set for the same
silicon and the same driver. micrel,ks8995.yaml allows only compatible,
reg and reset-gpios, plus dsa.yaml#/$defs/ethernet-ports and
spi-peripheral-props, and ends with:

	unevaluatedProperties: false

while microchip,ksz.yaml additionally documents pinctrl-names (including
the "reset" strap state), wakeup-source, interrupts, the microchip,*
properties and an mdio child node.

Does this mean a device tree that uses a micrel,* compatible together with,
say, interrupts or microchip,synclko-125 will probe and work through
ksz_spi.c but fail make dt_binding_check?

The description in micrel,ks8995.yaml also still describes the deleted
driver's model:

	The chip itself is managed over SPI, but all the PHYs need to be
	accessed from an external MDIO channel.

which does not match the KSZ driver's handling of these ports as internal
PHYs. The two in-tree nodes named in the commit message,
arch/arm/boot/dts/intel/ixp/intel-ixp42x-linksys-wrv54g.dts and
intel-ixp42x-actiontec-mi424wr.dtsi, are therefore validated against a
schema written for a driver that no longer exists.

Would it be cleaner to add the three legacy micrel compatibles to
microchip,ksz.yaml as deprecated aliases and delete micrel,ks8995.yaml in
this patch?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260914-ks8995-to-ksz8-v14-0-3d72692b3c97%40kernel.org