Devicetree
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: dma: dma40: Restore disabled-channels
@ 2026-09-18 15:46 Linus Walleij
  2026-09-28 19:44 ` Rob Herring (Arm)
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Linus Walleij @ 2026-09-18 15:46 UTC (permalink / raw)
  To: Vinod Koul, Frank Li, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: dmaengine, devicetree, Linus Walleij

The conversion of the DMA40 binding to YAML omitted the optional
disabled-channels property from the original text binding. The driver still
parses this property, but additionalProperties: false rejects any device
tree using it.

Restore disabled-channels and constrain it to the physical channel range.
Also constrain memcpy-channels to the limits enforced by the driver and
reject duplicate channel entries in both properties.

Fixes: 23fbc87c8ae6 ("dt-bindings: dma: Rewrite ST-Ericsson DMA40 to YAML")
Assisted-by: LLM
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
 .../devicetree/bindings/dma/stericsson,dma40.yaml          | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
index d8f92838f4c9..81b83603ea79 100644
--- a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
+++ b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
@@ -140,8 +140,22 @@ properties:
       - description: LCPA (Logical Channel Parameter Address) memory.
       - description: LCLA (Logical Channel Link base Address) memory.
 
+  disabled-channels:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 1
+    maxItems: 31
+    uniqueItems: true
+    items:
+      maximum: 31
+    description: Physical channels that cannot be used by the DMA engine.
+
   memcpy-channels:
     $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 1
+    maxItems: 8
+    uniqueItems: true
+    items:
+      maximum: 63
     description: Array of u32 elements indicating which channels on the DMA
       engine are eligible for memcpy transfers
 

---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260918-dma40-dt-disabled-channels-21b1ccdd8e7b

Best regards,
-- 
Linus Walleij <linusw@kernel.org>


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: dma: dma40: Restore disabled-channels
  2026-09-18 15:46 [PATCH] dt-bindings: dma: dma40: Restore disabled-channels Linus Walleij
@ 2026-09-28 19:44 ` Rob Herring (Arm)
  2026-10-06 10:18 ` Linus Walleij
  2026-10-07 11:01 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2026-09-28 19:44 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Krzysztof Kozlowski, devicetree, Frank Li, dmaengine, Vinod Koul,
	Conor Dooley


On Fri, 18 Sep 2026 17:46:45 +0200, Linus Walleij wrote:
> The conversion of the DMA40 binding to YAML omitted the optional
> disabled-channels property from the original text binding. The driver still
> parses this property, but additionalProperties: false rejects any device
> tree using it.
> 
> Restore disabled-channels and constrain it to the physical channel range.
> Also constrain memcpy-channels to the limits enforced by the driver and
> reject duplicate channel entries in both properties.
> 
> Fixes: 23fbc87c8ae6 ("dt-bindings: dma: Rewrite ST-Ericsson DMA40 to YAML")
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
>  .../devicetree/bindings/dma/stericsson,dma40.yaml          | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: dma: dma40: Restore disabled-channels
  2026-09-18 15:46 [PATCH] dt-bindings: dma: dma40: Restore disabled-channels Linus Walleij
  2026-09-28 19:44 ` Rob Herring (Arm)
@ 2026-10-06 10:18 ` Linus Walleij
  2026-10-07 11:01 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2026-10-06 10:18 UTC (permalink / raw)
  To: Vinod Koul, Frank Li, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: dmaengine, devicetree

Hi Vinod,

On Fri, Sep 18, 2026 at 5:46 PM Linus Walleij <linusw@kernel.org> wrote:

> The conversion of the DMA40 binding to YAML omitted the optional
> disabled-channels property from the original text binding. The driver still
> parses this property, but additionalProperties: false rejects any device
> tree using it.
>
> Restore disabled-channels and constrain it to the physical channel range.
> Also constrain memcpy-channels to the limits enforced by the driver and
> reject duplicate channel entries in both properties.
>
> Fixes: 23fbc87c8ae6 ("dt-bindings: dma: Rewrite ST-Ericsson DMA40 to YAML")
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>

This seems ready to be applied now with Rob's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: dma: dma40: Restore disabled-channels
  2026-09-18 15:46 [PATCH] dt-bindings: dma: dma40: Restore disabled-channels Linus Walleij
  2026-09-28 19:44 ` Rob Herring (Arm)
  2026-10-06 10:18 ` Linus Walleij
@ 2026-10-07 11:01 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2026-10-07 11:01 UTC (permalink / raw)
  To: Frank Li, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Linus Walleij
  Cc: dmaengine, devicetree


On Fri, 18 Sep 2026 17:46:45 +0200, Linus Walleij wrote:
> The conversion of the DMA40 binding to YAML omitted the optional
> disabled-channels property from the original text binding. The driver still
> parses this property, but additionalProperties: false rejects any device
> tree using it.
> 
> Restore disabled-channels and constrain it to the physical channel range.
> Also constrain memcpy-channels to the limits enforced by the driver and
> reject duplicate channel entries in both properties.
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: dma: dma40: Restore disabled-channels
      commit: 38d97b1122e02f6b8859e660990aaeda1c32e00f

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-07 11:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-18 15:46 [PATCH] dt-bindings: dma: dma40: Restore disabled-channels Linus Walleij
2026-09-28 19:44 ` Rob Herring (Arm)
2026-10-06 10:18 ` Linus Walleij
2026-10-07 11:01 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox