From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
Rob Herring <robh@kernel.org>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org, lars@metafoo.de,
linux-iio@vger.kernel.org, jic23@kernel.org,
Michael.Hennerich@analog.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add AD4000
Date: Sat, 23 Mar 2024 11:58:03 +0100 [thread overview]
Message-ID: <17d410dd-bb9b-4962-bd53-1385d25d898b@linaro.org> (raw)
In-Reply-To: <Zf5Mhm4KRQzu9qZs@debian-BULLSEYE-live-builder-AMD64>
On 23/03/2024 04:29, Marcelo Schmitt wrote:
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4000.example.dtb: adc@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
>> from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad4000.yaml#
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4000.example.dtb: adc@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
>> from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad4000.yaml#
>>
>
> ok, adding proper #address-cells and #size-cells fixes the warning.
>
> '#address-cells':
> const: 1
>
> '#size-cells':
> const: 0
>
> I'm assuming missing those in v1 doesn't hurt review so will wait for some
> feedback before sending a v2.
Hurts in a way it is a proof you did not test your binding before
sending. Performing review on untested code might be a waste of
reviewers time. Please test your code before sending it. I am not going
to perform review of untested code.
It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-23 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 22:04 [PATCH 0/2] Add support for AD4000 series Marcelo Schmitt
2024-03-22 22:05 ` [PATCH 1/2] dt-bindings: iio: adc: Add AD4000 Marcelo Schmitt
2024-03-22 23:28 ` Rob Herring
2024-03-23 3:29 ` Marcelo Schmitt
2024-03-23 10:58 ` Krzysztof Kozlowski [this message]
2024-03-23 18:44 ` Jonathan Cameron
2024-03-23 20:18 ` David Lechner
2024-03-23 20:38 ` David Lechner
2024-03-23 21:35 ` Marcelo Schmitt
2024-03-22 22:05 ` [PATCH 2/2] iio: adc: Add support for AD4000 Marcelo Schmitt
2024-03-23 19:12 ` Jonathan Cameron
2024-03-23 21:53 ` David Lechner
2024-03-24 12:45 ` Jonathan Cameron
2024-03-25 13:35 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17d410dd-bb9b-4962-bd53-1385d25d898b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox