From: Luna Hart <lhart.opensource@witekio.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Luna Hart <lhart.opensource@witekio.com>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Flaviu Nistor <flaviu.nistor@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add TI TPS389004/TPS389006/TPS389008
Date: Fri, 2 Oct 2026 16:57:24 -0700 [thread overview]
Message-ID: <191be387-b7d0-44c4-9f7b-ae820b8e7162@witekio.com> (raw)
In-Reply-To: <20261001-greedy-skink-from-sirius-b13f9e@quoll>
On 10/1/26 1:17 AM, Krzysztof Kozlowski wrote:
>> + const: 0
>> +
>> +patternProperties:
>> + "^vmon@[0-7]$":
>
> How is this called for other devices? "channel"?
It looks like "channel" is most common (perhaps "input" would be valid
too, from the ti,ina3221).
The V2 patch set changes this to "channel".
>> + If no child nodes are present, all channels will be exposed for>> + monitoring. Otherwise, only the provided nodes will be created.
>
> That's a bit odd behavior. Is it expected for hwmon?
It seems not. Changing this in V2 to enable all channels by default.
Disabling channels by using the status prop explicitly instead.
--
Thank you for the quick response and review of these changes.
All other comments will be addressed in the V2 patch set, which I will
share as soon as possible.
Regards,
Luna Hart
next prev parent reply other threads:[~2026-10-02 23:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 23:04 [PATCH 0/2] hwmon: Add support for TI TPS389004/TPS389006/TPS389008 Luna Hart via B4 Relay
2026-09-29 23:04 ` [PATCH 1/2] dt-bindings: hwmon: Add " Luna Hart via B4 Relay
2026-09-29 23:17 ` sashiko-bot
2026-09-30 23:28 ` Luna HART
2026-10-01 8:17 ` Krzysztof Kozlowski
2026-10-01 8:17 ` Krzysztof Kozlowski
2026-10-02 23:57 ` Luna Hart [this message]
2026-09-29 23:04 ` [PATCH 2/2] hwmon: (tps38900x) Add driver for " Luna Hart via B4 Relay
2026-09-29 23:14 ` sashiko-bot
2026-10-01 8:19 ` Krzysztof Kozlowski
2026-10-03 0:13 ` Luna Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=191be387-b7d0-44c4-9f7b-ae820b8e7162@witekio.com \
--to=lhart.opensource@witekio.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=flaviu.nistor@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox