Re: [PATCH 1/2] dt-bindings: hwmon: Add TI TPS389004/TPS389006/TPS389008

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: silent schema validation bypass due to invalid compatible match
--

commit 6f785a9cad4f5ba27f5d71565ba1ca2b776da113
Author: Luna Hart <lhart.opensource@witekio.com>

dt-bindings: hwmon: Add TI TPS389004/TPS389006/TPS389008

Add a binding for the TI TPS389004, TPS389006, and TPS389008 I2C voltage
supervisors and monitors, which provide 4, 6, and 8 voltage inputs
respectively. Each input may be described by an optional child node,
containing additional properties including the label and ADC scaling factor.

> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tps38900x.yaml b/Documentation/devicetree/bindings/hwmon/ti,tps38900x.yaml
> new file mode 100644
> index 0000000000000..cdd74ddd03e74
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tps38900x.yaml
[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: ti,tps389004

[Severity: Medium]
Will this properly evaluate the compatible property?

In device tree bindings, dt-schema evaluates the compatible property as an
array of strings (for example, ["ti,tps389004"]). The const keyword strictly
checks for exact equivalence. Since a scalar string is not equivalent to an
array, this if condition will always evaluate to false.

Because of this, the hardware-specific constraints in the then block
restricting out-of-bounds voltage channels for the 4-channel variant are never
applied, allowing invalid configurations to silently pass dt_binding_check.

Should this use contains: const: ti,tps389004 instead?

> +    then:
> +      patternProperties:
> +        "^vmon@[4-7]$": false
> +
> +  - if:
> +      properties:
> +        compatible:
> +          const: ti,tps389006

[Severity: Medium]
Is this block also affected by the same array matching syntax issue?

Just like the 4-channel variant above, this condition will fail to match the
compatible array, bypassing the channel restrictions for the TPS389006.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929-lhart-dev-tps38900x-v1-0-7045c5894152@witekio.com?part=1