Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

[Laurent Pinchart]

Hi Geert,

On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote:
> On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote:
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> > @@ -0,0 +1,33 @@
> > +Renesas R-Car Fine Display Processor (FDP1)
> > +-------------------------------------------
> > +
> > +The FDP1 is a de-interlacing module which converts interlaced video to
> > +progressive video. It is capable of performing pixel format conversion
> > between +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are
> > supported as +an input to the module.
> > +
> > + - compatible: Must be the following
> > +
> > +   - "renesas,fdp1" for generic compatible
> > +
> > + - reg: the register base and size for the device registers
> > + - interrupts : interrupt specifier for the FDP1 instance
> > + - clocks: reference to the functional clock
> > + - renesas,fcp: reference to the FCPF connected to the FDP1
> > +
> > +Optional properties:
> > + - power-domains : power-domain property defined with a power domain
> > specifier
>                       "power domain"?
> 
> > +                            to respective power domain.
> 
> Still, too many power domains in one sentence?

How about

 - power-domains : reference to the power domain that the FDP1 belongs to, if
   any.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

[Geert Uytterhoeven]

Hi Laurent,

On Mon, Oct 24, 2016 at 11:46 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote:
>> On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote:
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt

>> > +Optional properties:
>> > + - power-domains : power-domain property defined with a power domain
>> > specifier
>>                       "power domain"?
>>
>> > +                            to respective power domain.
>>
>> Still, too many power domains in one sentence?
>
> How about
>
>  - power-domains : reference to the power domain that the FDP1 belongs to, if
>    any.

Much better. Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v4.1 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings

[Laurent Pinchart]

From: Kieran Bingham <kieran+renesas-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org>

The FDP1 is a de-interlacing module which converts interlaced video to
progressive video. It is also capable of performing pixel format conversion
between YCbCr/YUV formats and RGB formats.

Signed-off-by: Kieran Bingham <kieran+renesas-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
---
Changes since v4:

- Rewrote the power-domains property documentation
- Added a reference to the clocks and power domains providers
- Made the renesas,fcp property optional on Gen2
---
 .../devicetree/bindings/media/renesas,fdp1.txt     | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt

diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
new file mode 100644
index 000000000000..8dd1007bb573
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
@@ -0,0 +1,37 @@
+Renesas R-Car Fine Display Processor (FDP1)
+-------------------------------------------
+
+The FDP1 is a de-interlacing module which converts interlaced video to
+progressive video. It is capable of performing pixel format conversion between
+YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
+an input to the module.
+
+Required properties:
+
+ - compatible: must be "renesas,fdp1"
+ - reg: the register base and size for the device registers
+ - interrupts : interrupt specifier for the FDP1 instance
+ - clocks: reference to the functional clock
+
+Optional properties:
+
+ - power-domains: reference to the power domain that the FDP1 belongs to, if
+                  any.
+ - renesas,fcp: a phandle referencing the FCP that handles memory accesses
+                for the FDP1. Not needed on Gen2, mandatory on Gen3.
+
+Please refer to the binding documentation for the clock and/or power domain
+providers for more details.
+
+
+Device node example
+-------------------
+
+	fdp1@fe940000 {
+		compatible = "renesas,fdp1";
+		reg = <0 0xfe940000 0 0x2400>;
+		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cpg CPG_MOD 119>;
+		power-domains = <&sysc R8A7795_PD_A3VP>;
+		renesas,fcp = <&fcpf0>;
+	};
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html