From: "Heiko Stübner" <heiko@sntech.de>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
macromorgan@hotmail.com, jonas@kwiboo.se, andyshrk@163.com,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
FUKAUMI Naoki <naoki@radxa.com>,
dsimic@manjaro.org, didi.debian@cknow.org
Subject: Re: [PATCH] arm64: dts: rockchip: add support for device tree overlays for Radxa devices
Date: Fri, 29 Nov 2024 13:20:12 +0100 [thread overview]
Message-ID: <1952472.6tgchFWduM@diego> (raw)
In-Reply-To: <20241129002419.60404-1-naoki@radxa.com>
Hey,
Am Freitag, 29. November 2024, 01:24:19 CET schrieb FUKAUMI Naoki:
> since Radxa devices use device tree overlays[1][2][3], make base .dts
> support them.
this essentially doubles the sizes of generated DTBs.
In previous iterations there were concerns that this might overload
allocated memory in legacy firmware that might still run on people's
devices.
I'm not sure if someone did look deeper into that meanwhile and you
can't of course not require people to update u-boot just for a kernel
upgrade. Hence previous overlays do not enable those options but instead
depend on "distributions" to handle that.
So I'm definitly not sure how to proceed with this.
Heiko
> [1] arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-ep.dtso
> [2] arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-srns.dtso
> [3] https://github.com/radxa-pkg/radxa-overlays
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 28 +++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 86cc418a2255..cac3f39af82a 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -1,4 +1,32 @@
> # SPDX-License-Identifier: GPL-2.0
> +
> +# Enables support for device tree overlays for Radxa devices
> +DTC_FLAGS_rk3308-rock-pi-s := -@
> +DTC_FLAGS_rk3308-rock-s0 := -@
> +DTC_FLAGS_rk3328-rock-pi-e := -@
> +DTC_FLAGS_rk3399-rock-4c-plus := -@
> +DTC_FLAGS_rk3399-rock-4se := -@
> +DTC_FLAGS_rk3399-rock-pi-4a-plus := -@
> +DTC_FLAGS_rk3399-rock-pi-4a := -@
> +DTC_FLAGS_rk3399-rock-pi-4b-plus := -@
> +DTC_FLAGS_rk3399-rock-pi-4b := -@
> +DTC_FLAGS_rk3399-rock-pi-4c := -@
> +DTC_FLAGS_rk3399pro-rock-pi-n10 := -@
> +DTC_FLAGS_rk3528-radxa-e20c := -@
> +DTC_FLAGS_rk3566-radxa-cm3-io := -@
> +DTC_FLAGS_rk3566-radxa-cm3.dtsi := -@
> +DTC_FLAGS_rk3566-radxa-zero-3e := -@
> +DTC_FLAGS_rk3566-radxa-zero-3w := -@
> +DTC_FLAGS_rk3566-rock-3c := -@
> +DTC_FLAGS_rk3568-radxa-cm3i.dtsi := -@
> +DTC_FLAGS_rk3568-radxa-e25 := -@
> +DTC_FLAGS_rk3568-rock-3a := -@
> +DTC_FLAGS_rk3568-rock-3b := -@
> +DTC_FLAGS_rk3588-rock-5-itx := -@
> +DTC_FLAGS_rk3588-rock-5b := -@
> +DTC_FLAGS_rk3588s-rock-5a := -@
> +DTC_FLAGS_rk3588s-rock-5c := -@
> +
> dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb
>
next prev parent reply other threads:[~2024-11-29 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 0:24 [PATCH] arm64: dts: rockchip: add support for device tree overlays for Radxa devices FUKAUMI Naoki
2024-11-29 12:20 ` Heiko Stübner [this message]
2024-11-29 12:46 ` Diederik de Haas
2024-11-29 14:07 ` Heiko Stübner
2024-11-29 15:18 ` Diederik de Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1952472.6tgchFWduM@diego \
--to=heiko@sntech.de \
--cc=andyshrk@163.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=dsimic@manjaro.org \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox