Re: [PATCH] arm64: dts: rockchip: add support for device tree overlays for Radxa devices

["Diederik de Haas" <didi.debian@cknow.org>]

[-- Attachment #1: Type: text/plain, Size: 3466 bytes --]

Hi,

On Fri Nov 29, 2024 at 1:20 PM CET, Heiko Stübner wrote:
> Am Freitag, 29. November 2024, 01:24:19 CET schrieb FUKAUMI Naoki:
> > since Radxa devices use device tree overlays[1][2][3], make base .dts
> > support them.
>
> this essentially doubles the sizes of generated DTBs.
>
> In previous iterations there were concerns that this might overload
> allocated memory in legacy firmware that might still run on people's
> devices.
>
> I'm not sure if someone did look deeper into that meanwhile and you
> can't of course not require people to update u-boot just for a kernel
> upgrade. Hence previous overlays do not enable those options but instead
> depend on "distributions" to handle that.
>
> So I'm definitly not sure how to proceed with this.

In my recollection this was brought up when the restructuring of the arm
(not arm64) dts 'tree' was discussed.
So hopefully Rob can recall the details?

But IIRC, the objection was about enabling it *globally* and instead it
should be done more granually, be it on the SoC manufacturer level
('rockchip') or on the SoC ('rk3588') or on the board level as is
proposed in this patch.

e925743edc0d ("arm: dts: bcm: Enable device-tree overlay support for RPi devices")
is where it got enabled for RPi devices

I can't speak for the Debian kernel team, but the general approach is:
get it fixed (or in this case enabled) *upstream*.
That's why Aurelien Jarno (who's a DD) send it upstream.

HTH,
  Diederik

> > [1] arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-ep.dtso
> > [2] arch/arm64/boot/dts/rockchip/rk3588-rock-5b-pcie-srns.dtso
> > [3] https://github.com/radxa-pkg/radxa-overlays
> > 
> > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/Makefile | 28 +++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 86cc418a2255..cac3f39af82a 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -1,4 +1,32 @@
> >  # SPDX-License-Identifier: GPL-2.0
> > +
> > +# Enables support for device tree overlays for Radxa devices
> > +DTC_FLAGS_rk3308-rock-pi-s := -@
> > +DTC_FLAGS_rk3308-rock-s0 := -@
> > +DTC_FLAGS_rk3328-rock-pi-e := -@
> > +DTC_FLAGS_rk3399-rock-4c-plus := -@
> > +DTC_FLAGS_rk3399-rock-4se := -@
> > +DTC_FLAGS_rk3399-rock-pi-4a-plus := -@
> > +DTC_FLAGS_rk3399-rock-pi-4a := -@
> > +DTC_FLAGS_rk3399-rock-pi-4b-plus := -@
> > +DTC_FLAGS_rk3399-rock-pi-4b := -@
> > +DTC_FLAGS_rk3399-rock-pi-4c := -@
> > +DTC_FLAGS_rk3399pro-rock-pi-n10 := -@
> > +DTC_FLAGS_rk3528-radxa-e20c := -@
> > +DTC_FLAGS_rk3566-radxa-cm3-io := -@
> > +DTC_FLAGS_rk3566-radxa-cm3.dtsi := -@
> > +DTC_FLAGS_rk3566-radxa-zero-3e := -@
> > +DTC_FLAGS_rk3566-radxa-zero-3w := -@
> > +DTC_FLAGS_rk3566-rock-3c := -@
> > +DTC_FLAGS_rk3568-radxa-cm3i.dtsi := -@
> > +DTC_FLAGS_rk3568-radxa-e25 := -@
> > +DTC_FLAGS_rk3568-rock-3a := -@
> > +DTC_FLAGS_rk3568-rock-3b := -@
> > +DTC_FLAGS_rk3588-rock-5-itx := -@
> > +DTC_FLAGS_rk3588-rock-5b := -@
> > +DTC_FLAGS_rk3588s-rock-5a := -@
> > +DTC_FLAGS_rk3588s-rock-5c := -@
> > +
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]