From: "Sascha Hauer" <s.hauer@pengutronix.de>
To: "Conor Dooley" <conor@kernel.org>
Cc: "Sascha Hauer" <s.hauer@pengutronix.de>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hverkuil@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Gerald Loacker" <gerald.loacker@wolfvision.net>,
"Lucas Sinn" <lucas.sinn@wolfvision.net>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
kernel@collabora.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] dt-bindings: media: snps,dw-hdmi-rx: make hpd-gpios optional
Date: Thu, 24 Sep 2026 06:12:08 +0000 [thread overview]
Message-ID: <1a0c76db-7dd4-441a-9308-c70d29e2be99@pengutronix.de> (raw)
In-Reply-To: <20260923-unwilling-bucktooth-8b28f745a5a0@spud>
On 2026-09-23 17:46, Conor Dooley wrote:
> On Wed, Sep 23, 2026 at 03:44:45PM +0200, Sascha Hauer wrote:
> > hpd-gpios is the +5V line of the HDMI connector, which the source drives
> > to announce itself. On a board whose HDMI connector belongs to a bridge
> > placed in front of this receiver, that line goes to the bridge and there
> > is nothing for the receiver to sense, so the property cannot be
> > provided.
> >
> > Drop it from the required list and describe what it actually carries.
> > The name is unfortunate: the hot plug detect line the receiver drives
> > back at the source is a controller register, not this GPIO.
> >
> > Assisted-by: Claude:claude-opus-5
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> > index 7e66dcbdfe2cb..9c6c377417c0b 100644
> > --- a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> > +++ b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> > @@ -63,7 +63,12 @@ properties:
> > maxItems: 1
> >
> > hpd-gpios:
> > - description: GPIO specifier for HPD.
> > + description:
> > + The +5V line of the HDMI connector, which the source drives to announce
> > + itself. Despite the name this is an input to the receiver; the hot plug
> > + detect line the receiver drives back at the source is handled inside the
> > + controller. Absent when the connector belongs to a bridge in front of
> > + this receiver rather than to the receiver itself.
> > maxItems: 1
> >
> > port:
> > @@ -96,7 +101,6 @@ required:
> > - power-domains
> > - resets
> > - pinctrl-0
> > - - hpd-gpios
>
> Would it be a good idea to require either this or ports, rather than
> remove it? Just to keep the coverage up since I assume the feature is
> required without the bridge. Perhaps that's not the case and this is
> genuinely not needed.
Yes, makes sense. One or the other should be required. Will change next
round.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-09-24 6:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 13:44 [PATCH 0/9] media: synopsys: hdmirx: support an HDMI bridge in front of the receiver Sascha Hauer
2026-09-23 13:44 ` [PATCH 1/9] media: synopsys: hdmirx: add media device infrastructure Sascha Hauer
2026-09-23 13:44 ` [PATCH 2/9] media: synopsys: hdmirx: add media entity for video capture device Sascha Hauer
2026-09-23 13:44 ` [PATCH 3/9] dt-bindings: media: snps,dw-hdmi-rx: add the source port Sascha Hauer
2026-09-23 16:34 ` Conor Dooley
2026-09-23 13:44 ` [PATCH 4/9] media: synopsys: hdmirx: add async subdevice support Sascha Hauer
2026-09-23 13:58 ` sashiko-bot
2026-09-23 13:44 ` [PATCH 5/9] media: synopsys: hdmirx: give the signal lock wait a real timeout Sascha Hauer
2026-09-23 13:44 ` [PATCH 6/9] dt-bindings: media: snps,dw-hdmi-rx: make hpd-gpios optional Sascha Hauer
2026-09-23 16:46 ` Conor Dooley
2026-09-24 6:12 ` Sascha Hauer [this message]
2026-09-23 13:44 ` [PATCH 7/9] media: synopsys: hdmirx: skip the 5V detect interrupt without a GPIO Sascha Hauer
2026-09-23 13:44 ` [PATCH 8/9] media: v4l2-subdev: notify the bridge when the source power changes Sascha Hauer
2026-09-23 13:44 ` [PATCH 9/9] media: synopsys: hdmirx: get the 5V state from the upstream subdev Sascha Hauer
2026-09-23 14:05 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a0c76db-7dd4-441a-9308-c70d29e2be99@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=gerald.loacker@wolfvision.net \
--cc=hverkuil@kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lucas.sinn@wolfvision.net \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox