Re: [PATCH v2 09/18] arm64: dts: ti: k3-j721e-sk: Add overlay for fusion application daughter board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/07/2026 13:34, Yemike Abhilash Chandra wrote:
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&{/} {
> +	clk_fusion_25M_fixed: fixed-clock-25M {

Please use name for all fixed clocks which matches current format
recommendation: 'clock-<freq>' (see also the pattern in the binding for
any other options).

https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml


> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <25000000>;
> +	};
> +};
> +
> +
> +&cam0_i2c {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	deser@3d {
> +		compatible = "ti,ds90ub960-q1";
> +		reg = <0x3d>;
> +		clocks = <&clk_fusion_25M_fixed>;
> +		clock-names = "refclk";
> +		i2c-alias-pool = <0x4a 0x4b 0x4c 0x4d 0x4e 0x4f>;
> +
> +		deserializer_0_ports: ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				status = "disabled";
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +				status = "disabled";
> +			};
> +
> +			port@2 {
> +				reg = <2>;
> +				status = "disabled";
> +			};
> +
> +			port@3 {
> +				reg = <3>;
> +				status = "disabled";
> +			};
> +
> +			/* CSI-2 TX*/
> +			port@4 {
> +				reg = <4>;
> +				ds90ub960_0_csi_out: endpoint {
> +					clock-lanes = <0>;
> +					data-lanes = <1 2 3 4>;
> +					link-frequencies = /bits/ 64 <800000000>;
> +					remote-endpoint = <&csi2_phy0>;
> +				};
> +			};
> +
> +			port@5 {
> +				reg = <5>;
> +				status = "disabled";
> +			};
> +		};
> +
> +		deserializer_0_links: links {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +		};
> +	};
> +
> +	deser@36 {
> +		compatible = "ti,ds90ub960-q1";
> +		reg       = <0x36>;

Whitespace mistake.

> +		clocks = <&clk_fusion_25M_fixed>;
> +		clock-names = "refclk";
> +		i2c-alias-pool = <0x5a 0x5b 0x5c 0x5d 0x5e 0x5f>;
> +
> +		deserializer_1_ports: ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				status = "disabled";
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +				status = "disabled";
> +			};
> +
> +			port@2 {
> +				reg = <2>;
> +				status = "disabled";
> +			};
> +
> +			port@3 {
> +				reg = <3>;
> +				status = "disabled";
> +			};
> +
> +			/* CSI-2 TX*/
> +			port@4 {
> +				reg = <4>;
> +				ds90ub960_1_csi_out: endpoint {
> +					clock-lanes = <0>;
> +					data-lanes = <1 2 3 4>;
> +					link-frequencies = /bits/ 64 <800000000>;
> +					remote-endpoint = <&csi2_phy1>;
> +				};
> +			};
> +
> +			port@5 {
> +				reg = <5>;
> +				status = "disabled";
> +			};
> +		};
> +
> +		deserializer_1_links: links {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +		};
> +	};
> +};
> +
> +&cdns_csi2rx0 {
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		csi0_port0: port@0 {
> +			reg = <0>;
> +			status = "okay";

Are you overriding or adding new nodes? If adding new nodes, then why
status? If overriding, then why duplicating properties and entire node path?


Best regards,
Krzysztof