From: Trevor Gamblin <tgamblin@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"David Lechner" <dlechner@baylibre.com>,
"Uwe Kleine-Konig" <u.kleine-koenig@baylibre.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 2/3] iio: adc: ad7625: add driver
Date: Mon, 9 Sep 2024 09:20:40 -0400 [thread overview]
Message-ID: <1a3e9f90-b5f9-4c12-9ec9-a61f14604b64@baylibre.com> (raw)
In-Reply-To: <20240908125905.19852719@jic23-huawei>
On 2024-09-08 07:59, Jonathan Cameron wrote:
> On Wed, 04 Sep 2024 15:14:19 -0400
> Trevor Gamblin <tgamblin@baylibre.com> wrote:
>
>> Add a driver for the AD762x and AD796x family of ADCs. These are
>> pin-compatible devices using an LVDS interface for data transfer,
>> capable of sampling at rates of 6 (AD7625), 10 (AD7626), and 5
>> (AD7960/AD7961) MSPS, respectively. They also feature multiple voltage
>> reference options based on the configuration of the EN1/EN0 pins, which
>> can be set in the devicetree.
>>
>> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> I took another look and LGTM (subject to the other review responses)
Thank you. I'll have a v5 for review shortly to address those.
>
>
> Jonathan
next prev parent reply other threads:[~2024-09-09 13:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 19:14 [PATCH v4 0/3] iio: adc: add new ad7625 driver Trevor Gamblin
2024-09-04 19:14 ` [PATCH v4 1/3] dt-bindings: iio: adc: add AD762x/AD796x ADCs Trevor Gamblin
2024-09-05 6:35 ` Krzysztof Kozlowski
2024-09-08 11:53 ` Jonathan Cameron
2024-09-04 19:14 ` [PATCH v4 2/3] iio: adc: ad7625: add driver Trevor Gamblin
2024-09-05 7:58 ` Nuno Sá
2024-09-05 16:18 ` Trevor Gamblin
2024-09-07 22:50 ` kernel test robot
2024-09-08 11:59 ` Jonathan Cameron
2024-09-09 13:20 ` Trevor Gamblin [this message]
2024-09-04 19:14 ` [PATCH v4 3/3] docs: iio: new docs for ad7625 driver Trevor Gamblin
2024-09-04 19:16 ` [PATCH v4 0/3] iio: adc: add new " Trevor Gamblin
2024-09-05 8:01 ` Krzysztof Kozlowski
2024-09-05 16:32 ` Trevor Gamblin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a3e9f90-b5f9-4c12-9ec9-a61f14604b64@baylibre.com \
--to=tgamblin@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox