Re: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 7/30/26 11:52 PM, Dawid Wróbel via B4 Relay wrote:
> From: Dawid Wróbel <me@dawidwrobel.com>
> 
> The Mi Pad 5 Pro 5G (enuma, 2021) is the modem-equipped variant of the
> Mi Pad 5 Pro. The board is otherwise the elish design, so describe it as
> the common device tree plus its own board ID, panel compatible and WiFi
> board data variant.

[...]

> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2025 Dawid Wróbel <me@dawidwrobel.com>

Happy new year!

> + */
> +
> +/dts-v1/;
> +
> +#include "sm8250-xiaomi-elish-common.dtsi"
> +
> +/ {
> +	model = "Xiaomi Mi Pad 5 Pro 5G";
> +	compatible = "xiaomi,enuma", "xiaomi,elish", "qcom,sm8250";
> +
> +	/* Platform type differs from elish; msm-id is inherited unchanged. */
> +	qcom,board-id = <0x2e 0>;
> +};
> +
> +&display_panel {
> +	compatible = "xiaomi,enuma-csot-nt36523", "xiaomi,elish-csot-nt36523",
> +		     "novatek,nt36523";
> +	status = "okay";

ultra nit: \n before status is preferred

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad