From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Dawid Wróbel" <me@dawidwrobel.com>
Cc: Jianhua Lu <lujianhua000@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node
Date: Tue, 4 Aug 2026 10:10:55 +0200 [thread overview]
Message-ID: <20260804-glossy-mastodon-from-sirius-db9aac@quoll> (raw)
In-Reply-To: <20260730-sm8250-xiaomi-enuma-v1-3-ed6d8fb99668@dawidwrobel.com>
On Thu, Jul 30, 2026 at 11:52:02PM +0200, Dawid Wróbel wrote:
> The Mi Pad 5 Pro 5G shares this device tree but needs its own board data
> variant, so give the node a label to allow overriding the property.
>
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---
> arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> index 19aff83ecf7b..12a2ba48340f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> @@ -817,7 +817,7 @@ &pcie0_phy {
> };
>
> &pcieport0 {
> - wifi@0 {
> + wifi_0: wifi@0 {
This is pointless on its own. Label does not end up in DTB, so your
patch has zero effect.
You miss the user of the label here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-04 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 21:51 [PATCH 0/4] arm64: dts: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
2026-07-30 21:52 ` [PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel Dawid Wróbel via B4 Relay
2026-08-04 8:10 ` Krzysztof Kozlowski
2026-07-30 21:52 ` [PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
2026-08-04 8:09 ` Krzysztof Kozlowski
2026-07-30 21:52 ` [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node Dawid Wróbel via B4 Relay
2026-08-04 8:10 ` Krzysztof Kozlowski [this message]
2026-07-30 21:52 ` [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G Dawid Wróbel via B4 Relay
2026-07-30 22:03 ` sashiko-bot
2026-08-18 10:48 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804-glossy-mastodon-from-sirius-db9aac@quoll \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=me@dawidwrobel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox