From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Don't use echo -e in run_tests.sh
Date: Thu, 12 Nov 2009 11:56:34 +1100 [thread overview]
Message-ID: <20091112005634.GJ3235@yookeroo.seuss> (raw)
In one section, the run_tests script attempts to use the -e (interpret
escapes) option to echo. This option is not portable - for example
the echo built into dash, now the default /bin/sh on several
distributions does not support it and will just echo "-e" literally.
Since we don't actually use any of the escapes that -e enables, this
patch simply removes it.
Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Index: dtc/tests/run_tests.sh
===================================================================
--- dtc.orig/tests/run_tests.sh 2009-11-12 11:52:41.000000000 +1100
+++ dtc/tests/run_tests.sh 2009-11-12 11:52:50.000000000 +1100
@@ -339,14 +339,14 @@ for set in $TESTSETS; do
esac
done
-echo -e "********** TEST SUMMARY"
-echo -e "* Total testcases: $tot_tests"
-echo -e "* PASS: $tot_pass"
-echo -e "* FAIL: $tot_fail"
-echo -e "* Bad configuration: $tot_config"
+echo "********** TEST SUMMARY"
+echo "* Total testcases: $tot_tests"
+echo "* PASS: $tot_pass"
+echo "* FAIL: $tot_fail"
+echo "* Bad configuration: $tot_config"
if [ -n "$VALGRIND" ]; then
- echo -e "* valgrind errors: $tot_vg"
+ echo "* valgrind errors: $tot_vg"
fi
-echo -e "* Strange test result: $tot_strange"
-echo -e "**********"
+echo "* Strange test result: $tot_strange"
+echo "**********"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next reply other threads:[~2009-11-12 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 0:56 David Gibson [this message]
[not found] ` <20091112005634.GJ3235-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2009-11-12 3:43 ` Don't use echo -e in run_tests.sh Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091112005634.GJ3235@yookeroo.seuss \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=jdl-CYoMK+44s/E@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox