Devicetree
 help / color / mirror / Atom feed
From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: John Bonesio <bones-RkXMcIGFT/TR7s880joybQ@public.gmane.org>
Cc: devicetree-discuss
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: dts and dtsi files on which I tested the syntax for my recent patch set.
Date: Mon, 25 Oct 2010 14:20:18 +1100	[thread overview]
Message-ID: <20101025032018.GA4741@yookeroo> (raw)
In-Reply-To: <1287613337.4535.1508.camel@riker>

On Wed, Oct 20, 2010 at 03:22:17PM -0700, John Bonesio wrote:
> Hi,
> 
> I have attached the two file I've used to test the new syntax from my
> patch set. These might help get a feel for how the syntax and the
> features work.


[snip]
> /include/ "mpc5200b.dtsi"
> 
> / {
> 	model = "fsl,media5200";
> 	compatible = "fsl,media5200";
> 
> 	aliases {
> 		console = &psc6;
> 		ethernet0 = &eth0;
> 	};
> 
> 	chosen {
> 		linux,stdout-path = &psc6;
> 	};	
> 
> 	memory {
> 		reg = <0x00000000 0x08000000>;	// 128MB RAM
> 	};
> };
> 
> &powerpc {
> 	timebase-frequency = <33000000>;	// 33 MHz, these were configured by U-Boot
> 	bus-frequency = <132000000>;		// 132 MHz
> 	clock-frequency = <396000000>;		// 396 MHz
> };
> 
> &soc {
> 	bus-frequency = <132000000>;// 132 MHz
> };
> 
> &usb {
> 	reg = <0x1000 0x100>;
> };
> 
> /remove-node/ &psc1;
> /remove-node/ &psc2;
> /remove-node/ &{soc/serial@2400};                  /* an example of using a label rooted path */
> /remove-node/ &{/soc5200@f0000000/serial@2600};  /* an example of using the path instead of the label */
> /remove-node/ &psc5;

So, this is the only concrete example for the use of /remove-node/
I've seen so far.  And it's not a really good one.  It appears you're
just removing a bunch of serial nodes from the SoC template,
presumably because they're unused / disconnected on this specific
board.

But you can managed unused devices from the SoC with existing syntax
by adding a status = "disabled" property to the node.  And I'd argue
that having the node present but disabled *more* accurately represents
the hardware for a disconnected ASIC than removing it entirely.

So, what's a genuine use for /remove-node/ that can't be done already?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

      parent reply	other threads:[~2010-10-25  3:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20 22:22 dts and dtsi files on which I tested the syntax for my recent patch set John Bonesio
2010-10-20 23:46 ` Grant Likely
     [not found]   ` <20101020234638.GB10250-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-10-21  2:08     ` John Bonesio
2010-10-21  3:14       ` David Gibson
2010-10-21  5:06         ` John Bonesio
2010-10-21  5:40           ` Grant Likely
     [not found]             ` <20101021054024.GB2252-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-10-21  5:53               ` David Gibson
2010-10-21  3:11     ` David Gibson
2010-10-25  3:20 ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101025032018.GA4741@yookeroo \
    --to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
    --cc=bones-RkXMcIGFT/TR7s880joybQ@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox