Re: [PATCH v4] hwmon: Add support for Texas Instruments ADS1015

[Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1436 bytes --]

> > ---
> > Changes since v1:
> > - fixed/extended Documentation
> > - removed unused register definitions
> > - hardcoded PGA fullscale table size
> > - made sure patch applies against v2.6.38-rc4
> > - reordered functions to avoid forward declaration
> > - results from i2c_smbus_read_word_data() are handled correctly
> > - moved locking into ads1015_read_value()
> > - removed unnecessray clearing of bit
> > - proper error handling in ads1015_read_value()
> > - use DIV_ROUND_CLOSEST for scaling result
> > - removed detect()
> > 
> > Changes since v2:
> > - removed *all* leftovers from detect()
> > - fixed return with mutex held
> > - made sysfs representation configurable
> >   (hope this will be the reference implementation for generations to come ;)
> > 
> > Changes since v3:
> > - included linux/of.h
> > - remove linux/types.h from header file
> > - sysfs is now configured with a bitmask
> > - assume big-endian of-properties
> 
> I recommend putting the revision history *above* the '---' trim line.
> It turns out to be useful to have the revision history in the commit
> text that actually gets merged into mainline.

Is this common sense meanwhile? (That is quite many additional lines per
commit)

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss