* [PATCH] drivers/of: Fix sparc build failure caused by of_alias_scan
@ 2011-08-04 7:05 Grant Likely
2011-08-04 7:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Grant Likely @ 2011-08-04 7:05 UTC (permalink / raw)
To: Stephen Rothwell, devicetree-discuss, Shawn Guo, Linus Torvalds,
linux-kernel
Commit 750f463a, "dt: add of_alias_scan and of_alias_get_id" breaks
platforms that don't use CONFIG_OF_FLATTREE, like SPARC and OLPC. Fix
it by only building it on platforms using the flat tree.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
Hi Linus,
Hand me the paper bag, I completely screwed up that last commit. The
previous commit fixes imx, but breaks SPARC. I apologize, and rightly
accept any due punishment.
This patch fixes it, and it is also pushed out to devicetree/next:
The following changes since commit
a9e4e6e14c322e08d1c615afc8f504fb415f9613:
Merge branch 'for-next' of
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending
(2011-08-03 15:12:09 -1000)
are available in the git repository at:
git://git.secretlab.ca/git/linux-2.6 devicetree/next
Grant Likely (1):
drivers/of: Fix sparc build failure caused by of_alias_scan
drivers/of/base.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index fb28b5a..c81a0fe 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1013,6 +1013,7 @@ out_unlock:
}
#endif /* defined(CONFIG_OF_DYNAMIC) */
+#ifdef CONFIG_OF_FLATTREE
static void of_alias_add(struct alias_prop *ap, struct device_node *np,
int id, const char *stem, int stem_len)
{
@@ -1118,3 +1119,4 @@ int of_alias_get_id(struct device_node *np, const char *stem)
return id;
}
EXPORT_SYMBOL_GPL(of_alias_get_id);
+#endif /* CONFIG_OF_FLATTREE */
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/of: Fix sparc build failure caused by of_alias_scan
2011-08-04 7:05 [PATCH] drivers/of: Fix sparc build failure caused by of_alias_scan Grant Likely
@ 2011-08-04 7:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-08-04 7:13 UTC (permalink / raw)
To: grant.likely-s3s/WqlpOiPyB63q8FvJNQ
Cc: sfr-3FnU+UHB4dNDw9hX6IcOSA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Date: Thu, 04 Aug 2011 08:05:42 +0100
> Commit 750f463a, "dt: add of_alias_scan and of_alias_get_id" breaks
> platforms that don't use CONFIG_OF_FLATTREE, like SPARC and OLPC. Fix
> it by only building it on platforms using the flat tree.
>
> Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Grant this is completely bogus see my email I just posted on
linux-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-04 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-04 7:05 [PATCH] drivers/of: Fix sparc build failure caused by of_alias_scan Grant Likely
2011-08-04 7:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox