From: Richard Zhao <richard.zhao@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-arm-kernel@lists.infradead.org, cpufreq@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, linux@arm.linux.org.uk,
davej@redhat.com, grant.likely@secretlab.ca,
rob.herring@calxeda.com, rdunlap@xenotime.net,
kernel@pengutronix.de, shawn.guo@linaro.org,
catalin.marinas@arm.com, eric.miao@linaro.org,
mark.langsdorf@calxeda.com, davidb@codeaurora.org, arnd@arndb.de,
bryanh@codeaurora.org, jamie@jamieiles.com, marc.zyngier@arm.com,
linaro-dev@lists.linaro.org, patches@linaro.org
Subject: Re: [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver
Date: Sat, 24 Dec 2011 16:55:42 +0800 [thread overview]
Message-ID: <20111224085539.GA1892@richard-laptop> (raw)
In-Reply-To: <20111223131851.GB13175@sirena.org.uk>
On Fri, Dec 23, 2011 at 01:18:51PM +0000, Mark Brown wrote:
> On Thu, Dec 22, 2011 at 03:09:10PM +0800, Richard Zhao wrote:
> > The driver get cpu operation point table from device tree cpu0 node,
> > and adjusts operating points using clk and regulator APIs.
>
> Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
Thanks.
> but one nit:
>
> > +Required properties in /cpus/cpu@0:
> > +- cpu-freqs : cpu frequency points it support, in unit of Hz.
> > +- cpu-volts : cpu voltages required by the frequency point at the same index,
> > + in unit of uV.
> > +- trans-latency : transition_latency, in unit of ns.
>
> trans-latency should really say what latency is being measured (the CPU
> core only or the whole operation).
dts only descibe hw info. so the transition latency is for hw.
- trans-latency : transition latency of HW, in unit of ns.
Thanks
Richard
next prev parent reply other threads:[~2011-12-24 8:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 7:09 [PATCH v4 0/7] add a generic cpufreq driver Richard Zhao
2011-12-22 7:09 ` [PATCH v4 1/7] ARM: add cpufreq transiton notifier to adjust loops_per_jiffy for smp Richard Zhao
2011-12-22 7:09 ` [PATCH v4 2/7] arm/imx: cpufreq: remove loops_per_jiffy recalculate " Richard Zhao
2011-12-22 7:09 ` [PATCH v4 3/7] cpufreq: OMAP: " Richard Zhao
2011-12-22 7:09 ` [PATCH v4 4/7] cpufreq: add clk-reg cpufreq driver Richard Zhao
2011-12-23 13:18 ` Mark Brown
2011-12-24 8:55 ` Richard Zhao [this message]
2011-12-24 12:24 ` Mark Brown
2011-12-24 13:28 ` Richard Zhao
2011-12-24 13:42 ` Mark Brown
2011-12-24 15:52 ` Richard Zhao
2011-12-26 11:10 ` Mark Brown
[not found] ` <20111226111030.GC8722-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-26 13:44 ` Richard Zhao
2011-12-26 14:22 ` Mark Brown
2011-12-27 1:51 ` Richard Zhao
[not found] ` <20111227015109.GJ15863-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
2011-12-27 10:53 ` Mark Brown
2012-01-03 9:06 ` Russell King - ARM Linux
2012-01-03 13:25 ` Richard Zhao
[not found] ` <CAH8gqwVHc9ROQYZNe6b-cUN0ycWhYj8=vJ0geBXUCYN1+XENQA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-03 13:47 ` Russell King - ARM Linux
2012-01-03 14:15 ` Richard Zhao
2012-01-03 20:26 ` Mark Brown
2011-12-24 13:10 ` Jamie Iles
2011-12-24 13:24 ` Richard Zhao
2011-12-22 7:09 ` [PATCH v4 5/7] dts/imx6q: add cpufreq property Richard Zhao
2011-12-22 7:09 ` [PATCH v4 6/7] arm/imx6q: register arm_clk as cpu to clkdev Richard Zhao
[not found] ` <1324537753-30590-1-git-send-email-richard.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-12-22 7:09 ` [PATCH v4 7/7] arm/imx6q: select ARCH_HAS_CPUFREQ Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111224085539.GA1892@richard-laptop \
--to=richard.zhao@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=bryanh@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=davidb@codeaurora.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eric.miao@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=kernel@pengutronix.de \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.langsdorf@calxeda.com \
--cc=patches@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox