* [PATCH RESEND 1/1] ARM: dts: AM33XX: Add LCDC info into am335x-evm
@ 2013-06-24 20:32 Benoit Parrot
[not found] ` <1372105967-26669-1-git-send-email-bparrot-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Benoit Parrot @ 2013-06-24 20:32 UTC (permalink / raw)
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
Add LCDC device node in DT for am33xx
Add LCDC and Panel info in DT for am335x-evm
Signed-off-by: Benoit Parrot <bparrot-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/am335x-evm.dts | 78 ++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/am33xx.dtsi | 9 +++++
2 files changed, 87 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 0423298..40d7a3f 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -44,6 +44,40 @@
0x154 0x27 /* spi0_d0.gpio0_3, INPUT | MODE7 */
>;
};
+
+ lcd_pins_s0: lcd_pins_s0 {
+ pinctrl-single,pins = <
+ 0x20 0x01 /* gpmc_ad8.lcd_data16, OUTPUT | MODE1 */
+ 0x24 0x01 /* gpmc_ad9.lcd_data17, OUTPUT | MODE1 */
+ 0x28 0x01 /* gpmc_ad10.lcd_data18, OUTPUT | MODE1 */
+ 0x2c 0x01 /* gpmc_ad11.lcd_data19, OUTPUT | MODE1 */
+ 0x30 0x01 /* gpmc_ad12.lcd_data20, OUTPUT | MODE1 */
+ 0x34 0x01 /* gpmc_ad13.lcd_data21, OUTPUT | MODE1 */
+ 0x38 0x01 /* gpmc_ad14.lcd_data22, OUTPUT | MODE1 */
+ 0x3c 0x01 /* gpmc_ad15.lcd_data23, OUTPUT | MODE1 */
+ 0xa0 0x00 /* lcd_data0.lcd_data0, OUTPUT | MODE0 */
+ 0xa4 0x00 /* lcd_data1.lcd_data1, OUTPUT | MODE0 */
+ 0xa8 0x00 /* lcd_data2.lcd_data2, OUTPUT | MODE0 */
+ 0xac 0x00 /* lcd_data3.lcd_data3, OUTPUT | MODE0 */
+ 0xb0 0x00 /* lcd_data4.lcd_data4, OUTPUT | MODE0 */
+ 0xb4 0x00 /* lcd_data5.lcd_data5, OUTPUT | MODE0 */
+ 0xb8 0x00 /* lcd_data6.lcd_data6, OUTPUT | MODE0 */
+ 0xbc 0x00 /* lcd_data7.lcd_data7, OUTPUT | MODE0 */
+ 0xc0 0x00 /* lcd_data8.lcd_data8, OUTPUT | MODE0 */
+ 0xc4 0x00 /* lcd_data9.lcd_data9, OUTPUT | MODE0 */
+ 0xc8 0x00 /* lcd_data10.lcd_data10, OUTPUT | MODE0 */
+ 0xcc 0x00 /* lcd_data11.lcd_data11, OUTPUT | MODE0 */
+ 0xd0 0x00 /* lcd_data12.lcd_data12, OUTPUT | MODE0 */
+ 0xd4 0x00 /* lcd_data13.lcd_data13, OUTPUT | MODE0 */
+ 0xd8 0x00 /* lcd_data14.lcd_data14, OUTPUT | MODE0 */
+ 0xdc 0x00 /* lcd_data15.lcd_data15, OUTPUT | MODE0 */
+ 0xe0 0x00 /* lcd_vsync.lcd_vsync, OUTPUT | MODE0 */
+ 0xe4 0x00 /* lcd_hsync.lcd_hsync, OUTPUT | MODE0 */
+ 0xe8 0x00 /* lcd_pclk.lcd_pclk, OUTPUT | MODE0 */
+ 0xec 0x00 /* lcd_ac_bias_en.lcd_ac_bias_en, OUTPUT | MODE0 */
+ >;
+ };
+
};
ocp {
@@ -102,6 +136,16 @@
reg = <0x48>;
};
};
+
+ lcdc {
+ compatible = "ti,am33xx-tilcdc";
+ reg = <0x4830e000 0x1000>;
+ interrupt-parent = <&intc>;
+ interrupts = <36>;
+ ti,hwmods = "lcdc";
+ ti,allow-non-reduced-blanking-modes;
+ status = "okay";
+ };
};
vbat: fixedregulator@0 {
@@ -158,6 +202,40 @@
gpio-key,wakeup;
};
};
+
+ panel {
+ compatible = "ti,tilcdc,panel";
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_pins_s0>;
+ panel-info {
+ ac-bias = <255>;
+ ac-bias-intrpt = <0>;
+ dma-burst-sz = <16>;
+ bpp = <32>;
+ fdd = <0x80>;
+ sync-edge = <0>;
+ sync-ctrl = <1>;
+ raster-order = <0>;
+ fifo-th = <0>;
+ };
+
+ display-timings {
+ 800x480p62 {
+ clock-frequency = <30000000>;
+ hactive = <800>;
+ vactive = <480>;
+ hfront-porch = <39>;
+ hback-porch = <39>;
+ hsync-len = <47>;
+ vback-porch = <29>;
+ vfront-porch = <13>;
+ vsync-len = <2>;
+ hsync-active = <1>;
+ vsync-active = <1>;
+ };
+ };
+ };
};
/include/ "tps65910.dtsi"
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 8e1248f..05b2c4a 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -415,5 +415,14 @@
#size-cells = <1>;
status = "disabled";
};
+
+ lcdc: lcdc@4830e000 {
+ compatible = "ti,am33xx-tilcdc";
+ reg = <0x4830e000 0x1000>;
+ interrupt-parent = <&intc>;
+ interrupts = <36>;
+ ti,hwmods = "lcdc";
+ status = "disabled";
+ };
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND 1/1] ARM: dts: AM33XX: Add LCDC info into am335x-evm
[not found] ` <1372105967-26669-1-git-send-email-bparrot-l0cyMroinI0@public.gmane.org>
@ 2013-06-25 6:50 ` Jan Lübbe
[not found] ` <1372143043.4488.50.camel-oeorZI7ca7Kzss5je/eYgj6d/iTt6vPThC4ANOJQIlc@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jan Lübbe @ 2013-06-25 6:50 UTC (permalink / raw)
To: Benoit Parrot; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On Mon, 2013-06-24 at 15:32 -0500, Benoit Parrot wrote:
> Add LCDC device node in DT for am33xx
> Add LCDC and Panel info in DT for am335x-evm
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index 0423298..40d7a3f 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -102,6 +136,16 @@
> reg = <0x48>;
> };
> };
> +
> + lcdc {
> + compatible = "ti,am33xx-tilcdc";
> + reg = <0x4830e000 0x1000>;
> + interrupt-parent = <&intc>;
> + interrupts = <36>;
> + ti,hwmods = "lcdc";
> + ti,allow-non-reduced-blanking-modes;
> + status = "okay";
> + };
> };
>
> vbat: fixedregulator@0 {
> /include/ "tps65910.dtsi"
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 8e1248f..05b2c4a 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -415,5 +415,14 @@
> #size-cells = <1>;
> status = "disabled";
> };
> +
> + lcdc: lcdc@4830e000 {
> + compatible = "ti,am33xx-tilcdc";
> + reg = <0x4830e000 0x1000>;
> + interrupt-parent = <&intc>;
> + interrupts = <36>;
> + ti,hwmods = "lcdc";
> + status = "disabled";
> + };
> };
> };
am335x-evm.dts includes am33xx.dtsi, so you shouldn't need to provide
all SoC-specific settings again in the board dts. The way it's done
here, you get two nodes ("lcdc" and "lcdc@4830e000") for the same HW
module.
It seems you just need status and maybe
ti,allow-non-reduced-blanking-modes (for which I didn't see either the
binding or the driver code yet).
Regards,
Jan
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND 1/1] ARM: dts: AM33XX: Add LCDC info into am335x-evm
[not found] ` <1372143043.4488.50.camel-oeorZI7ca7Kzss5je/eYgj6d/iTt6vPThC4ANOJQIlc@public.gmane.org>
@ 2013-06-26 22:13 ` Benoit Parrot
0 siblings, 0 replies; 3+ messages in thread
From: Benoit Parrot @ 2013-06-26 22:13 UTC (permalink / raw)
To: Jan Lübbe; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On Tue, Jun 25, 2013 at 08:50:43AM +0200, Jan Lübbe wrote:
> On Mon, 2013-06-24 at 15:32 -0500, Benoit Parrot wrote:
> > Add LCDC device node in DT for am33xx
> > Add LCDC and Panel info in DT for am335x-evm
>
> > diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> > index 0423298..40d7a3f 100644
> > --- a/arch/arm/boot/dts/am335x-evm.dts
> > +++ b/arch/arm/boot/dts/am335x-evm.dts
> > @@ -102,6 +136,16 @@
> > reg = <0x48>;
> > };
> > };
> > +
> > + lcdc {
> > + compatible = "ti,am33xx-tilcdc";
> > + reg = <0x4830e000 0x1000>;
> > + interrupt-parent = <&intc>;
> > + interrupts = <36>;
> > + ti,hwmods = "lcdc";
> > + ti,allow-non-reduced-blanking-modes;
> > + status = "okay";
> > + };
> > };
> >
> > vbat: fixedregulator@0 {
> > /include/ "tps65910.dtsi"
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index 8e1248f..05b2c4a 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -415,5 +415,14 @@
> > #size-cells = <1>;
> > status = "disabled";
> > };
> > +
> > + lcdc: lcdc@4830e000 {
> > + compatible = "ti,am33xx-tilcdc";
> > + reg = <0x4830e000 0x1000>;
> > + interrupt-parent = <&intc>;
> > + interrupts = <36>;
> > + ti,hwmods = "lcdc";
> > + status = "disabled";
> > + };
> > };
> > };
>
> am335x-evm.dts includes am33xx.dtsi, so you shouldn't need to provide
> all SoC-specific settings again in the board dts. The way it's done
> here, you get two nodes ("lcdc" and "lcdc@4830e000") for the same HW
> module.
>
> It seems you just need status and maybe
> ti,allow-non-reduced-blanking-modes (for which I didn't see either the
> binding or the driver code yet).
>
Thanks for the feedback. I did miss these cut-paste induced mistake.
I'll update the patch and resubmit.
> Regards,
> Jan
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-26 22:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-24 20:32 [PATCH RESEND 1/1] ARM: dts: AM33XX: Add LCDC info into am335x-evm Benoit Parrot
[not found] ` <1372105967-26669-1-git-send-email-bparrot-l0cyMroinI0@public.gmane.org>
2013-06-25 6:50 ` Jan Lübbe
[not found] ` <1372143043.4488.50.camel-oeorZI7ca7Kzss5je/eYgj6d/iTt6vPThC4ANOJQIlc@public.gmane.org>
2013-06-26 22:13 ` Benoit Parrot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox