* [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node [not found] <ff70173bee5f9223ffea2b92b903b4e46ef8b323.1373290150.git.michal.simek@xilinx.com> @ 2013-07-08 13:29 ` Michal Simek 2013-07-08 14:51 ` Mark Brown 0 siblings, 1 reply; 4+ messages in thread From: Michal Simek @ 2013-07-08 13:29 UTC (permalink / raw) To: linux-kernel Cc: Michal Simek, Michal Simek, Mark Brown, linux-spi, Grant Likely, Rob Herring, spi-devel-general, devicetree-discuss [-- Attachment #1: Type: text/plain, Size: 914 bytes --] It simplifies driver probing. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/spi/spi-xilinx.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c index a6bb5b0..07a7bca 100644 --- a/drivers/spi/spi-xilinx.c +++ b/drivers/spi/spi-xilinx.c @@ -372,17 +372,9 @@ static int xilinx_spi_probe(struct platform_device *pdev) if (pdata) { num_cs = pdata->num_chipselect; bits_per_word = pdata->bits_per_word; - } - - if (pdev->dev.of_node) { - const __be32 *prop; - int len; - - /* number of slave select bits is required */ - prop = of_get_property(pdev->dev.of_node, "xlnx,num-ss-bits", - &len); - if (prop && len >= sizeof(*prop)) - num_cs = __be32_to_cpup(prop); + } else { + of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits", + &num_cs); } if (!num_cs) { -- 1.8.2.3 [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node 2013-07-08 13:29 ` [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node Michal Simek @ 2013-07-08 14:51 ` Mark Brown 2013-07-09 5:26 ` Michal Simek 0 siblings, 1 reply; 4+ messages in thread From: Mark Brown @ 2013-07-08 14:51 UTC (permalink / raw) To: Michal Simek Cc: linux-kernel, Michal Simek, linux-spi, Grant Likely, Rob Herring, spi-devel-general, devicetree-discuss [-- Attachment #1: Type: text/plain, Size: 112 bytes --] On Mon, Jul 08, 2013 at 03:29:17PM +0200, Michal Simek wrote: > It simplifies driver probing. Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node 2013-07-08 14:51 ` Mark Brown @ 2013-07-09 5:26 ` Michal Simek 2013-07-09 9:14 ` Mark Brown 0 siblings, 1 reply; 4+ messages in thread From: Michal Simek @ 2013-07-09 5:26 UTC (permalink / raw) To: Mark Brown Cc: Michal Simek, linux-kernel, linux-spi, Grant Likely, Rob Herring, spi-devel-general, devicetree-discuss [-- Attachment #1: Type: text/plain, Size: 668 bytes --] Hi Mark, On 07/08/2013 04:51 PM, Mark Brown wrote: > On Mon, Jul 08, 2013 at 03:29:17PM +0200, Michal Simek wrote: >> It simplifies driver probing. > > Applied, thanks. have you applied this patch? I can't see it in your topic/xilinx branch. https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/log/?h=topic/xilinx Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 263 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node 2013-07-09 5:26 ` Michal Simek @ 2013-07-09 9:14 ` Mark Brown 0 siblings, 0 replies; 4+ messages in thread From: Mark Brown @ 2013-07-09 9:14 UTC (permalink / raw) To: Michal Simek Cc: Michal Simek, linux-kernel, linux-spi, Grant Likely, Rob Herring, spi-devel-general, devicetree-discuss [-- Attachment #1: Type: text/plain, Size: 223 bytes --] On Tue, Jul 09, 2013 at 07:26:27AM +0200, Michal Simek wrote: > On 07/08/2013 04:51 PM, Mark Brown wrote: > > Applied, thanks. > have you applied this patch? Yes, network is spotty here so pushes aren't working so well. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-09 9:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <ff70173bee5f9223ffea2b92b903b4e46ef8b323.1373290150.git.michal.simek@xilinx.com>
2013-07-08 13:29 ` [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node Michal Simek
2013-07-08 14:51 ` Mark Brown
2013-07-09 5:26 ` Michal Simek
2013-07-09 9:14 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox